Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-30 13:03:53 +01:00
Code Issues Projects Releases Wiki Activity

changing over to a value based boolean flag

Browse Source
This commit is contained in:
Joseph Flinn 2021-01-06 19:33:43 +00:00
parent 33029c1684
commit 5eb10afe85
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/build-and-sign.yml vendored
View File

@ -71,7 +71,7 @@ jobs:
npm run build npm run build
npm run pack:win npm run pack:win
env: env:
ELECTRON_BUILDER_SIGN: true ELECTRON_BUILDER_SIGN: 1
SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }} SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }}
SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }} SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }}
SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }} SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }}

2
.github/workflows/build.yml vendored
View File

@ -164,7 +164,7 @@ jobs:
shell: pwsh shell: pwsh
run: npm run dist:win:ci run: npm run dist:win:ci
env: env:
ELECTRON_BUILDER_SIGN: false ELECTRON_BUILDER_SIGN: 0
- name: Rename appx files for store - name: Rename appx files for store
shell: pwsh shell: pwsh

8
sign.js
View File

@ -1,5 +1,11 @@
exports.default = async function(configuration) { exports.default = async function(configuration) {
if (process.env.ELECTRON_BUILDER_SIGN) {
console.log('+++++++++++++++++++++++++++++++++++++++++++++++++++')
console.log(`ELECTRON_BUILDER_SIGN: ${process.env.ELECTRON_BUILDER_SIGN}`)
console.log(`Type: ${typeof process.env.ELECTRON_BUILDER_SIGN}`)
console.log('+++++++++++++++++++++++++++++++++++++++++++++++++++')
if (process.env.ELECTRON_BUILDER_SIGN === 1) {
require("child_process").execSync( require("child_process").execSync(
`azuresigntool sign ` + `azuresigntool sign ` +
`-kvu ${process.env.SIGNING_VAULT_URL} ` + `-kvu ${process.env.SIGNING_VAULT_URL} ` +