Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-25 12:15:18 +01:00
Code Issues Projects Releases Wiki Activity

[PM-4590] Cached Page Details of Formless Input Fields Breaks Autofill (#6726)

Browse Source
This commit is contained in:
Cesar Gonzalez 2023-11-07 07:37:30 -06:00 committed by GitHub
parent 1669f3593e
commit 5fa630aac2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@ -47,11 +47,7 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
return this.getFormattedPageDetails({}, []); return this.getFormattedPageDetails({}, []);
} }
if ( if (!this.domRecentlyMutated && this.autofillFieldElements.size) {
!this.domRecentlyMutated &&
this.autofillFormElements.size &&
this.autofillFieldElements.size
) {
return this.getFormattedPageDetails( return this.getFormattedPageDetails(
this.getFormattedAutofillFormsData(), this.getFormattedAutofillFormsData(),
this.getFormattedAutofillFieldsData() this.getFormattedAutofillFieldsData()
@ -66,7 +62,7 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
); );
this.sortAutofillFieldElementsMap(); this.sortAutofillFieldElementsMap();
if (!Object.values(autofillFormsData).length || !autofillFieldsData.length) { if (!autofillFieldsData.length) {
this.noFieldsFound = true; this.noFieldsFound = true;
} }