From 694f2c7da2af90e0e925b7d62f8e9e3303d6a445 Mon Sep 17 00:00:00 2001
From: Brandon Treston <btreston@bitwarden.com>
Date: Tue, 3 Dec 2024 12:55:42 -0500
Subject: [PATCH] add policy component form validation to policy edit component
 (#12150)

---
 .../organizations/policies/policy-edit.component.html     | 8 +++++++-
 .../organizations/policies/policy-edit.component.ts       | 7 +++++--
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.html b/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.html
index f656d488e0..671083a231 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.html
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.html
@@ -15,7 +15,13 @@
       </div>
     </ng-container>
     <ng-container bitDialogFooter>
-      <button bitButton buttonType="primary" [disabled]="saveDisabled" bitFormButton type="submit">
+      <button
+        bitButton
+        buttonType="primary"
+        [disabled]="saveDisabled$ | async"
+        bitFormButton
+        type="submit"
+      >
         {{ "save" | i18n }}
       </button>
       <button bitButton buttonType="secondary" bitDialogClose type="button">
diff --git a/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.ts b/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.ts
index 644ec1d514..6a869aff22 100644
--- a/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.ts
+++ b/apps/web/src/app/admin-console/organizations/policies/policy-edit.component.ts
@@ -8,6 +8,7 @@ import {
   ViewContainerRef,
 } from "@angular/core";
 import { FormBuilder } from "@angular/forms";
+import { Observable, map } from "rxjs";
 
 import { PolicyApiServiceAbstraction } from "@bitwarden/common/admin-console/abstractions/policy/policy-api.service.abstraction";
 import { PolicyType } from "@bitwarden/common/admin-console/enums";
@@ -42,7 +43,7 @@ export class PolicyEditComponent implements AfterViewInit {
   policyType = PolicyType;
   loading = true;
   enabled = false;
-  saveDisabled = false;
+  saveDisabled$: Observable<boolean>;
   defaultTypes: any[];
   policyComponent: BasePolicyComponent;
 
@@ -73,7 +74,9 @@ export class PolicyEditComponent implements AfterViewInit {
     this.policyComponent.policy = this.data.policy;
     this.policyComponent.policyResponse = this.policyResponse;
 
-    this.saveDisabled = !this.policyResponse.canToggleState;
+    this.saveDisabled$ = this.policyComponent.data.statusChanges.pipe(
+      map((status) => status !== "VALID" || !this.policyResponse.canToggleState),
+    );
 
     this.cdr.detectChanges();
   }