Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-10 13:09:37 +01:00
Code Issues Projects Releases Wiki Activity

hide empty ciphers from autofill

Browse Source
This commit is contained in:
Evan Bassler 2024-12-19 17:02:42 -06:00
parent 6eb30c98c4
commit 6d09fd936d
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
apps/browser/src/autofill/background/overlay.background.ts
View File

@ -66,6 +66,7 @@ import { InlineMenuFormFieldData } from "../services/abstractions/autofill-overl
import { AutofillService, PageDetail } from "../services/abstractions/autofill.service";
import { InlineMenuFieldQualificationService } from "../services/abstractions/inline-menu-field-qualifications.service";
import {
areKeyValuesNull,
generateDomainMatchPatterns,
generateRandomChars,
isInvalidResponseStatusCode,
@ -556,6 +557,28 @@ export class OverlayBackground implements OverlayBackgroundInterface {
for (let cipherIndex = 0; cipherIndex < inlineMenuCiphersArray.length; cipherIndex++) {
const [inlineMenuCipherId, cipher] = inlineMenuCiphersArray[cipherIndex];
switch (cipher.type) {
case CipherType.Card:
if (areKeyValuesNull(cipher.card)) {
continue;
}
break;
case CipherType.Identity:
if (areKeyValuesNull(cipher.identity)) {
continue;
}
break;
case CipherType.Login:
if (
areKeyValuesNull(cipher.login, ["username", "password", "totp", "fido2Credentials"])
) {
continue;
}
break;
}
if (!this.focusedFieldMatchesFillType(cipher.type)) {
continue;
}

17
apps/browser/src/autofill/utils/index.ts
View File

@ -544,3 +544,20 @@ export const specialCharacterToKeyMap: Record<string, string> = {
"?": "questionCharacterDescriptor",
"/": "forwardSlashCharacterDescriptor",
};
/**
* Checks if all the values corresponding to the specified keys in an object are null.
* If no keys are specified, checks all keys in the object.
*
* @param obj - The object to check.
* @param keys - An optional array of keys to check in the object. Defaults to all keys.
* @returns Returns true if all values for the specified keys (or all keys if none are provided) are null; otherwise, false.
*/
export function areKeyValuesNull<T extends Record<string, any>>(
obj: T,
keys?: Array<keyof T>,
): boolean {
const keysToCheck = keys && keys.length > 0 ? keys : (Object.keys(obj) as Array<keyof T>);
return keysToCheck.every((key) => obj[key] == null);
}