Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-10 00:21:27 +01:00
Code Issues Projects Releases Wiki Activity

[PM-5189] Refactoring implementation

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-06-11 09:33:28 -05:00
parent d43b5359c9
commit 6ec6310bb4
No known key found for this signature in database
GPG Key ID: 3381A5457F8CCECF
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts
View File

@ -37,8 +37,7 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
private readonly _extensionMessageHandlers: InlineMenuExtensionMessageHandlers = {
closeAutofillInlineMenu: ({ message }) => this.removeInlineMenu(message),
appendAutofillInlineMenuToDom: ({ message }) => this.appendInlineMenuElements(message),
toggleAutofillInlineMenuHidden: ({ message }) =>
this.toggleInlineMenuHidden(message.isInlineMenuHidden),
toggleAutofillInlineMenuHidden: ({ message }) => this.toggleInlineMenuHidden(message),
checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(),
checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(),
};
@ -66,11 +65,12 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
/**
* Sends a message that facilitates hiding the inline menu elements.
*
* @param isHidden - Indicates if the inline menu elements should be hidden.
* @param message - The message that contains the visibility state of the inline menu elements.
*/
private toggleInlineMenuHidden(isHidden: boolean) {
this.isButtonVisible = !!this.buttonElement && !isHidden;
this.isListVisible = !!this.listElement && !isHidden;
private toggleInlineMenuHidden(message: AutofillExtensionMessage) {
const { isInlineMenuHidden } = message;
this.isButtonVisible = !!this.buttonElement && !isInlineMenuHidden;
this.isListVisible = !!this.listElement && !isInlineMenuHidden;
}
/**
@ -419,6 +419,7 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte
return false;
}
destroy() {
this.documentElementMutationObserver?.disconnect();
this.removeInlineMenu();