From 755e3486eea828f4a1c9bdd9026046abee044317 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Wed, 3 Oct 2018 09:46:00 -0400 Subject: [PATCH] dont need change detector --- jslib | 2 +- src/popup/app.component.ts | 1 - src/services/browserPlatformUtils.service.ts | 3 ++- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/jslib b/jslib index 7ae640e5f8..6b3dc2344f 160000 --- a/jslib +++ b/jslib @@ -1 +1 @@ -Subproject commit 7ae640e5f8de3454fe8279aab2717abd6d12ca42 +Subproject commit 6b3dc2344f2db167cbc404d83fa4602a1ca93ef8 diff --git a/src/popup/app.component.ts b/src/popup/app.component.ts index f14102a0e4..d7fe78bea3 100644 --- a/src/popup/app.component.ts +++ b/src/popup/app.component.ts @@ -107,7 +107,6 @@ export class AppComponent implements OnInit { } else if (msg.command === 'showToast') { this.ngZone.run(async () => { await this.showToast(msg); - this.changeDetectorRef.detectChanges(); }); } else if (msg.command === 'analyticsEventTrack') { this.analytics.eventTrack.next({ diff --git a/src/services/browserPlatformUtils.service.ts b/src/services/browserPlatformUtils.service.ts index dad06be620..ad1832d820 100644 --- a/src/services/browserPlatformUtils.service.ts +++ b/src/services/browserPlatformUtils.service.ts @@ -178,7 +178,8 @@ export default class BrowserPlatformUtilsService implements PlatformUtilsService return true; } - showToast(type: 'error' | 'success' | 'warning' | 'info', title: string, text: string, options?: any): void { + showToast(type: 'error' | 'success' | 'warning' | 'info', title: string, text: string | string[], + options?: any): void { this.messagingService.send('showToast', { text: text, title: title,