Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-26 12:25:20 +01:00
Code Issues Projects Releases Wiki Activity

[PS-250] Prevent timeouts less than 1 minute (#802)

Browse Source 
* Modified shouldlock functionality to handle the immediately valut timeout

* Modified should lock functionality to handle the immediately valut timeout

* corrected spelling

* check to know when custom minutes in less than 1

* check for minimum allowed minutes

* revert vault timeout service

* lint fix

* check moved to validate method

* changed implementation

* suggestion fixes

* suggestion fixes

* fixed comments

* changed implementation

* changed implementation

* made method private
This commit is contained in:
Gbubemi Smith 2022-06-03 10:26:23 +01:00 committed by GitHub
parent f4066b4f58
commit 7b9826fb28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
angular/src/components/settings/vault-timeout-input.component.ts
View File

@ -18,7 +18,14 @@ export class VaultTimeoutInputComponent implements ControlValueAccessor, Validat
return this.form.get("vaultTimeout").value === VaultTimeoutInputComponent.CUSTOM_VALUE; return this.form.get("vaultTimeout").value === VaultTimeoutInputComponent.CUSTOM_VALUE;
} }
get exceedsMinimumTimout(): boolean {
return (
!this.showCustom || this.customTimeInMinutes() > VaultTimeoutInputComponent.MIN_CUSTOM_MINUTES
);
}
static CUSTOM_VALUE = -100; static CUSTOM_VALUE = -100;
static MIN_CUSTOM_MINUTES = 0;
form = this.formBuilder.group({ form = this.formBuilder.group({
vaultTimeout: [null], vaultTimeout: [null],
@ -132,10 +139,18 @@ export class VaultTimeoutInputComponent implements ControlValueAccessor, Validat
return { policyError: true }; return { policyError: true };
} }
if (!this.exceedsMinimumTimout) {
return { minTimeoutError: true };
}
return null; return null;
} }
registerOnValidatorChange(fn: () => void): void { registerOnValidatorChange(fn: () => void): void {
this.validatorChange = fn; this.validatorChange = fn;
} }
private customTimeInMinutes() {
return this.form.get("custom.hours")?.value * 60 + this.form.get("custom.minutes")?.value;
}
} }