Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-19 01:51:27 +01:00
Code Issues Projects Releases Wiki Activity

PM-8113 - TODO: test all comp services

Browse Source
This commit is contained in:
Jared Snider 2025-01-24 16:37:35 -05:00
parent e6e3cf623a
commit 7d90d1aa5e
No known key found for this signature in database
GPG Key ID: A149DDD612516286
6 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/browser/src/auth/services/extension-two-factor-auth-component.service.ts
View File

@ -13,6 +13,7 @@ import {
closeTwoFactorAuthWebAuthnPopout, closeTwoFactorAuthWebAuthnPopout,
} from "../popup/utils/auth-popout-window"; } from "../popup/utils/auth-popout-window";
// TODO: add tests
export class ExtensionTwoFactorAuthComponentService export class ExtensionTwoFactorAuthComponentService
extends DefaultTwoFactorAuthComponentService extends DefaultTwoFactorAuthComponentService
implements TwoFactorAuthComponentService implements TwoFactorAuthComponentService

1
apps/browser/src/auth/services/extension-two-factor-auth-duo-component.service.ts
View File

@ -12,6 +12,7 @@ interface Message {
code: string; code: string;
state: string; state: string;
} }
// TODO: add tests
export class ExtensionTwoFactorAuthDuoComponentService implements TwoFactorAuthDuoComponentService { export class ExtensionTwoFactorAuthDuoComponentService implements TwoFactorAuthDuoComponentService {
constructor( constructor(

2
apps/browser/src/auth/services/extension-two-factor-auth-email-component.service.ts
View File

@ -8,6 +8,8 @@ import { openTwoFactorAuthEmailPopout } from "../../auth/popup/utils/auth-popout
import BrowserPopupUtils from "../../platform/popup/browser-popup-utils"; import BrowserPopupUtils from "../../platform/popup/browser-popup-utils";
// TODO: popup state persistence should eventually remove the need for this service // TODO: popup state persistence should eventually remove the need for this service
// TODO: add tests
export class ExtensionTwoFactorAuthEmailComponentService export class ExtensionTwoFactorAuthEmailComponentService
extends DefaultTwoFactorAuthEmailComponentService extends DefaultTwoFactorAuthEmailComponentService
implements TwoFactorAuthEmailComponentService implements TwoFactorAuthEmailComponentService

1
apps/browser/src/auth/services/extension-two-factor-auth-webauthn-component.service.ts
View File

@ -4,6 +4,7 @@ import {
} from "@bitwarden/auth/angular"; } from "@bitwarden/auth/angular";
import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
// TODO: add tests
export class ExtensionTwoFactorAuthWebAuthnComponentService export class ExtensionTwoFactorAuthWebAuthnComponentService
extends DefaultTwoFactorAuthWebAuthnComponentService extends DefaultTwoFactorAuthWebAuthnComponentService
implements TwoFactorAuthWebAuthnComponentService implements TwoFactorAuthWebAuthnComponentService

1
apps/desktop/src/auth/services/desktop-two-factor-auth-duo-component.service.ts
View File

@ -11,6 +11,7 @@ import { CommandDefinition, MessageListener } from "@bitwarden/common/platform/m
// We should explore consolidating the messaging approach across clients - i.e., we // We should explore consolidating the messaging approach across clients - i.e., we
// should use the same command definition across all clients. We use duoResult on extension for no real // should use the same command definition across all clients. We use duoResult on extension for no real
// benefit. // benefit.
// TODO: add tests
export const DUO_2FA_RESULT_COMMAND = new CommandDefinition<{ code: string; state: string }>( export const DUO_2FA_RESULT_COMMAND = new CommandDefinition<{ code: string; state: string }>(
"duoCallback", "duoCallback",
); );

1
apps/web/src/app/auth/core/services/two-factor-auth/web-two-factor-auth-duo-component.service.ts
View File

@ -3,6 +3,7 @@ import { fromEvent, map, Observable, share } from "rxjs";
import { TwoFactorAuthDuoComponentService, Duo2faResult } from "@bitwarden/auth/angular"; import { TwoFactorAuthDuoComponentService, Duo2faResult } from "@bitwarden/auth/angular";
import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
// TODO: add tests
export class WebTwoFactorAuthDuoComponentService implements TwoFactorAuthDuoComponentService { export class WebTwoFactorAuthDuoComponentService implements TwoFactorAuthDuoComponentService {
private duo2faResult$: Observable<Duo2faResult>; private duo2faResult$: Observable<Duo2faResult>;