Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-02 03:41:09 +01:00
Code Issues Projects Releases Wiki Activity

fix(ui): [PM-18719] fix endless spinner on read key button

Browse Source 
This resolves an issue where the WebAuthn setup component's read key button would show a loading spinner indefinitely. The fix addresses problems with Signal handling for the bitButton component's disabled/loading states.

JIRA: PM-18719
This commit is contained in:
Alec Rippberger 2025-02-28 11:39:50 -06:00 committed by GitHub
parent 24410cd672
commit 7da329da45
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
apps/web/src/app/auth/settings/two-factor/two-factor-setup-webauthn.component.html
View File

@ -63,16 +63,16 @@
type="button" type="button"
[bitAction]="readKey" [bitAction]="readKey"
buttonType="secondary" buttonType="secondary"
[disabled]="$any(readKeyBtn).loading || webAuthnListening || !keyIdAvailable" [disabled]="$any(readKeyBtn).loading() || webAuthnListening || !keyIdAvailable"
class="tw-mr-2" class="tw-mr-2"
#readKeyBtn #readKeyBtn
> >
{{ "readKey" | i18n }} {{ "readKey" | i18n }}
</button> </button>
<ng-container *ngIf="$any(readKeyBtn).loading"> <ng-container *ngIf="$any(readKeyBtn).loading()">
<i class="bwi bwi-spinner bwi-spin tw-text-muted" aria-hidden="true"></i> <i class="bwi bwi-spinner bwi-spin tw-text-muted" aria-hidden="true"></i>
</ng-container> </ng-container>
<ng-container *ngIf="!$any(readKeyBtn).loading"> <ng-container *ngIf="!$any(readKeyBtn).loading()">
<ng-container *ngIf="webAuthnListening"> <ng-container *ngIf="webAuthnListening">
<i class="bwi bwi-spinner bwi-spin tw-text-muted" aria-hidden="true"></i> <i class="bwi bwi-spinner bwi-spin tw-text-muted" aria-hidden="true"></i>
{{ "twoFactorU2fWaiting" | i18n }}... {{ "twoFactorU2fWaiting" | i18n }}...