Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-14 10:26:19 +01:00
Code Issues Projects Releases Wiki Activity

[PM-13876] Generator PR review follow up (#11885)

Browse Source 
* Remove unused regex

* Remove viewChild reference from markup

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Daniel James Smith 2024-11-07 15:03:54 +01:00 committed by GitHub
parent f5e6fc8ed5
commit 872f36752f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libs/tools/generator/components/src/catchall-settings.component.ts
View File

@ -12,11 +12,6 @@ import {
import { completeOnAccountSwitch } from "./util"; import { completeOnAccountSwitch } from "./util";
/** Splits an email into a username, subaddress, and domain named group.
* Subaddress is optional.
*/
export const DOMAIN_PARSER = new RegExp("[^@]+@(?<domain>.+)");
/** Options group for catchall emails */ /** Options group for catchall emails */
@Component({ @Component({
selector: "tools-catchall-settings", selector: "tools-catchall-settings",

6
libs/tools/generator/components/src/credential-generator.component.html
View File

@ -39,14 +39,12 @@
</div> </div>
</bit-card> </bit-card>
<tools-password-settings <tools-password-settings
#passwordSettings
class="tw-mt-6" class="tw-mt-6"
*ngIf="(showAlgorithm$ | async)?.id === 'password'" *ngIf="(showAlgorithm$ | async)?.id === 'password'"
[userId]="userId$ | async" [userId]="userId$ | async"
(onUpdated)="generate('password settings')" (onUpdated)="generate('password settings')"
/> />
<tools-passphrase-settings <tools-passphrase-settings
#passphraseSettings
class="tw-mt-6" class="tw-mt-6"
*ngIf="(showAlgorithm$ | async)?.id === 'passphrase'" *ngIf="(showAlgorithm$ | async)?.id === 'passphrase'"
[userId]="userId$ | async" [userId]="userId$ | async"
@ -84,25 +82,21 @@
</bit-form-field> </bit-form-field>
</form> </form>
<tools-catchall-settings <tools-catchall-settings
#catchallSettings
*ngIf="(showAlgorithm$ | async)?.id === 'catchall'" *ngIf="(showAlgorithm$ | async)?.id === 'catchall'"
[userId]="userId$ | async" [userId]="userId$ | async"
(onUpdated)="generate('catchall settings')" (onUpdated)="generate('catchall settings')"
/> />
<tools-forwarder-settings <tools-forwarder-settings
#forwarderSettings
*ngIf="!!(forwarderId$ | async)" *ngIf="!!(forwarderId$ | async)"
[forwarder]="forwarderId$ | async" [forwarder]="forwarderId$ | async"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
/> />
<tools-subaddress-settings <tools-subaddress-settings
#subaddressSettings
*ngIf="(showAlgorithm$ | async)?.id === 'subaddress'" *ngIf="(showAlgorithm$ | async)?.id === 'subaddress'"
[userId]="userId$ | async" [userId]="userId$ | async"
(onUpdated)="generate('subaddress settings')" (onUpdated)="generate('subaddress settings')"
/> />
<tools-username-settings <tools-username-settings
#usernameSettings
*ngIf="(showAlgorithm$ | async)?.id === 'username'" *ngIf="(showAlgorithm$ | async)?.id === 'username'"
[userId]="userId$ | async" [userId]="userId$ | async"
(onUpdated)="generate('username settings')" (onUpdated)="generate('username settings')"

2
libs/tools/generator/components/src/password-generator.component.html
View File

@ -37,7 +37,6 @@
</div> </div>
</bit-card> </bit-card>
<tools-password-settings <tools-password-settings
#passwordSettings
class="tw-mt-6" class="tw-mt-6"
*ngIf="(algorithm$ | async)?.id === 'password'" *ngIf="(algorithm$ | async)?.id === 'password'"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
@ -45,7 +44,6 @@
(onUpdated)="generate('password settings')" (onUpdated)="generate('password settings')"
/> />
<tools-passphrase-settings <tools-passphrase-settings
#passphraseSettings
class="tw-mt-6" class="tw-mt-6"
*ngIf="(algorithm$ | async)?.id === 'passphrase'" *ngIf="(algorithm$ | async)?.id === 'passphrase'"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"

4
libs/tools/generator/components/src/username-generator.component.html
View File

@ -59,25 +59,21 @@
</bit-form-field> </bit-form-field>
</form> </form>
<tools-catchall-settings <tools-catchall-settings
#catchallSettings
*ngIf="(algorithm$ | async)?.id === 'catchall'" *ngIf="(algorithm$ | async)?.id === 'catchall'"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
(onUpdated)="generate('catchall settings')" (onUpdated)="generate('catchall settings')"
/> />
<tools-forwarder-settings <tools-forwarder-settings
#forwarderSettings
*ngIf="!!(forwarderId$ | async)" *ngIf="!!(forwarderId$ | async)"
[forwarder]="forwarderId$ | async" [forwarder]="forwarderId$ | async"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
/> />
<tools-subaddress-settings <tools-subaddress-settings
#subaddressSettings
*ngIf="(algorithm$ | async)?.id === 'subaddress'" *ngIf="(algorithm$ | async)?.id === 'subaddress'"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
(onUpdated)="generate('subaddress settings')" (onUpdated)="generate('subaddress settings')"
/> />
<tools-username-settings <tools-username-settings
#usernameSettings
*ngIf="(algorithm$ | async)?.id === 'username'" *ngIf="(algorithm$ | async)?.id === 'username'"
[userId]="this.userId$ | async" [userId]="this.userId$ | async"
(onUpdated)="generate('username settings')" (onUpdated)="generate('username settings')"