From 87cccdb52a8c84d531c2375cdd18d183725eeb9e Mon Sep 17 00:00:00 2001 From: Cesar Gonzalez Date: Tue, 11 Jun 2024 09:25:16 -0500 Subject: [PATCH] [PM-5189] Fixing some typos --- .../autofill/background/overlay.background.spec.ts | 4 ++-- .../src/autofill/background/overlay.background.ts | 13 ++++++------- .../autofill-inline-menu-content.service.ts | 4 ++-- .../content/autofill-inline-menu-content.service.ts | 4 ++-- 4 files changed, 12 insertions(+), 13 deletions(-) diff --git a/apps/browser/src/autofill/background/overlay.background.spec.ts b/apps/browser/src/autofill/background/overlay.background.spec.ts index 44ef68e859..56a6c82a5c 100644 --- a/apps/browser/src/autofill/background/overlay.background.spec.ts +++ b/apps/browser/src/autofill/background/overlay.background.spec.ts @@ -1188,7 +1188,7 @@ describe("OverlayBackground", () => { expect(tabsSendMessageSpy).toHaveBeenCalledWith( sender.tab, - { command: "checkIsAutofillInlineMenuButtonVisible" }, + { command: "checkIsInlineMenuButtonVisible" }, { frameId: 0 }, ); }); @@ -1202,7 +1202,7 @@ describe("OverlayBackground", () => { expect(tabsSendMessageSpy).toHaveBeenCalledWith( sender.tab, - { command: "checkIsAutofillInlineMenuListVisible" }, + { command: "checkIsInlineMenuListVisible" }, { frameId: 0 }, ); }); diff --git a/apps/browser/src/autofill/background/overlay.background.ts b/apps/browser/src/autofill/background/overlay.background.ts index be45242838..2a66873485 100644 --- a/apps/browser/src/autofill/background/overlay.background.ts +++ b/apps/browser/src/autofill/background/overlay.background.ts @@ -85,9 +85,8 @@ export class OverlayBackground implements OverlayBackgroundInterface { updateAutofillInlineMenuHidden: ({ message, sender }) => this.updateInlineMenuHidden(message, sender), checkIsAutofillInlineMenuButtonVisible: ({ sender }) => - this.checkIsAutofillInlineMenuButtonVisible(sender), - checkIsAutofillInlineMenuListVisible: ({ sender }) => - this.checkIsAutofillInlineMenuListVisible(sender), + this.checkIsInlineMenuButtonVisible(sender), + checkIsAutofillInlineMenuListVisible: ({ sender }) => this.checkIsInlineMenuListVisible(sender), checkShouldRepositionInlineMenu: ({ sender }) => this.checkShouldRepositionInlineMenu(sender), getCurrentTabFrameId: ({ sender }) => this.getSenderFrameId(sender), updateSubFrameData: ({ message, sender }) => this.updateSubFrameData(message, sender), @@ -984,12 +983,12 @@ export class OverlayBackground implements OverlayBackgroundInterface { * * @param sender - The sender of the message */ - private async checkIsAutofillInlineMenuButtonVisible( + private async checkIsInlineMenuButtonVisible( sender: chrome.runtime.MessageSender, ): Promise { return await BrowserApi.tabSendMessage( sender.tab, - { command: "checkIsAutofillInlineMenuButtonVisible" }, + { command: "checkIsInlineMenuButtonVisible" }, { frameId: 0 }, ); } @@ -999,12 +998,12 @@ export class OverlayBackground implements OverlayBackgroundInterface { * * @param sender - The sender of the message */ - private async checkIsAutofillInlineMenuListVisible( + private async checkIsInlineMenuListVisible( sender: chrome.runtime.MessageSender, ): Promise { return await BrowserApi.tabSendMessage( sender.tab, - { command: "checkIsAutofillInlineMenuListVisible" }, + { command: "checkIsInlineMenuListVisible" }, { frameId: 0 }, ); } diff --git a/apps/browser/src/autofill/overlay/inline-menu/abstractions/autofill-inline-menu-content.service.ts b/apps/browser/src/autofill/overlay/inline-menu/abstractions/autofill-inline-menu-content.service.ts index d7421dce38..c4a9b74301 100644 --- a/apps/browser/src/autofill/overlay/inline-menu/abstractions/autofill-inline-menu-content.service.ts +++ b/apps/browser/src/autofill/overlay/inline-menu/abstractions/autofill-inline-menu-content.service.ts @@ -5,8 +5,8 @@ export type InlineMenuExtensionMessageHandlers = { closeInlineMenu: ({ message }: AutofillExtensionMessageParam) => void; appendInlineMenuElementsToDom: ({ message }: AutofillExtensionMessageParam) => Promise; toggleInlineMenuHidden: ({ message }: AutofillExtensionMessageParam) => void; - checkIsAutofillInlineMenuButtonVisible: () => boolean; - checkIsAutofillInlineMenuListVisible: () => boolean; + checkIsInlineMenuButtonVisible: () => boolean; + checkIsInlineMenuListVisible: () => boolean; }; export interface AutofillInlineMenuContentService { diff --git a/apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts b/apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts index 398fac8f33..e66035bf1b 100644 --- a/apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts +++ b/apps/browser/src/autofill/overlay/inline-menu/content/autofill-inline-menu-content.service.ts @@ -39,8 +39,8 @@ export class AutofillInlineMenuContentService implements AutofillInlineMenuConte appendInlineMenuElementsToDom: ({ message }) => this.appendInlineMenuElements(message), toggleInlineMenuHidden: ({ message }) => this.toggleInlineMenuHidden(message.isInlineMenuHidden), - checkIsAutofillInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(), - checkIsAutofillInlineMenuListVisible: () => this.isInlineMenuListVisible(), + checkIsInlineMenuButtonVisible: () => this.isInlineMenuButtonVisible(), + checkIsInlineMenuListVisible: () => this.isInlineMenuListVisible(), }; constructor() {