From 8c29cf7f33517fdbd51feda19daecbf4dc8434ac Mon Sep 17 00:00:00 2001 From: Thomas Rittson Date: Wed, 5 May 2021 13:57:50 +1000 Subject: [PATCH] Organize Options page and add headings --- src/_locales/en/messages.json | 2 +- src/popup/scss/box.scss | 9 + src/popup/settings/options.component.html | 277 ++++++++++++---------- src/popup/settings/options.component.ts | 3 + src/services/autofill.service.ts | 4 +- 5 files changed, 167 insertions(+), 128 deletions(-) diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json index 19b29592f5..3b83aae2be 100644 --- a/src/_locales/en/messages.json +++ b/src/_locales/en/messages.json @@ -902,7 +902,7 @@ "message": "Automatic TOTP Copy after Page Load" }, "enableAutoTotpCopyOnAutoFillDesc": { - "message": "If Auto-fill On Page Load is enabled, and your login has an authenticator key attached to it, the TOTP verification code is automatically copied to your clipboard after loading the web page." + "message": "If Auto-fill On Page Load is enabled, the TOTP verification code is automatically copied to your clipboard after loading the web page. This is overridden by Disable Automatic TOTP Copy." }, "experimentalFeature": { "message": "This is currently an experimental feature. Use at your own risk." diff --git a/src/popup/scss/box.scss b/src/popup/scss/box.scss index 11341c69f3..f53719af1e 100644 --- a/src/popup/scss/box.scss +++ b/src/popup/scss/box.scss @@ -164,6 +164,15 @@ flex-direction: column; } +.box-section-divider { + border-top: 1px solid #000000; + padding-top: 10px; + + @include themify($themes) { + border-color: themed('borderColor'); + } +} + .box-content-row { display: block; padding: 10px 15px; diff --git a/src/popup/settings/options.component.html b/src/popup/settings/options.component.html index 8d82dfc5ed..fd7563a12d 100644 --- a/src/popup/settings/options.component.html +++ b/src/popup/settings/options.component.html @@ -12,139 +12,166 @@
-
-
- - -
-
-
- {{'enableAutoFillOnPageLoadDesc' | i18n}} - {{'warning' | i18n}}: {{'experimentalFeature' | i18n}} +
+ General + +
-
-
-
- - + +
+
+
+ + +
+
{{'defaultUriMatchDetectionDesc' | i18n}}
-
- {{'enableAutoTotpCopyOnAutoFillDesc' | i18n}} +
+
+
+ + +
+
+
{{'clearClipboardDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'disableAutoTotpCopyDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'addLoginNotificationDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'disableChangedPasswordNotificationDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'disableContextMenuItemDesc' | i18n}}
+
+ +
+
+ Display + +
-
-
-
- - + +
+
+
+ + +
+
+
{{'dontShowCardsCurrentTabDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'dontShowIdentitiesCurrentTabDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'disableFaviconDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'disableBadgeCounterDesc' | i18n}}
+
+
+
+
+ + +
+
+
{{'themeDesc' | i18n}}
+
+ +
+
+ Autofill + + +
+
+ +
+
+
+ + +
+
+
+ {{'enableAutoFillOnPageLoadDesc' | i18n}} + {{'warning' | i18n}}: {{'experimentalFeature' | i18n}}
-
{{'defaultUriMatchDetectionDesc' | i18n}}
-
-
-
-
- - +
+
+
+ + +
+
+
+ {{'enableAutoTotpCopyOnAutoFillDesc' | i18n}}
-
{{'clearClipboardDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'disableAutoTotpCopyDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'dontShowCardsCurrentTabDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'dontShowIdentitiesCurrentTabDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'addLoginNotificationDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'disableChangedPasswordNotificationDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'disableContextMenuItemDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'disableFaviconDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'disableBadgeCounterDesc' | i18n}}
-
-
-
-
- - -
-
-
{{'themeDesc' | i18n}}
-
+ diff --git a/src/popup/settings/options.component.ts b/src/popup/settings/options.component.ts index abe528f15d..355e47a328 100644 --- a/src/popup/settings/options.component.ts +++ b/src/popup/settings/options.component.ts @@ -36,6 +36,9 @@ export class OptionsComponent implements OnInit { uriMatchOptions: any[]; clearClipboard: number; clearClipboardOptions: any[]; + showGeneral: boolean = true; + showAutofill: boolean = true; + showDisplay: boolean = true; constructor(private messagingService: MessagingService, private storageService: StorageService, private stateService: StateService, private totpService: TotpService, i18nService: I18nService) { diff --git a/src/services/autofill.service.ts b/src/services/autofill.service.ts index f61236b569..08f7b41a2a 100644 --- a/src/services/autofill.service.ts +++ b/src/services/autofill.service.ts @@ -258,10 +258,10 @@ export default class AutofillService implements AutofillServiceInterface { if (cipher.reprompt !== CipherRepromptType.None) { return; } - + const copyTotpOnAutoFill = await this.totpService.isAutoCopyOnAutoFillEnabled(); const shouldCopyTotp = fromCommand || copyTotpOnAutoFill; - + const totpCode = await this.doAutoFill({ cipher: cipher, pageDetails: pageDetails,