Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-06 23:51:28 +01:00
Code Issues Projects Releases Wiki Activity

[PM-16807] Update text and behavior for show id/card vault settings (#12808)

Browse Source 
* update text and behavior for show id/card vault settings

* add new crowdin entry

* update crowdin entries

* revert default

---------

Co-authored-by: Evan Bassler <evanbassler@Mac.attlocal.net>
This commit is contained in:
Evan Bassler 2025-01-23 13:59:39 -06:00 committed by GitHub
parent f9f30f8ec4
commit 8a2aa1eac2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/browser/src/_locales/en/messages.json
View File

@ -992,8 +992,8 @@
"addLoginNotificationDescAlt": {
"message": "Ask to add an item if one isn't found in your vault. Applies to all logged in accounts."
},
"showCardsInVaultView": {
"message": "Show cards as Autofill suggestions on Vault view"
"showCardsInVaultViewV2": {
"message": "Always show cards as Autofill suggestions on Vault view"
},
"showCardsCurrentTab": {
"message": "Show cards on Tab page"
@ -1001,8 +1001,8 @@
"showCardsCurrentTabDesc": {
"message": "List card items on the Tab page for easy autofill."
},
"showIdentitiesInVaultView": {
"message": "Show identities as Autofill suggestions on Vault view"
"showIdentitiesInVaultViewV2": {
"message": "Always show identities as Autofill suggestions on Vault view"
},
"showIdentitiesCurrentTab": {
"message": "Show identities on Tab page"

4
apps/browser/src/autofill/popup/settings/autofill.component.html
View File

@ -118,7 +118,7 @@
(change)="updateShowCardsCurrentTab()"
[(ngModel)]="showCardsCurrentTab"
/>
<bit-label for="showCardsSuggestions">{{ "showCardsInVaultView" | i18n }}</bit-label>
<bit-label for="showCardsSuggestions">{{ "showCardsInVaultViewV2" | i18n }}</bit-label>
</bit-form-control>
<bit-form-control>
<input
@ -129,7 +129,7 @@
[(ngModel)]="showIdentitiesCurrentTab"
/>
<bit-label for="showIdentitiesSuggestions" class="tw-whitespace-normal">
{{ "showIdentitiesInVaultView" | i18n }}
{{ "showIdentitiesInVaultViewV2" | i18n }}
</bit-label>
</bit-form-control>
<bit-form-control disableMargin>

4
apps/browser/src/vault/popup/services/vault-popup-items.service.ts
View File

@ -71,9 +71,9 @@ export class VaultPopupItemsService {
this.vaultPopupAutofillService.nonLoginCipherTypesOnPage$,
]).pipe(
map(([showCardsSettingEnabled, showIdentitiesSettingEnabled, nonLoginCipherTypesOnPage]) => {
const showCards = showCardsSettingEnabled && nonLoginCipherTypesOnPage[CipherType.Card];
const showCards = showCardsSettingEnabled || nonLoginCipherTypesOnPage[CipherType.Card];
const showIdentities =
showIdentitiesSettingEnabled && nonLoginCipherTypesOnPage[CipherType.Identity];
showIdentitiesSettingEnabled || nonLoginCipherTypesOnPage[CipherType.Identity];
return [
...(showCards ? [CipherType.Card] : []),