From 8bb080cf93312de649500faa0b8c5bf035924a97 Mon Sep 17 00:00:00 2001 From: Tom <144813356+ttalty@users.noreply.github.com> Date: Wed, 8 Jan 2025 10:09:05 -0500 Subject: [PATCH] Removing testing tabs and the learn more link (#12481) --- apps/web/config/development.json | 4 +++- .../tools/access-intelligence/risk-insights.component.html | 7 +++---- .../tools/access-intelligence/risk-insights.component.ts | 4 ++++ libs/common/src/platform/misc/flags.ts | 1 + 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/apps/web/config/development.json b/apps/web/config/development.json index f0a15f4f4d..52a0fb0fdf 100644 --- a/apps/web/config/development.json +++ b/apps/web/config/development.json @@ -20,5 +20,7 @@ } ], "flags": {}, - "devFlags": {} + "devFlags": { + "showRiskInsightsDebug": false + } } diff --git a/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.html b/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.html index e0618c525a..7fe320ede6 100644 --- a/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.html +++ b/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.html @@ -3,7 +3,6 @@

{{ "riskInsights" | i18n }}

{{ "reviewAtRiskPasswords" | i18n }} -  {{ "learnMore" | i18n }}
- + - + - + diff --git a/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.ts b/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.ts index 1a90e18f0d..75601994c7 100644 --- a/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.ts +++ b/bitwarden_license/bit-web/src/app/tools/access-intelligence/risk-insights.component.ts @@ -10,6 +10,7 @@ import { RiskInsightsDataService } from "@bitwarden/bit-common/tools/reports/ris import { ApplicationHealthReportDetail } from "@bitwarden/bit-common/tools/reports/risk-insights/models/password-health"; import { FeatureFlag } from "@bitwarden/common/enums/feature-flag.enum"; import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service"; +import { devFlagEnabled } from "@bitwarden/common/platform/misc/flags"; import { AsyncActionsModule, ButtonModule, TabsModule } from "@bitwarden/components"; import { HeaderModule } from "@bitwarden/web-vault/app/layouts/header/header.module"; @@ -50,6 +51,7 @@ export class RiskInsightsComponent implements OnInit { dataLastUpdated: Date = new Date(); isCriticalAppsFeatureEnabled: boolean = false; + showDebugTabs: boolean = false; appsCount: number = 0; criticalAppsCount: number = 0; @@ -78,6 +80,8 @@ export class RiskInsightsComponent implements OnInit { FeatureFlag.CriticalApps, ); + this.showDebugTabs = devFlagEnabled("showRiskInsightsDebug"); + this.route.paramMap .pipe( takeUntilDestroyed(this.destroyRef), diff --git a/libs/common/src/platform/misc/flags.ts b/libs/common/src/platform/misc/flags.ts index b52879d88f..8ed19ce57f 100644 --- a/libs/common/src/platform/misc/flags.ts +++ b/libs/common/src/platform/misc/flags.ts @@ -13,6 +13,7 @@ export type SharedDevFlags = { noopNotifications: boolean; skipWelcomeOnInstall: boolean; configRetrievalIntervalMs: number; + showRiskInsightsDebug: boolean; }; function getFlags(envFlags: string | T): T {