Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-10 00:21:27 +01:00
Code Issues Projects Releases Wiki Activity

Ps 575 pop out (#2705)

Browse Source 
* Disable the ability to open infinite popouts in the browser

* fixing lint error

* Adding padding

* Updating code to use ngIf instead of show for the app-pop-out
This commit is contained in:
CarleyDiaz-Bitwarden 2022-06-01 11:40:32 -04:00 committed by GitHub
parent 11f04d0c1e
commit 8de7f522c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/browser/src/popup/components/pop-out.component.ts
View File

@ -18,7 +18,10 @@ export class PopOutComponent implements OnInit {
ngOnInit() {
if (this.show) {
if (this.popupUtilsService.inSidebar(window) && this.platformUtilsService.isFirefox()) {
if (
(this.popupUtilsService.inSidebar(window) && this.platformUtilsService.isFirefox()) ||
this.popupUtilsService.inPopout(window)
) {
this.show = false;
}
}

1
apps/browser/src/popup/scss/base.scss
View File

@ -215,6 +215,7 @@ header {
app-pop-out {
display: flex;
padding-right: 0.5em;
}
.title {

2
apps/browser/src/popup/vault/current-tab.component.html
View File

@ -1,7 +1,7 @@
<header>
<h1 class="sr-only">{{ "currentTab" | i18n }}</h1>
<div class="left">
<app-pop-out [show]="!inSidebar"></app-pop-out>
<app-pop-out *ngIf="!inSidebar"></app-pop-out>
<button
type="button"
appBlurClick