Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-23 16:38:45 +01:00
Code Issues Projects Releases Wiki Activity

[PM-16116] Add comment about mv2 routing loop (#12447)

Browse Source 
* Add comment about mv2 routing loop

* Add more details to comment
This commit is contained in:
Bernd Schoolmann 2024-12-18 05:33:14 -08:00 committed by GitHub
parent 5a582dfc6f
commit 903b5c8d93
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/popup/app-routing.module.ts
View File

@ -661,6 +661,10 @@ const routes: Routes = [
* This ensures that in a passkey flow the `/fido2?<queryParams>` URL does not get * This ensures that in a passkey flow the `/fido2?<queryParams>` URL does not get
* overwritten in the `BrowserRouterService` by the `/lockV2` route. This way, after * overwritten in the `BrowserRouterService` by the `/lockV2` route. This way, after
* unlocking, the user can be redirected back to the `/fido2?<queryParams>` URL. * unlocking, the user can be redirected back to the `/fido2?<queryParams>` URL.
*
* Also, this prevents a routing loop when using biometrics to unlock the vault in MV2 (Firefox),
* locking up the browser (https://bitwarden.atlassian.net/browse/PM-16116). This involves the
* `popup-router-cache.service` pushing the `lockV2` route to the history.
*/ */
doNotSaveUrl: true, doNotSaveUrl: true,
} satisfies ExtensionAnonLayoutWrapperData & RouteDataProperties, } satisfies ExtensionAnonLayoutWrapperData & RouteDataProperties,