Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-22 16:29:09 +01:00
Code Issues Projects Releases Wiki Activity

PM-5304 - Sync Service - setForceSetPasswordReasonIfNeeded(...) - Add bandaid to early return if state gets corrupted with undefined acctDecryptionOpts so that the sync won't error and prevent users from accessing their data added on another device. (#7265)

Browse Source
This commit is contained in:
Jared Snider 2023-12-19 17:04:25 -05:00 committed by GitHub
parent c16d0b29fa
commit 9544da28c7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libs/common/src/vault/services/sync/sync.service.ts
View File

@ -353,6 +353,18 @@ export class SyncService implements SyncServiceAbstraction {
const acctDecryptionOpts: AccountDecryptionOptions = const acctDecryptionOpts: AccountDecryptionOptions =
await this.stateService.getAccountDecryptionOptions(); await this.stateService.getAccountDecryptionOptions();
// Account decryption options should never be null or undefined b/c it is always initialized
// during the processing of the ID token response, but there might be a state issue
// where it is being overwritten with undefined affecting browser extension + FireFox users.
// TODO: Consider removing this once we figure out the root cause of the state issue or after the state provider refactor.
if (acctDecryptionOpts === null || acctDecryptionOpts === undefined) {
this.logService.error("Sync: Account decryption options are null or undefined.");
// Early return as a bandaid to allow the rest of the sync to continue so users can access
// their data that they might have added from another device.
// Otherwise, trying to access properties on undefined below will throw an error.
return;
}
// Even though TDE users should only be in a single org (per single org policy), check // Even though TDE users should only be in a single org (per single org policy), check
// through all orgs for the manageResetPassword permission. If they have it in any org, // through all orgs for the manageResetPassword permission. If they have it in any org,
// they should be forced to set a password. // they should be forced to set a password.