From 957ed50c820476be752d6c159ff7f308dd05cb31 Mon Sep 17 00:00:00 2001
From: Andreas Coroiu <acoroiu@bitwarden.com>
Date: Wed, 15 Feb 2023 09:01:09 +0100
Subject: [PATCH] [EC-1074] fix: block interaction during async action (#4732)

The user is able to interact with vault-items while actions like delete are happening. This commit is a temporary fix to disable all interaction surfaces during those async actions.
---
 .../vault-items.component.html                | 23 +++++++++++++++----
 .../individual-vault/vault-items.component.ts |  7 ++++++
 .../vault/org-vault/vault-items.component.ts  |  7 ++++++
 3 files changed, 32 insertions(+), 5 deletions(-)

diff --git a/apps/web/src/vault/individual-vault/vault-items.component.html b/apps/web/src/vault/individual-vault/vault-items.component.html
index 1da0ca1aaa..1292c95700 100644
--- a/apps/web/src/vault/individual-vault/vault-items.component.html
+++ b/apps/web/src/vault/individual-vault/vault-items.component.html
@@ -16,6 +16,7 @@
             type="checkbox"
             bitCheckbox
             id="checkAll"
+            [disabled]="isProcessingAction"
             (change)="checkAll($any($event.target).checked)"
             [(ngModel)]="isAllChecked"
           />
@@ -33,6 +34,7 @@
         <th bitCell class="tw-min-w-fit tw-text-right">
           <button
             [bitMenuTriggerFor]="headerMenu"
+            [disabled]="isProcessingAction"
             bitIconButton="bwi-ellipsis-v"
             size="small"
             type="button"
@@ -77,8 +79,8 @@
       <tr
         bitRow
         *ngFor="let col of filteredCollections"
-        (click)="navigateCollection(col)"
-        class="tw-cursor-pointer"
+        [class.tw-cursor-pointer]="!isProcessingAction"
+        (click)="!isProcessingAction && navigateCollection(col)"
         alignContent="middle"
       >
         <td bitCell (click)="checkRow(col)" appStopProp>
@@ -87,6 +89,7 @@
             class="tw-cursor-pointer"
             type="checkbox"
             bitCheckbox
+            [disabled]="isProcessingAction"
             [(ngModel)]="$any(col).checked"
             appStopProp
           />
@@ -102,6 +105,7 @@
             class="tw-text-start"
             linkType="secondary"
             (click)="navigateCollection(col)"
+            [disabled]="isProcessingAction"
           >
             {{ col.node.name }}
           </button>
@@ -128,6 +132,7 @@
           <button
             *ngIf="canEditCollection(col.node) || canDeleteCollection(col.node)"
             [bitMenuTriggerFor]="collectionOptions"
+            [disabled]="isProcessingAction"
             size="small"
             bitIconButton="bwi-ellipsis-v"
             type="button"
@@ -167,12 +172,18 @@
       <tr
         bitRow
         *ngFor="let c of filteredCiphers"
-        class="tw-cursor-pointer"
-        (click)="selectCipher(c)"
+        [class.tw-cursor-pointer]="!isProcessingAction"
+        (click)="!isProcessingAction && selectCipher(c)"
         alignContent="middle"
       >
         <td bitCell (click)="checkRow(c)" appStopProp>
-          <input type="checkbox" bitCheckbox [(ngModel)]="$any(c).checked" appStopProp />
+          <input
+            type="checkbox"
+            bitCheckbox
+            [disabled]="isProcessingAction"
+            [(ngModel)]="$any(c).checked"
+            appStopProp
+          />
         </td>
         <td bitCell>
           <app-vault-icon [cipher]="c"></app-vault-icon>
@@ -185,6 +196,7 @@
             [queryParams]="{ itemId: c.id }"
             queryParamsHandling="merge"
             title="{{ 'editItem' | i18n }}"
+            [disabled]="isProcessingAction"
           >
             {{ c.name }}
           </button>
@@ -230,6 +242,7 @@
         <td bitCell class="tw-text-right">
           <button
             [bitMenuTriggerFor]="cipherOptions"
+            [disabled]="isProcessingAction"
             size="small"
             bitIconButton="bwi-ellipsis-v"
             type="button"
diff --git a/apps/web/src/vault/individual-vault/vault-items.component.ts b/apps/web/src/vault/individual-vault/vault-items.component.ts
index ce2a2972d0..8af86d5b48 100644
--- a/apps/web/src/vault/individual-vault/vault-items.component.ts
+++ b/apps/web/src/vault/individual-vault/vault-items.component.ts
@@ -530,6 +530,13 @@ export class VaultItemsComponent extends BaseVaultItemsComponent implements OnDe
     return false; // Always return false for non org vault
   }
 
+  /**
+   * @deprecated Block interaction using long running modal dialog instead
+   */
+  protected get isProcessingAction() {
+    return this.actionPromise != null;
+  }
+
   protected updateSearchedCollections(collections: TreeNode<CollectionFilter>[]) {
     if (this.searchService.isSearchable(this.searchText)) {
       this.searchedCollections = this.searchPipe.transform(
diff --git a/apps/web/src/vault/org-vault/vault-items.component.ts b/apps/web/src/vault/org-vault/vault-items.component.ts
index 10e5473bf0..398d9d39b1 100644
--- a/apps/web/src/vault/org-vault/vault-items.component.ts
+++ b/apps/web/src/vault/org-vault/vault-items.component.ts
@@ -310,6 +310,13 @@ export class VaultItemsComponent extends BaseVaultItemsComponent implements OnDe
     }
   }
 
+  /**
+   * @deprecated Block interaction using long running modal dialog instead
+   */
+  protected get isProcessingAction() {
+    return this.actionPromise != null;
+  }
+
   protected deleteCipherWithServer(id: string, permanent: boolean) {
     if (!this.organization?.canEditAnyCollection) {
       return super.deleteCipherWithServer(id, this.deleted);