Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-30 17:47:44 +01:00
Code Issues Projects Releases Wiki Activity

[PM-4077] safeincloud multiple url fix (#6394)

Browse Source 
* safeincloud multiple url fix
* Ensure LoginView.uris is consistently populated
This commit is contained in:
bharat 2023-12-14 22:10:51 +05:30 committed by GitHub
parent 00fd45a678
commit 96d1c83385
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libs/common/src/vault/models/view/login.view.ts
View File

@ -17,7 +17,7 @@ export class LoginView extends ItemView {
passwordRevisionDate?: Date = null;
totp: string = null;
uris: LoginUriView[] = null;
uris: LoginUriView[] = [];
autofillOnPageLoad: boolean = null;
fido2Credentials: Fido2CredentialView[] = null;
@ -62,7 +62,7 @@ export class LoginView extends ItemView {
}
get hasUris(): boolean {
return this.uris != null && this.uris.length > 0;
return this.uris.length > 0;
}
get hasFido2Credentials(): boolean {
@ -84,7 +84,7 @@ export class LoginView extends ItemView {
static fromJSON(obj: Partial<Jsonify<LoginView>>): LoginView {
const passwordRevisionDate =
obj.passwordRevisionDate == null ? null : new Date(obj.passwordRevisionDate);
const uris = obj.uris?.map((uri: any) => LoginUriView.fromJSON(uri));
const uris = obj.uris.map((uri: any) => LoginUriView.fromJSON(uri));
const fido2Credentials = obj.fido2Credentials?.map((key) => Fido2CredentialView.fromJSON(key));
return Object.assign(new LoginView(), obj, {

2
libs/importer/src/importers/safeincloud-xml-importer.ts
View File

@ -81,7 +81,7 @@ export class SafeInCloudXmlImporter extends BaseImporter implements Importer {
} else if (fieldType === "notes") {
cipher.notes += text + "\n";
} else if (fieldType === "weblogin" || fieldType === "website") {
cipher.login.uris = this.makeUriArray(text);
cipher.login.uris.push(...this.makeUriArray(text));
} else {
this.processKvp(cipher, name, text);
}