1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-09-30 04:28:19 +02:00

[JslibModule] Refactor to use JslibModule (#1556)

This commit is contained in:
Thomas Rittson 2022-03-21 20:40:26 +10:00 committed by GitHub
parent e08726463e
commit 9bb004923c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 93 deletions

View File

@ -5,10 +5,9 @@ import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { RouterModule } from "@angular/router"; import { RouterModule } from "@angular/router";
import { InfiniteScrollModule } from "ngx-infinite-scroll"; import { InfiniteScrollModule } from "ngx-infinite-scroll";
import { BitwardenToastModule } from "jslib-angular/components/toastr.component"; import { JslibModule } from "jslib-angular/jslib.module";
import { OssRoutingModule } from "src/app/oss-routing.module"; import { OssRoutingModule } from "src/app/oss-routing.module";
import { OssModule } from "src/app/oss.module";
import { ServicesModule } from "src/app/services/services.module"; import { ServicesModule } from "src/app/services/services.module";
import { WildcardRoutingModule } from "src/app/wildcard-routing.module"; import { WildcardRoutingModule } from "src/app/wildcard-routing.module";
@ -20,28 +19,23 @@ import { MaximumVaultTimeoutPolicyComponent } from "./policies/maximum-vault-tim
@NgModule({ @NgModule({
imports: [ imports: [
OssModule,
BrowserAnimationsModule,
FormsModule,
ReactiveFormsModule,
ServicesModule,
BitwardenToastModule.forRoot({
maxOpened: 5,
autoDismiss: true,
closeButton: true,
}),
InfiniteScrollModule,
DragDropModule,
AppRoutingModule, AppRoutingModule,
OssRoutingModule, BrowserAnimationsModule,
DragDropModule,
FormsModule,
InfiniteScrollModule,
JslibModule,
OrganizationsModule, OrganizationsModule,
OssRoutingModule,
ReactiveFormsModule,
RouterModule, RouterModule,
ServicesModule,
WildcardRoutingModule, // Needs to be last to catch all non-existing routes WildcardRoutingModule, // Needs to be last to catch all non-existing routes
], ],
declarations: [ declarations: [
AppComponent, AppComponent,
MaximumVaultTimeoutPolicyComponent,
DisablePersonalVaultExportPolicyComponent, DisablePersonalVaultExportPolicyComponent,
MaximumVaultTimeoutPolicyComponent,
], ],
bootstrap: [AppComponent], bootstrap: [AppComponent],
}) })

View File

@ -2,7 +2,7 @@ import { CommonModule } from "@angular/common";
import { NgModule } from "@angular/core"; import { NgModule } from "@angular/core";
import { FormsModule, ReactiveFormsModule } from "@angular/forms"; import { FormsModule, ReactiveFormsModule } from "@angular/forms";
import { OssModule } from "src/app/oss.module"; import { JslibModule } from "jslib-angular/jslib.module";
import { InputCheckboxComponent } from "./components/input-checkbox.component"; import { InputCheckboxComponent } from "./components/input-checkbox.component";
import { InputTextReadOnlyComponent } from "./components/input-text-readonly.component"; import { InputTextReadOnlyComponent } from "./components/input-text-readonly.component";
@ -14,7 +14,13 @@ import { OrganizationsRoutingModule } from "./organizations-routing.module";
// Form components are for use in the SSO Configuration Form only and should not be exported for use elsewhere. // Form components are for use in the SSO Configuration Form only and should not be exported for use elsewhere.
// They will be deprecated by the Component Library. // They will be deprecated by the Component Library.
@NgModule({ @NgModule({
imports: [CommonModule, FormsModule, ReactiveFormsModule, OssModule, OrganizationsRoutingModule], imports: [
CommonModule,
FormsModule,
ReactiveFormsModule,
JslibModule,
OrganizationsRoutingModule,
],
declarations: [ declarations: [
InputCheckboxComponent, InputCheckboxComponent,
InputTextComponent, InputTextComponent,

View File

@ -2,6 +2,7 @@ import { CommonModule } from "@angular/common";
import { ComponentFactoryResolver, NgModule } from "@angular/core"; import { ComponentFactoryResolver, NgModule } from "@angular/core";
import { FormsModule } from "@angular/forms"; import { FormsModule } from "@angular/forms";
import { JslibModule } from "jslib-angular/jslib.module";
import { ModalService } from "jslib-angular/services/modal.service"; import { ModalService } from "jslib-angular/services/modal.service";
import { OssModule } from "src/app/oss.module"; import { OssModule } from "src/app/oss.module";
@ -27,7 +28,7 @@ import { SetupProviderComponent } from "./setup/setup-provider.component";
import { SetupComponent } from "./setup/setup.component"; import { SetupComponent } from "./setup/setup.component";
@NgModule({ @NgModule({
imports: [CommonModule, FormsModule, OssModule, ProvidersRoutingModule], imports: [CommonModule, FormsModule, OssModule, JslibModule, ProvidersRoutingModule],
declarations: [ declarations: [
AcceptProviderComponent, AcceptProviderComponent,
AccountComponent, AccountComponent,

2
jslib

@ -1 +1 @@
Subproject commit 3ec0f6977acc9374b7b379cbd59a2d7d1dbe8beb Subproject commit 9950fb42a15bad434a4b404419ff4a87af67a27b

View File

@ -4,8 +4,6 @@ import { FormsModule } from "@angular/forms";
import { BrowserAnimationsModule } from "@angular/platform-browser/animations"; import { BrowserAnimationsModule } from "@angular/platform-browser/animations";
import { InfiniteScrollModule } from "ngx-infinite-scroll"; import { InfiniteScrollModule } from "ngx-infinite-scroll";
import { BitwardenToastModule } from "jslib-angular/components/toastr.component";
import { AppComponent } from "./app.component"; import { AppComponent } from "./app.component";
import { OssRoutingModule } from "./oss-routing.module"; import { OssRoutingModule } from "./oss-routing.module";
import { OssModule } from "./oss.module"; import { OssModule } from "./oss.module";
@ -18,11 +16,6 @@ import { WildcardRoutingModule } from "./wildcard-routing.module";
BrowserAnimationsModule, BrowserAnimationsModule,
FormsModule, FormsModule,
ServicesModule, ServicesModule,
BitwardenToastModule.forRoot({
maxOpened: 5,
autoDismiss: true,
closeButton: true,
}),
InfiniteScrollModule, InfiniteScrollModule,
DragDropModule, DragDropModule,
OssRoutingModule, OssRoutingModule,

View File

@ -56,29 +56,7 @@ import { RouterModule } from "@angular/router";
import { InfiniteScrollModule } from "ngx-infinite-scroll"; import { InfiniteScrollModule } from "ngx-infinite-scroll";
import { ToastrModule } from "ngx-toastr"; import { ToastrModule } from "ngx-toastr";
import { AvatarComponent } from "jslib-angular/components/avatar.component"; import { JslibModule } from "jslib-angular/jslib.module";
import { CalloutComponent } from "jslib-angular/components/callout.component";
import { ExportScopeCalloutComponent } from "jslib-angular/components/export-scope-callout.component";
import { IconComponent } from "jslib-angular/components/icon.component";
import { VerifyMasterPasswordComponent } from "jslib-angular/components/verify-master-password.component";
import { A11yInvalidDirective } from "jslib-angular/directives/a11y-invalid.directive";
import { A11yTitleDirective } from "jslib-angular/directives/a11y-title.directive";
import { ApiActionDirective } from "jslib-angular/directives/api-action.directive";
import { AutofocusDirective } from "jslib-angular/directives/autofocus.directive";
import { BlurClickDirective } from "jslib-angular/directives/blur-click.directive";
import { BoxRowDirective } from "jslib-angular/directives/box-row.directive";
import { FallbackSrcDirective } from "jslib-angular/directives/fallback-src.directive";
import { InputStripSpacesDirective } from "jslib-angular/directives/input-strip-spaces.directive";
import { InputVerbatimDirective } from "jslib-angular/directives/input-verbatim.directive";
import { SelectCopyDirective } from "jslib-angular/directives/select-copy.directive";
import { StopClickDirective } from "jslib-angular/directives/stop-click.directive";
import { StopPropDirective } from "jslib-angular/directives/stop-prop.directive";
import { TrueFalseValueDirective } from "jslib-angular/directives/true-false-value.directive";
import { ColorPasswordPipe } from "jslib-angular/pipes/color-password.pipe";
import { I18nPipe } from "jslib-angular/pipes/i18n.pipe";
import { SearchCiphersPipe } from "jslib-angular/pipes/search-ciphers.pipe";
import { SearchPipe } from "jslib-angular/pipes/search.pipe";
import { UserNamePipe } from "jslib-angular/pipes/user-name.pipe";
import { AcceptEmergencyComponent } from "./accounts/accept-emergency.component"; import { AcceptEmergencyComponent } from "./accounts/accept-emergency.component";
import { AcceptOrganizationComponent } from "./accounts/accept-organization.component"; import { AcceptOrganizationComponent } from "./accounts/accept-organization.component";
@ -286,16 +264,15 @@ registerLocaleData(localeZhTw, "zh-TW");
@NgModule({ @NgModule({
imports: [ imports: [
CommonModule, CommonModule,
DragDropModule,
FormsModule, FormsModule,
InfiniteScrollModule, InfiniteScrollModule,
DragDropModule, JslibModule,
ToastrModule,
ReactiveFormsModule, ReactiveFormsModule,
RouterModule, RouterModule,
ToastrModule,
], ],
declarations: [ declarations: [
A11yTitleDirective,
A11yInvalidDirective,
AcceptEmergencyComponent, AcceptEmergencyComponent,
AcceptOrganizationComponent, AcceptOrganizationComponent,
AccessComponent, AccessComponent,
@ -307,27 +284,20 @@ registerLocaleData(localeZhTw, "zh-TW");
AdjustPaymentComponent, AdjustPaymentComponent,
AdjustStorageComponent, AdjustStorageComponent,
AdjustSubscription, AdjustSubscription,
ApiActionDirective,
ApiKeyComponent, ApiKeyComponent,
AttachmentsComponent, AttachmentsComponent,
AutofocusDirective,
AvatarComponent,
BlurClickDirective,
BoxRowDirective,
BreachReportComponent, BreachReportComponent,
BulkActionsComponent, BulkActionsComponent,
BulkDeleteComponent, BulkDeleteComponent,
BulkMoveComponent, BulkMoveComponent,
BulkRestoreComponent, BulkRestoreComponent,
BulkShareComponent, BulkShareComponent,
CalloutComponent,
ChangeEmailComponent, ChangeEmailComponent,
ChangeKdfComponent, ChangeKdfComponent,
ChangePasswordComponent, ChangePasswordComponent,
ChangePlanComponent, ChangePlanComponent,
CiphersComponent, CiphersComponent,
CollectionsComponent, CollectionsComponent,
ColorPasswordPipe,
CreateOrganizationComponent, CreateOrganizationComponent,
DeauthorizeSessionsComponent, DeauthorizeSessionsComponent,
DeleteAccountComponent, DeleteAccountComponent,
@ -343,21 +313,15 @@ registerLocaleData(localeZhTw, "zh-TW");
EmergencyAccessViewComponent, EmergencyAccessViewComponent,
EmergencyAddEditComponent, EmergencyAddEditComponent,
ExportComponent, ExportComponent,
ExportScopeCalloutComponent,
ExposedPasswordsReportComponent, ExposedPasswordsReportComponent,
FallbackSrcDirective,
FamiliesForEnterpriseSetupComponent, FamiliesForEnterpriseSetupComponent,
FolderAddEditComponent, FolderAddEditComponent,
FooterComponent, FooterComponent,
FrontendLayoutComponent, FrontendLayoutComponent,
GroupingsComponent, GroupingsComponent,
HintComponent, HintComponent,
I18nPipe,
IconComponent,
ImportComponent, ImportComponent,
InactiveTwoFactorReportComponent, InactiveTwoFactorReportComponent,
InputStripSpacesDirective,
InputVerbatimDirective,
LinkSsoComponent, LinkSsoComponent,
LockComponent, LockComponent,
LoginComponent, LoginComponent,
@ -423,9 +387,6 @@ registerLocaleData(localeZhTw, "zh-TW");
RequireSsoPolicyComponent, RequireSsoPolicyComponent,
ResetPasswordPolicyComponent, ResetPasswordPolicyComponent,
ReusedPasswordsReportComponent, ReusedPasswordsReportComponent,
SearchCiphersPipe,
SearchPipe,
SelectCopyDirective,
SendAddEditComponent, SendAddEditComponent,
SendComponent, SendComponent,
SendEffluxDatesComponent, SendEffluxDatesComponent,
@ -437,11 +398,8 @@ registerLocaleData(localeZhTw, "zh-TW");
SponsoredFamiliesComponent, SponsoredFamiliesComponent,
SponsoringOrgRowComponent, SponsoringOrgRowComponent,
SsoComponent, SsoComponent,
StopClickDirective,
StopPropDirective,
TaxInfoComponent, TaxInfoComponent,
ToolsComponent, ToolsComponent,
TrueFalseValueDirective,
TwoFactorAuthenticationPolicyComponent, TwoFactorAuthenticationPolicyComponent,
TwoFactorAuthenticatorComponent, TwoFactorAuthenticatorComponent,
TwoFactorComponent, TwoFactorComponent,
@ -456,37 +414,20 @@ registerLocaleData(localeZhTw, "zh-TW");
UnsecuredWebsitesReportComponent, UnsecuredWebsitesReportComponent,
UpdateKeyComponent, UpdateKeyComponent,
UpdateLicenseComponent, UpdateLicenseComponent,
UpdateTempPasswordComponent,
UpdatePasswordComponent, UpdatePasswordComponent,
UpdateTempPasswordComponent,
UserBillingComponent, UserBillingComponent,
UserLayoutComponent, UserLayoutComponent,
UserNamePipe,
UserSubscriptionComponent, UserSubscriptionComponent,
VaultComponent, VaultComponent,
VaultTimeoutInputComponent, VaultTimeoutInputComponent,
VerifyEmailComponent, VerifyEmailComponent,
VerifyEmailTokenComponent, VerifyEmailTokenComponent,
VerifyMasterPasswordComponent,
VerifyRecoverDeleteComponent, VerifyRecoverDeleteComponent,
WeakPasswordsReportComponent, WeakPasswordsReportComponent,
], ],
exports: [ exports: [FooterComponent, NavbarComponent, OrganizationPlansComponent],
A11yTitleDirective, providers: [DatePipe],
A11yInvalidDirective,
ApiActionDirective,
AvatarComponent,
CalloutComponent,
FooterComponent,
I18nPipe,
InputStripSpacesDirective,
NavbarComponent,
OrganizationPlansComponent,
SearchPipe,
StopClickDirective,
StopPropDirective,
UserNamePipe,
],
providers: [DatePipe, SearchPipe, UserNamePipe],
bootstrap: [], bootstrap: [],
}) })
export class OssModule {} export class OssModule {}