Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-22 16:29:09 +01:00
Code Issues Projects Releases Wiki Activity

[AC-1260] Removed ssoRequired field from the sso details response (#5123)

Browse Source 
* Removed ssoRequired field from the sso details response

* Fixed PR comment
This commit is contained in:
SmithThe4th 2023-04-03 11:45:22 -04:00 committed by GitHub
parent a68631c7b7
commit a78ed4c548
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/web/src/auth/sso.component.ts
View File

@ -104,11 +104,8 @@ export class SsoComponent extends BaseSsoComponent {
const errorResponse: ErrorResponse = error as ErrorResponse; const errorResponse: ErrorResponse = error as ErrorResponse;
switch (errorResponse.statusCode) { switch (errorResponse.statusCode) {
case HttpStatusCode.NotFound: case HttpStatusCode.NotFound:
if (errorResponse?.message?.includes("Claimed org domain not found")) { //this is a valid case for a domain not found
// Do nothing. This is a valid case.
return; return;
}
break;
default: default:
this.validationService.showError(errorResponse); this.validationService.showError(errorResponse);

2
libs/common/src/abstractions/organization-domain/responses/organization-domain-sso-details.response.ts
View File

@ -5,7 +5,6 @@ export class OrganizationDomainSsoDetailsResponse extends BaseResponse {
organizationIdentifier: string; organizationIdentifier: string;
ssoAvailable: boolean; ssoAvailable: boolean;
domainName: string; domainName: string;
ssoRequired: boolean;
verifiedDate?: Date; verifiedDate?: Date;
constructor(response: any) { constructor(response: any) {
@ -14,7 +13,6 @@ export class OrganizationDomainSsoDetailsResponse extends BaseResponse {
this.organizationIdentifier = this.getResponseProperty("organizationIdentifier"); this.organizationIdentifier = this.getResponseProperty("organizationIdentifier");
this.ssoAvailable = this.getResponseProperty("ssoAvailable"); this.ssoAvailable = this.getResponseProperty("ssoAvailable");
this.domainName = this.getResponseProperty("domainName"); this.domainName = this.getResponseProperty("domainName");
this.ssoRequired = this.getResponseProperty("ssoRequired");
this.verifiedDate = this.getResponseProperty("verifiedDate"); this.verifiedDate = this.getResponseProperty("verifiedDate");
} }
} }