Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-11 13:30:39 +01:00
Code Issues Projects Releases Wiki Activity

Defect/[PM-1887] - Fix Account Creation Terms of Service Checkbox not clickable in Safari (#5240)

Browse Source 
* PM-1887 - Fix Account Creation Terms of service checkbox not clickable in Safari. Reworked check for breaches and terms of service checkboxes to be implemented with Tailwind instead of a mix of Tailwind & Bootstrap as well. Confirmed checkboxes still work in Edge, Firefiox, and Chrome as well as Safari now.

* PM-1887 - Add for="<id>" attributes to bit-labels for accessibility.

* PM-1887 - Make ID consistent w/ dashes instead of underlines and dashes.
This commit is contained in:
Jared Snider 2023-04-19 17:19:55 -04:00 committed by GitHub
parent 68b62e73f1
commit aa26bc5e17
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
apps/web/src/auth/register-form/register-form.component.html
View File

@ -91,31 +91,27 @@
<div [hidden]="!showCaptcha()"> <div [hidden]="!showCaptcha()">
<iframe id="hcaptcha_iframe" height="80"></iframe> <iframe id="hcaptcha_iframe" height="80"></iframe>
</div> </div>
<div class="form-group"> <div class="tw-mb-4 tw-flex tw-items-start">
<div class="form-check">
<input <input
class="form-check-input" class="mt-1"
type="checkbox" type="checkbox"
bitCheckbox
id="checkForBreaches" id="checkForBreaches"
name="CheckBreach" name="CheckBreach"
formControlName="checkForBreaches" formControlName="checkForBreaches"
/> />
<label class="form-check-label" for="checkForBreaches"> <bit-label for="checkForBreaches"> {{ "checkForBreaches" | i18n }}</bit-label>
{{ "checkForBreaches" | i18n }}
</label>
</div>
</div> </div>
<div class="tw-mb-3 tw-flex tw-items-start" *ngIf="showTerms"> <div class="tw-mb-3 tw-flex tw-items-start" *ngIf="showTerms">
<div class="tw-flex tw-h-6 tw-items-center">
<input <input
id="register-form_input_accept-policies" class="mt-1"
class="tw-border-gray-300 tw-w-4 tw-rounded tw-border" id="register-form-input-accept-policies"
bitInput bitCheckbox
type="checkbox" type="checkbox"
formControlName="acceptPolicies" formControlName="acceptPolicies"
/> />
</div>
<bit-label class="ml-2"> <bit-label for="register-form-input-accept-policies">
{{ "acceptPolicies" | i18n }}<br /> {{ "acceptPolicies" | i18n }}<br />
<a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{ <a href="https://bitwarden.com/terms/" target="_blank" rel="noopener">{{
"termsOfService" | i18n "termsOfService" | i18n