Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-11 10:10:25 +01:00
Code Issues Projects Releases Wiki Activity

[PM-9921] Add Popout to Add/Edit/View components (#10382)

Browse Source 
* add popout component to add/edit component

* add popout component to view cipher components

* fix formatting
This commit is contained in:
Nick Krantz 2024-08-05 13:18:16 -05:00 committed by GitHub
parent 334393ff16
commit aaf8b3e2b1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.html
View File

@ -4,7 +4,9 @@
[pageTitle]="headerText" [pageTitle]="headerText"
[backAction]="handleBackButton.bind(this)" [backAction]="handleBackButton.bind(this)"
showBackButton showBackButton
></popup-header> >
<app-pop-out slot="end" />
</popup-header>
<vault-cipher-form <vault-cipher-form
*ngIf="!loading" *ngIf="!loading"

2
apps/browser/src/vault/popup/components/vault-v2/add-edit/add-edit-v2.component.ts
View File

@ -21,6 +21,7 @@ import {
} from "@bitwarden/vault"; } from "@bitwarden/vault";
import BrowserPopupUtils from "../../../../../platform/popup/browser-popup-utils"; import BrowserPopupUtils from "../../../../../platform/popup/browser-popup-utils";
import { PopOutComponent } from "../../../../../platform/popup/components/pop-out.component";
import { PopupFooterComponent } from "../../../../../platform/popup/layout/popup-footer.component"; import { PopupFooterComponent } from "../../../../../platform/popup/layout/popup-footer.component";
import { PopupHeaderComponent } from "../../../../../platform/popup/layout/popup-header.component"; import { PopupHeaderComponent } from "../../../../../platform/popup/layout/popup-header.component";
import { PopupPageComponent } from "../../../../../platform/popup/layout/popup-page.component"; import { PopupPageComponent } from "../../../../../platform/popup/layout/popup-page.component";
@ -118,6 +119,7 @@ export type AddEditQueryParams = Partial<Record<keyof QueryParams, string>>;
PopupFooterComponent, PopupFooterComponent,
CipherFormModule, CipherFormModule,
AsyncActionsModule, AsyncActionsModule,
PopOutComponent,
], ],
}) })
export class AddEditV2Component implements OnInit { export class AddEditV2Component implements OnInit {

4
apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.html
View File

@ -1,5 +1,7 @@
<popup-page> <popup-page>
<popup-header slot="header" [pageTitle]="headerText" showBackButton> </popup-header> <popup-header slot="header" [pageTitle]="headerText" showBackButton>
<app-pop-out slot="end" />
</popup-header>
<app-cipher-view *ngIf="cipher" [cipher]="cipher"></app-cipher-view> <app-cipher-view *ngIf="cipher" [cipher]="cipher"></app-cipher-view>

2
apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts
View File

@ -24,6 +24,7 @@ import {
} from "@bitwarden/components"; } from "@bitwarden/components";
import { CipherViewComponent } from "../../../../../../../../libs/vault/src/cipher-view"; import { CipherViewComponent } from "../../../../../../../../libs/vault/src/cipher-view";
import { PopOutComponent } from "../../../../../platform/popup/components/pop-out.component";
import { PopupFooterComponent } from "./../../../../../platform/popup/layout/popup-footer.component"; import { PopupFooterComponent } from "./../../../../../platform/popup/layout/popup-footer.component";
import { PopupHeaderComponent } from "./../../../../../platform/popup/layout/popup-header.component"; import { PopupHeaderComponent } from "./../../../../../platform/popup/layout/popup-header.component";
@ -45,6 +46,7 @@ import { PopupPageComponent } from "./../../../../../platform/popup/layout/popup
IconButtonModule, IconButtonModule,
CipherViewComponent, CipherViewComponent,
AsyncActionsModule, AsyncActionsModule,
PopOutComponent,
], ],
}) })
export class ViewV2Component { export class ViewV2Component {