Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-23 11:56:00 +01:00
Code Issues Projects Releases Wiki Activity

Resolve edit always being true for ciphers

Browse Source 
I noticed that ciphers will always have `edit = True` even if the sync response has `edit = false`.

The root cause seems to be a boolean default to true. And since `false || true => true` it would always be set to true.
This commit is contained in:
Oscar Hinton 2020-05-21 14:31:53 +02:00 committed by GitHub
parent 2858724f44
commit ab506ffbdb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/models/response/cipherResponse.ts
View File

@ -38,7 +38,7 @@ export class CipherResponse extends BaseResponse {
this.name = this.getResponseProperty('Name'); this.name = this.getResponseProperty('Name');
this.notes = this.getResponseProperty('Notes'); this.notes = this.getResponseProperty('Notes');
this.favorite = this.getResponseProperty('Favorite') || false; this.favorite = this.getResponseProperty('Favorite') || false;
this.edit = this.getResponseProperty('Edit') || true; this.edit = !!this.getResponseProperty('Edit');
this.organizationUseTotp = this.getResponseProperty('OrganizationUseTotp'); this.organizationUseTotp = this.getResponseProperty('OrganizationUseTotp');
this.revisionDate = this.getResponseProperty('RevisionDate'); this.revisionDate = this.getResponseProperty('RevisionDate');
this.collectionIds = this.getResponseProperty('CollectionIds'); this.collectionIds = this.getResponseProperty('CollectionIds');