From adf72986783fa6b4814b413ace59919d060e9e3a Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Mon, 17 Apr 2023 14:06:37 +0200 Subject: [PATCH] [EC-598] chore: tweak how unassigned rpId gets calcuated --- libs/common/src/fido2/services/fido2-client.service.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libs/common/src/fido2/services/fido2-client.service.ts b/libs/common/src/fido2/services/fido2-client.service.ts index ae5832d498..c815ee9132 100644 --- a/libs/common/src/fido2/services/fido2-client.service.ts +++ b/libs/common/src/fido2/services/fido2-client.service.ts @@ -41,9 +41,9 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction { } const parsedOrigin = parse(params.origin, { allowPrivateDomains: true }); - const rpId = params.rp.id ?? parsedOrigin.domain; + const rpId = params.rp.id ?? parsedOrigin.hostname; - if (parsedOrigin.domain == undefined || !params.origin.startsWith("https://")) { + if (parsedOrigin.hostname == undefined || !params.origin.startsWith("https://")) { throw new DOMException("'origin' is not a valid https origin", "SecurityError"); } @@ -161,9 +161,9 @@ export class Fido2ClientService implements Fido2ClientServiceAbstraction { } const parsedOrigin = parse(params.origin, { allowPrivateDomains: true }); - const rpId = params.rpId ?? parsedOrigin.domain; + const rpId = params.rpId ?? parsedOrigin.hostname; - if (parsedOrigin.domain == undefined || !params.origin.startsWith("https://")) { + if (parsedOrigin.hostname == undefined || !params.origin.startsWith("https://")) { throw new DOMException("'origin' is not a valid https origin", "SecurityError"); }