From af2c75cb4bc0cde7e4ab223bb7f497bb9de29e1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Garc=C3=ADa?= Date: Wed, 6 Mar 2024 19:10:56 +0100 Subject: [PATCH] Update snap base to core22 (#8224) * Update snap base to core22 * Add version warnings to the workflows --- .github/workflows/build-cli.yml | 3 +++ .github/workflows/build-desktop.yml | 3 +++ apps/desktop/electron-builder.json | 1 + 3 files changed, 7 insertions(+) diff --git a/.github/workflows/build-cli.yml b/.github/workflows/build-cli.yml index e31ac448b0..87c34da588 100644 --- a/.github/workflows/build-cli.yml +++ b/.github/workflows/build-cli.yml @@ -278,6 +278,9 @@ jobs: snap: name: Build Snap + # Note, before updating the ubuntu version of the workflow, ensure the snap base image + # is equal or greater than the new version. Otherwise there might be GLIBC version issues. + # The snap base for CLI is defined in `apps/cli/stores/snap/snapcraft.yaml` runs-on: ubuntu-22.04 needs: [setup, cli] env: diff --git a/.github/workflows/build-desktop.yml b/.github/workflows/build-desktop.yml index 057def8e34..2823e7732c 100644 --- a/.github/workflows/build-desktop.yml +++ b/.github/workflows/build-desktop.yml @@ -124,6 +124,9 @@ jobs: linux: name: Linux Build + # Note, before updating the ubuntu version of the workflow, ensure the snap base image + # is equal or greater than the new version. Otherwise there might be GLIBC version issues. + # The snap base for desktop is defined in `apps/desktop/electron-builder.json` runs-on: ubuntu-22.04 needs: setup env: diff --git a/apps/desktop/electron-builder.json b/apps/desktop/electron-builder.json index 5e71801892..83a2179d58 100644 --- a/apps/desktop/electron-builder.json +++ b/apps/desktop/electron-builder.json @@ -167,6 +167,7 @@ }, "snap": { "autoStart": true, + "base": "core22", "confinement": "strict", "plugs": ["default", "password-manager-service"], "stagePackages": ["default"]