From b2af12ab242764ead31413ca91f8506fb2b3d0c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=9C=A8=20Audrey=20=E2=9C=A8?= <ajensen@bitwarden.com>
Date: Tue, 10 Dec 2024 11:08:01 -0500
Subject: [PATCH] [PM-15872] fix username generation character limit (#12329)

---
 libs/tools/generator/core/src/engine/username-randomizer.ts | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libs/tools/generator/core/src/engine/username-randomizer.ts b/libs/tools/generator/core/src/engine/username-randomizer.ts
index d5872e21ce..df60855383 100644
--- a/libs/tools/generator/core/src/engine/username-randomizer.ts
+++ b/libs/tools/generator/core/src/engine/username-randomizer.ts
@@ -6,6 +6,9 @@ import { CredentialGenerator, EffUsernameGenerationOptions, GeneratedCredential
 import { Randomizer } from "./abstractions";
 import { WordsRequest } from "./types";
 
+/** The number of digits used when generating an Eff username with a number. */
+const NUMBER_OF_DIGITS = 4;
+
 /** Generation algorithms that produce randomized usernames */
 export class UsernameRandomizer implements CredentialGenerator<EffUsernameGenerationOptions> {
   /** Instantiates the username randomizer
@@ -51,7 +54,7 @@ export class UsernameRandomizer implements CredentialGenerator<EffUsernameGenera
   async generate(_request: GenerationRequest, settings: EffUsernameGenerationOptions) {
     if (isEffUsernameGenerationOptions(settings)) {
       const username = await this.randomWords({
-        digits: settings.wordIncludeNumber ? 1 : 0,
+        digits: settings.wordIncludeNumber ? NUMBER_OF_DIGITS : 0,
         casing: settings.wordCapitalize ? "TitleCase" : "lowercase",
       });