Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-21 11:35:34 +01:00
Code Issues Projects Releases Wiki Activity

SM-716 - Write access for service accounts (#5622)

Browse Source 
* SM-716

* thomas suggested changes

* removing unused code

* 2
This commit is contained in:
cd-bitwarden 2023-06-30 13:17:26 -04:00 committed by GitHub
parent 05c4d172a7
commit b845eaf91f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-service-accounts.component.html
View File

@ -11,6 +11,7 @@
[emptyMessage]="'projectEmptyServiceAccountAccessPolicies' | i18n" [emptyMessage]="'projectEmptyServiceAccountAccessPolicies' | i18n"
(onCreateAccessPolicies)="handleCreateAccessPolicies($event)" (onCreateAccessPolicies)="handleCreateAccessPolicies($event)"
(onDeleteAccessPolicy)="handleDeleteAccessPolicy($event)" (onDeleteAccessPolicy)="handleDeleteAccessPolicy($event)"
(onUpdateAccessPolicy)="handleUpdateAccessPolicy($event)"
> >
</sm-access-selector> </sm-access-selector>
</div> </div>

12
bitwarden_license/bit-web/src/app/secrets-manager/projects/project/project-service-accounts.component.ts
View File

@ -39,11 +39,21 @@ export class ProjectServiceAccountsComponent implements OnInit, OnDestroy {
read: policy.read, read: policy.read,
write: policy.write, write: policy.write,
icon: AccessSelectorComponent.serviceAccountIcon, icon: AccessSelectorComponent.serviceAccountIcon,
static: true, static: false,
})) }))
) )
); );
protected async handleUpdateAccessPolicy(policy: AccessSelectorRowView) {
try {
return await this.accessPolicyService.updateAccessPolicy(
AccessSelectorComponent.getBaseAccessPolicyView(policy)
);
} catch (e) {
this.validationService.showError(e);
}
}
protected handleCreateAccessPolicies(selected: SelectItemView[]) { protected handleCreateAccessPolicies(selected: SelectItemView[]) {
const projectAccessPoliciesView = new ProjectAccessPoliciesView(); const projectAccessPoliciesView = new ProjectAccessPoliciesView();
projectAccessPoliciesView.serviceAccountAccessPolicies = selected projectAccessPoliciesView.serviceAccountAccessPolicies = selected

1
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/projects/service-account-projects.component.html
View File

@ -11,6 +11,7 @@
[emptyMessage]="'serviceAccountEmptyProjectAccesspolicies' | i18n" [emptyMessage]="'serviceAccountEmptyProjectAccesspolicies' | i18n"
(onCreateAccessPolicies)="handleCreateAccessPolicies($event)" (onCreateAccessPolicies)="handleCreateAccessPolicies($event)"
(onDeleteAccessPolicy)="handleDeleteAccessPolicy($event)" (onDeleteAccessPolicy)="handleDeleteAccessPolicy($event)"
(onUpdateAccessPolicy)="handleUpdateAccessPolicy($event)"
> >
</sm-access-selector> </sm-access-selector>
</div> </div>

16
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/projects/service-account-projects.component.ts
View File

@ -1,4 +1,4 @@
import { Component } from "@angular/core"; import { Component, OnDestroy, OnInit } from "@angular/core";
import { ActivatedRoute } from "@angular/router"; import { ActivatedRoute } from "@angular/router";
import { combineLatestWith, map, Observable, startWith, Subject, switchMap, takeUntil } from "rxjs"; import { combineLatestWith, map, Observable, startWith, Subject, switchMap, takeUntil } from "rxjs";
@ -16,7 +16,7 @@ import {
selector: "sm-service-account-projects", selector: "sm-service-account-projects",
templateUrl: "./service-account-projects.component.html", templateUrl: "./service-account-projects.component.html",
}) })
export class ServiceAccountProjectsComponent { export class ServiceAccountProjectsComponent implements OnInit, OnDestroy {
private destroy$ = new Subject<void>(); private destroy$ = new Subject<void>();
private serviceAccountId: string; private serviceAccountId: string;
private organizationId: string; private organizationId: string;
@ -38,7 +38,7 @@ export class ServiceAccountProjectsComponent {
read: policy.read, read: policy.read,
write: policy.write, write: policy.write,
icon: AccessSelectorComponent.projectIcon, icon: AccessSelectorComponent.projectIcon,
static: true, static: false,
} as AccessSelectorRowView; } as AccessSelectorRowView;
}); });
}) })
@ -63,6 +63,16 @@ export class ServiceAccountProjectsComponent {
); );
} }
protected async handleUpdateAccessPolicy(policy: AccessSelectorRowView) {
try {
return await this.accessPolicyService.updateAccessPolicy(
AccessSelectorComponent.getBaseAccessPolicyView(policy)
);
} catch (e) {
this.validationService.showError(e);
}
}
protected async handleDeleteAccessPolicy(policy: AccessSelectorRowView) { protected async handleDeleteAccessPolicy(policy: AccessSelectorRowView) {
try { try {
await this.accessPolicyService.deleteAccessPolicy(policy.accessPolicyId); await this.accessPolicyService.deleteAccessPolicy(policy.accessPolicyId);