Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-13 10:24:20 +01:00
Code Issues Projects Releases Wiki Activity

prevent computation of samlsigningoptions on change detection (#10399)

Browse Source
This commit is contained in:
Jake Fink 2024-08-21 15:06:19 -04:00 committed by GitHub
parent b233f90b4c
commit bbe64f4ae6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
bitwarden_license/bit-web/src/app/auth/sso/sso.component.ts
View File

@ -26,7 +26,6 @@ import { SsoConfigApi } from "@bitwarden/common/auth/models/api/sso-config.api";
import { OrganizationSsoRequest } from "@bitwarden/common/auth/models/request/organization-sso.request"; import { OrganizationSsoRequest } from "@bitwarden/common/auth/models/request/organization-sso.request";
import { OrganizationSsoResponse } from "@bitwarden/common/auth/models/response/organization-sso.response"; import { OrganizationSsoResponse } from "@bitwarden/common/auth/models/response/organization-sso.response";
import { SsoConfigView } from "@bitwarden/common/auth/models/view/sso-config.view"; import { SsoConfigView } from "@bitwarden/common/auth/models/view/sso-config.view";
import { ConfigService } from "@bitwarden/common/platform/abstractions/config/config.service";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service"; import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service"; import { PlatformUtilsService } from "@bitwarden/common/platform/abstractions/platform-utils.service";
import { Utils } from "@bitwarden/common/platform/misc/utils"; import { Utils } from "@bitwarden/common/platform/misc/utils";
@ -61,6 +60,10 @@ export class SsoComponent implements OnInit, OnDestroy {
"http://www.w3.org/2000/09/xmldsig#rsa-sha512", "http://www.w3.org/2000/09/xmldsig#rsa-sha512",
]; ];
readonly samlSigningAlgorithmOptions: SelectOptions[] = this.samlSigningAlgorithms.map(
(algorithm) => ({ name: algorithm, value: algorithm }),
);
readonly saml2SigningBehaviourOptions: SelectOptions[] = [ readonly saml2SigningBehaviourOptions: SelectOptions[] = [
{ {
name: "If IdP Wants Authn Requests Signed", name: "If IdP Wants Authn Requests Signed",
@ -186,7 +189,6 @@ export class SsoComponent implements OnInit, OnDestroy {
private i18nService: I18nService, private i18nService: I18nService,
private organizationService: OrganizationService, private organizationService: OrganizationService,
private organizationApiService: OrganizationApiServiceAbstraction, private organizationApiService: OrganizationApiServiceAbstraction,
private configService: ConfigService,
) {} ) {}
async ngOnInit() { async ngOnInit() {
@ -330,10 +332,6 @@ export class SsoComponent implements OnInit, OnDestroy {
return this.ssoConfigForm.get("keyConnectorUrl"); return this.ssoConfigForm.get("keyConnectorUrl");
} }
get samlSigningAlgorithmOptions(): SelectOptions[] {
return this.samlSigningAlgorithms.map((algorithm) => ({ name: algorithm, value: algorithm }));
}
/** /**
* Shows any validation errors for the form by marking all controls as dirty and touched. * Shows any validation errors for the form by marking all controls as dirty and touched.
* If nested form groups are found, they are also updated. * If nested form groups are found, they are also updated.