diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 45dc606ecc..3fdb2f43b2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -41,10 +41,40 @@ jobs: echo "::set-output name=repo_url::$repo_url" echo "::set-output name=adj_build_number::$adj_build_num" - - browser: - runs-on: windows-latest + locales-test: + runs-on: ubuntu-latest needs: setup + steps: + - name: Checkout repo + uses: actions/checkout@v2 + + - name: Testing locales - extName length + run: | + found_error=false + + echo "Locales Test" + echo "============" + echo "extName string must be 40 characters or less" + echo + for locale in $(ls src/_locales/); do + string_length=$(jq '.extName.message | length' src/_locales/$locale/messages.json) + if [[ $string_length -gt 40 ]]; then + echo "$locale: $string_length" + found_error=true + fi + done + + if $found_error; then + echo + echo "Please fix 'extName' for the locales listed above." + exit 1 + else + echo "Test passed!" + fi + + build: + runs-on: windows-latest + needs: [ setup, locales-test ] env: REPO_URL: ${{ needs.setup.outputs.repo_url }} BUILD_NUMBER: ${{ needs.setup.outputs.adj_build_number }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9ce04db9d4..c4aed1f54f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -64,9 +64,40 @@ jobs: prerelease: false - browser: - runs-on: windows-latest + locales-test: + runs-on: ubuntu-latest needs: setup + steps: + - name: Checkout repo + uses: actions/checkout@v2 + + - name: Testing locales - extName length + run: | + found_error=false + + echo "Locales Test" + echo "============" + echo "extName string must be 40 characters or less" + echo + for locale in $(ls src/_locales/); do + string_length=$(jq '.extName.message | length' src/_locales/$locale/messages.json) + if [[ $string_length -gt 40 ]]; then + echo "$locale: $string_length" + found_error=true + fi + done + + if $found_error; then + echo + echo "Please fix 'extName' for the locales listed above." + exit 1 + else + echo "Test passed!" + fi + + build: + runs-on: windows-latest + needs: [ setup, locales-test ] env: REPO_URL: ${{ needs.setup.outputs.repo_url }} BUILD_NUMBER: ${{ needs.setup.outputs.adj_build_number }} diff --git a/src/popup/app.module.ts b/src/popup/app.module.ts index a15a510868..4837f151f3 100644 --- a/src/popup/app.module.ts +++ b/src/popup/app.module.ts @@ -103,7 +103,7 @@ import localeIt from '@angular/common/locales/it'; import localeJa from '@angular/common/locales/ja'; import localeKo from '@angular/common/locales/ko'; import localeLv from '@angular/common/locales/lv'; -import localeMlIn from '@angular/common/locales/ml-IN'; +import localeMl from '@angular/common/locales/ml'; import localeNb from '@angular/common/locales/nb'; import localeNl from '@angular/common/locales/nl'; import localePl from '@angular/common/locales/pl'; @@ -144,7 +144,7 @@ registerLocaleData(localeIt, 'it'); registerLocaleData(localeJa, 'ja'); registerLocaleData(localeKo, 'ko'); registerLocaleData(localeLv, 'lv'); -registerLocaleData(localeMlIn, 'ml-IN'); +registerLocaleData(localeMl, 'ml'); registerLocaleData(localeNb, 'nb'); registerLocaleData(localeNl, 'nl'); registerLocaleData(localePl, 'pl'); diff --git a/src/services/i18n.service.ts b/src/services/i18n.service.ts index a8dac854c4..7cf2d06e27 100644 --- a/src/services/i18n.service.ts +++ b/src/services/i18n.service.ts @@ -10,7 +10,7 @@ export default class I18nService extends BaseI18nService { this.supportedTranslationLocales = [ 'en', 'be', 'bg', 'bn', 'ca', 'cs', 'da', 'de', 'el', 'en-GB', 'en-IN', 'es', 'et', 'fa', 'fi', 'fr', 'he', 'hr', 'hu', - 'id', 'it', 'ja', 'ko', 'lv', 'ml-IN', 'nb', 'nl', 'pl', 'pt-BR', 'pt-PT', 'ro', 'ru', 'sk', 'sr', 'sv', 'th', 'tr', 'uk', + 'id', 'it', 'ja', 'ko', 'lv', 'ml', 'nb', 'nl', 'pl', 'pt-BR', 'pt-PT', 'ro', 'ru', 'sk', 'sr', 'sv', 'th', 'tr', 'uk', 'vi', 'zh-CN', 'zh-TW', ]; }