From c276d5dfa57425a9477255c5d777c2e61ddb2e6a Mon Sep 17 00:00:00 2001
From: Cesar Gonzalez
Date: Fri, 20 Sep 2024 09:04:48 -0500
Subject: [PATCH] [PM-281] A11y visual distinction required for page links
(#9878)
* [PM-281] Visual distinction required for login page links
* add bitLink to report links
* add bitLink to billing history
* [PM-281] Adding more references to bitLink and incorporating changes to aria labels for a variety of buttons
* Added editItemWithName to announce links within reports even better
---------
Co-authored-by: Vicki League
Co-authored-by: Daniel James Smith
---
.../member-dialog.component.html | 2 +-
.../settings/account.component.html | 2 +-
.../login-via-webauthn.component.html | 2 +-
.../src/app/auth/login/login.component.html | 14 ++++---
.../register-form.component.html | 6 +--
.../settings/change-password.component.html | 2 +-
.../emergency-access-add-edit.component.html | 2 +-
.../emergency-access.component.html | 2 +-
.../change-kdf/change-kdf.component.html | 4 +-
.../settings/two-factor-setup.component.html | 2 +-
.../two-factor-webauthn.component.html | 2 +-
.../shared/billing-history.component.html | 8 +++-
.../shared/payment/payment.component.html | 2 +-
.../app/settings/preferences.component.html | 4 +-
.../account-fingerprint.component.html | 2 +-
.../exposed-passwords-report.component.html | 3 +-
.../inactive-two-factor-report.component.html | 3 +-
.../reused-passwords-report.component.html | 3 +-
.../unsecured-websites-report.component.html | 12 ++++--
.../weak-passwords-report.component.html | 3 +-
.../add-edit-custom-fields.component.html | 1 +
.../individual-vault/add-edit.component.html | 7 ++--
.../components/vault-filter.component.html | 2 +-
apps/web/src/locales/en/messages.json | 42 +++++++++++++++++++
.../policies/activate-autofill.component.html | 10 +++--
.../src/app/auth/sso/sso.component.html | 14 ++++---
26 files changed, 112 insertions(+), 44 deletions(-)
diff --git a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html
index ec1728c883..2c5daf93c6 100644
--- a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html
+++ b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html
@@ -40,7 +40,7 @@
bitLink
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutMemberRoles' | i18n }}"
href="https://bitwarden.com/help/user-types-access-control/"
slot="end"
>
diff --git a/apps/web/src/app/admin-console/organizations/settings/account.component.html b/apps/web/src/app/admin-console/organizations/settings/account.component.html
index af605dfd27..e4d3ee7de9 100644
--- a/apps/web/src/app/admin-console/organizations/settings/account.component.html
+++ b/apps/web/src/app/admin-console/organizations/settings/account.component.html
@@ -39,7 +39,7 @@
{{ "apiKeyDesc" | i18n }}
- {{ "learnMore" | i18n }}
+ {{ "learnMoreAboutApi" | i18n }}
{{ "loggingInAs" | i18n }} {{ loggedEmail }}
- {{ "notYou" | i18n }}
+ {{ "notYou" | i18n }}
diff --git a/apps/web/src/app/auth/register-form/register-form.component.html b/apps/web/src/app/auth/register-form/register-form.component.html
index 2e50d69fce..19a7a95b29 100644
--- a/apps/web/src/app/auth/register-form/register-form.component.html
+++ b/apps/web/src/app/auth/register-form/register-form.component.html
@@ -115,11 +115,11 @@
{{ "acceptPolicies" | i18n }}
- {{
+ {{
"termsOfService" | i18n
}},
- {{
+ {{
"privacyPolicy" | i18n
}}
@@ -151,7 +151,7 @@
{{ "alreadyHaveAccount" | i18n }}
- {{ "logIn" | i18n }}
+ {{ "logIn" | i18n }}
diff --git a/apps/web/src/app/auth/settings/change-password.component.html b/apps/web/src/app/auth/settings/change-password.component.html
index b5c8677405..91144fdfc1 100644
--- a/apps/web/src/app/auth/settings/change-password.component.html
+++ b/apps/web/src/app/auth/settings/change-password.component.html
@@ -104,7 +104,7 @@
href="https://bitwarden.com/help/account-encryption-key/#rotate-your-encryption-key"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'impactOfRotatingYourEncryptionKey' | i18n }}"
>
diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html
index 293c5051ce..6e87d66d18 100644
--- a/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html
+++ b/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html
@@ -21,7 +21,7 @@
rel="noreferrer"
bitLink
linkType="primary"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutUserAccess' | i18n }}"
href="https://bitwarden.com/help/emergency-access/#user-access"
slot="end"
>
diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html
index e38f21fde2..fc199a55a7 100644
--- a/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html
+++ b/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html
@@ -9,7 +9,7 @@
target="_blank"
rel="noreferrer"
>
- {{ "learnMore" | i18n }}.
+ {{ "learnMoreAboutEmergencyAccess" | i18n }}
{{
diff --git a/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html b/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html
index 478cd77eb6..203f6d016b 100644
--- a/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html
+++ b/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html
@@ -21,7 +21,7 @@
href="https://bitwarden.com/help/kdf-algorithms"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutEncryptionAlgorithms' | i18n }}"
slot="end"
>
@@ -57,7 +57,7 @@
href="https://bitwarden.com/help/what-encryption-is-used/#changing-kdf-iterations"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutKDFIterations' | i18n }}"
slot="end"
>
diff --git a/apps/web/src/app/auth/settings/two-factor-setup.component.html b/apps/web/src/app/auth/settings/two-factor-setup.component.html
index 3595d9a7dc..b7cd6954fd 100644
--- a/apps/web/src/app/auth/settings/two-factor-setup.component.html
+++ b/apps/web/src/app/auth/settings/two-factor-setup.component.html
@@ -11,7 +11,7 @@
{{ "twoStepLoginEnterpriseDescStart" | i18n }}
- {{ "twoStepLoginPolicy" | i18n }}.
+ {{ "twoStepLoginPolicy" | i18n }}.
{{ "twoStepLoginOrganizationDuoDesc" | i18n }}
diff --git a/apps/web/src/app/auth/settings/two-factor-webauthn.component.html b/apps/web/src/app/auth/settings/two-factor-webauthn.component.html
index 9dc9bd4068..0a2eb346b1 100644
--- a/apps/web/src/app/auth/settings/two-factor-webauthn.component.html
+++ b/apps/web/src/app/auth/settings/two-factor-webauthn.component.html
@@ -42,7 +42,7 @@
aria-hidden="true"
>
-
- {{ "remove" | i18n }}
+ {{ "remove" | i18n }}
diff --git a/apps/web/src/app/billing/shared/billing-history.component.html b/apps/web/src/app/billing/shared/billing-history.component.html
index 1719a59076..fc62157177 100644
--- a/apps/web/src/app/billing/shared/billing-history.component.html
+++ b/apps/web/src/app/billing/shared/billing-history.component.html
@@ -15,7 +15,13 @@
>
-
+
{{ "invoiceNumber" | i18n: i.number }}
diff --git a/apps/web/src/app/billing/shared/payment/payment.component.html b/apps/web/src/app/billing/shared/payment/payment.component.html
index f33768c2c9..d485371357 100644
--- a/apps/web/src/app/billing/shared/payment/payment.component.html
+++ b/apps/web/src/app/billing/shared/payment/payment.component.html
@@ -55,7 +55,7 @@
target="_blank"
rel="noreferrer"
class="hover:tw-no-underline"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'whatIsACvvNumber' | i18n }}"
>
diff --git a/apps/web/src/app/settings/preferences.component.html b/apps/web/src/app/settings/preferences.component.html
index ffd55e69c8..80261ecccb 100644
--- a/apps/web/src/app/settings/preferences.component.html
+++ b/apps/web/src/app/settings/preferences.component.html
@@ -56,7 +56,7 @@
href="https://bitwarden.com/help/localization/"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutLocalization' | i18n }}"
slot="end"
>
@@ -76,7 +76,7 @@
href="https://bitwarden.com/help/website-icons/"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutWebsiteIcons' | i18n }}"
slot="end"
>
diff --git a/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html b/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html
index fd89876860..bc7d9a6417 100644
--- a/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html
+++ b/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html
@@ -6,7 +6,7 @@
href="https://bitwarden.com/help/fingerprint-phrase/"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutYourAccountFingerprintPhrase' | i18n }}"
>
diff --git a/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html
index 43701dcd71..bcd5a28812 100644
--- a/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html
+++ b/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.html
@@ -45,10 +45,11 @@
{{ r.name }}
diff --git a/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html b/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html
index ae2f0988e5..52bbb1c5e6 100644
--- a/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html
+++ b/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html
@@ -48,10 +48,11 @@
|
{{ r.name }}
diff --git a/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html b/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html
index 5d1f151fd7..e836c14996 100644
--- a/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html
+++ b/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.html
@@ -50,10 +50,11 @@
{{ r.name }}
diff --git a/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.html b/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.html
index 2d4a4f0d44..9293915363 100644
--- a/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.html
+++ b/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.html
@@ -47,9 +47,15 @@
|
- {{
- r.name
- }}
+
+ {{ r.name }}
+
{{ r.name }}
diff --git a/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html b/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html
index 1c2a75737e..759cc1b3b0 100644
--- a/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html
+++ b/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html
@@ -151,6 +151,7 @@
@@ -418,6 +418,7 @@
@@ -953,7 +954,7 @@
diff --git a/apps/web/src/app/vault/individual-vault/vault-filter/components/vault-filter.component.html b/apps/web/src/app/vault/individual-vault/vault-filter/components/vault-filter.component.html
index 59e40135b3..8380f96840 100644
--- a/apps/web/src/app/vault/individual-vault/vault-filter/components/vault-filter.component.html
+++ b/apps/web/src/app/vault/individual-vault/vault-filter/components/vault-filter.component.html
@@ -10,7 +10,7 @@
href="https://bitwarden.com/help/searching-vault/"
target="_blank"
rel="noreferrer"
- appA11yTitle="{{ 'learnMore' | i18n }}"
+ appA11yTitle="{{ 'learnMoreAboutSearchingYourVault' | i18n }}"
>
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index c47975bdfe..cc2754b6d6 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -9029,6 +9029,48 @@
"purchasedSeatsRemoved": {
"message": "purchased seats removed"
},
+ "learnMoreAboutEmergencyAccess": {
+ "message":"Learn more about emergency access"
+ },
+ "learnMoreAboutMatchDetection": {
+ "message": "Learn more about match detection"
+ },
+ "learnMoreAboutMasterPasswordReprompt": {
+ "message": "Learn more about master password re-prompt"
+ },
+ "learnMoreAboutSearchingYourVault": {
+ "message": "Learn more about searching your vault"
+ },
+ "learnMoreAboutYourAccountFingerprintPhrase": {
+ "message": "Learn about your account fingerprint phrase"
+ },
+ "impactOfRotatingYourEncryptionKey": {
+ "message": "Impact of rotating your encryption key"
+ },
+ "learnMoreAboutEncryptionAlgorithms": {
+ "message": "Learn more about encryption algorithms"
+ },
+ "learnMoreAboutKDFIterations": {
+ "message": "Learn more about KDF iterations"
+ },
+ "learnMoreAboutLocalization": {
+ "message": "Learn more about localization"
+ },
+ "learnMoreAboutWebsiteIcons": {
+ "message": "Learn more about using website icons"
+ },
+ "learnMoreAboutUserAccess": {
+ "message": "Learn more about user access"
+ },
+ "learnMoreAboutMemberRoles": {
+ "message": "Learn more about member roles and permissions"
+ },
+ "whatIsACvvNumber": {
+ "message": "What is a CVV number?"
+ },
+ "learnMoreAboutApi": {
+ "message": "Learn more about Bitwarden's API"
+ },
"fileSends": {
"message": "File Sends"
},
diff --git a/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html b/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html
index 0b3c8bf6ba..e2dbc8e832 100644
--- a/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html
+++ b/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html
@@ -1,8 +1,12 @@
{{ "experimentalFeature" | i18n }}
- {{
- "learnMoreAboutAutofill" | i18n
- }}
+ {{ "learnMoreAboutAutofill" | i18n }}
diff --git a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html
index a7d369952a..914d015110 100644
--- a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html
+++ b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html
@@ -13,7 +13,7 @@
| |