Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-06 09:20:43 +01:00
Code Issues Projects Releases Wiki Activity

Change website default value to empty string. (#9127)

Browse Source 
Fastmail API returns and error when passed a null value in forDomain.
Empty string is the preferred blank option.

Co-authored-by: yara <ybeadenkopf@fastmailteam.com>
This commit is contained in:
pixls 2024-05-30 13:32:25 -04:00 committed by GitHub
parent e29025df28
commit c37006c564
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libs/common/src/tools/generator/username/email-forwarders/fastmail-forwarder.ts
View File

@ -14,6 +14,8 @@ export class FastmailForwarder implements Forwarder {
throw "Unable to obtain Fastmail masked email account ID.";
}
const forDomain = (options.website || "");
const requestInit: RequestInit = {
redirect: "manual",
cache: "no-store",
@ -35,7 +37,7 @@ export class FastmailForwarder implements Forwarder {
"new-masked-email": {
state: "enabled",
description: "",
forDomain: options.website,
forDomain: forDomain,
emailPrefix: options.fastmail.prefix,
},
},

2
libs/common/src/tools/generator/username/forwarders/fastmail.ts
View File

@ -12,7 +12,7 @@ import { Forwarders } from "../options/constants";
import { EmailPrefixOptions, ApiOptions } from "../options/forwarder-options";
export const DefaultFastmailOptions: ApiOptions & EmailPrefixOptions = Object.freeze({
website: null,
website: "",
domain: "",
prefix: "",
token: "",