Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-27 12:36:14 +01:00
Code Issues Projects Releases Wiki Activity

adding a signing flag for electron builder

Browse Source
This commit is contained in:
Joseph Flinn 2021-01-06 18:58:44 +00:00
parent 048f3fed6f
commit c508c7cd05
2 changed files with 19 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/build.yml vendored
View File

@ -193,12 +193,7 @@ jobs:
shell: pwsh shell: pwsh
run: npm run dist:win:ci run: npm run dist:win:ci
env: env:
SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }} ELECTRON_BUILDER_SIGN: false
SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }}
SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }}
SIGNING_CLIENT_SECRET: ${{ secrets.SIGNING_CLIENT_SECRET }}
SIGNING_CERT_NAME: ${{ secrets.SIGNING_CERT_NAME }}
SECRET_TEST: ${{ secrets.SECRET_TEST }}
- name: Rename appx files for store - name: Rename appx files for store
shell: pwsh shell: pwsh
@ -252,6 +247,7 @@ jobs:
run: | run: |
npm run pack:win npm run pack:win
env: env:
ELECTRON_BUILDER_SIGN: true
SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }} SIGNING_VAULT_URL: ${{ secrets.SIGNING_VAULT_URL }}
SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }} SIGNING_CLIENT_ID: ${{ secrets.SIGNING_CLIENT_ID }}
SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }} SIGNING_TENANT_ID: ${{ secrets.SIGNING_TENANT_ID }}

32
sign.js
View File

@ -1,17 +1,19 @@
exports.default = async function(configuration) { exports.default = async function(configuration) {
require("child_process").execSync( if (process.env.ELECTRON_BUILDER_SIGN) {
`azuresigntool sign ` + require("child_process").execSync(
`-kvu ${process.env.SIGNING_VAULT_URL} ` + `azuresigntool sign ` +
`-kvi ${process.env.SIGNING_CLIENT_ID} ` + `-kvu ${process.env.SIGNING_VAULT_URL} ` +
`-kvt ${process.env.SIGNING_TENANT_ID} ` + `-kvi ${process.env.SIGNING_CLIENT_ID} ` +
`-kvs ${process.env.SIGNING_CLIENT_SECRET} ` + `-kvt ${process.env.SIGNING_TENANT_ID} ` +
`-kvc ${process.env.SIGNING_CERT_NAME} ` + `-kvs ${process.env.SIGNING_CLIENT_SECRET} ` +
`-fd ${configuration.hash} ` + `-kvc ${process.env.SIGNING_CERT_NAME} ` +
`-du ${configuration.site} ` + `-fd ${configuration.hash} ` +
`-tr http://timestamp.digicert.com ` + `-du ${configuration.site} ` +
`${configuration.path}`, `-tr http://timestamp.digicert.com ` +
{ `${configuration.path}`,
stdio: "inherit" {
} stdio: "inherit"
); }
);
}
}; };