From c832728b6dfcab3a75cad6badfdff464257971d2 Mon Sep 17 00:00:00 2001 From: kapitainsky Date: Tue, 13 Apr 2021 19:31:34 +0100 Subject: [PATCH] fix: cmd + w doesn't close the window on macOS (#714) (#342) cmd + w doesn't close the window on macOS. Based on @cscharf explanation - https://github.com/bitwarden/desktop/issues/714#issuecomment-810554674 - it seems that issue was introduced in response to erroneous Apple Store approver request. The code change reversed this change. --- src/electron/baseMenu.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/electron/baseMenu.ts b/src/electron/baseMenu.ts index de08e4da68..2523e63738 100644 --- a/src/electron/baseMenu.ts +++ b/src/electron/baseMenu.ts @@ -9,8 +9,6 @@ import { import { I18nService } from '../abstractions/i18n.service'; import { WindowMain } from './window.main'; -import { isMacAppStore } from './utils'; - export class BaseMenu { protected editMenuItemOptions: MenuItemConstructorOptions; protected viewSubMenuItemOptions: MenuItemConstructorOptions[]; @@ -143,7 +141,7 @@ export class BaseMenu { }, { label: this.i18nService.t('close'), - role: isMacAppStore() ? 'quit' : 'close', + role: 'close', }, ]; }