Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-29 17:38:04 +01:00
Code Issues Projects Releases Wiki Activity

Revert "generate random ids for window and tabs"

Browse Source 
This reverts commit eb4f288948.
This commit is contained in:
Kyle Spearrin 2018-01-12 14:09:04 -05:00
parent eb4f288948
commit ca5026429a
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/browser/browserApi.ts
View File

@ -44,10 +44,12 @@ class BrowserApi {
const returnedTabs: any[] = [];
tabs.forEach((tab: any) => {
const winIndex = safari.application.browserWindows.indexOf(tab.browserWindow);
const tabIndex = tab.browserWindow.tabs.indexOf(tab);
returnedTabs.push({
id: BrowserApi.getTabOrWindowId(tab),
index: tab.browserWindow.tabs.indexOf(tab),
windowId: BrowserApi.getTabOrWindowId(tab.browserWindow),
id: winIndex + '_' + tabIndex,
index: tabIndex,
windowId: winIndex,
title: tab.title,
active: tab === tab.browserWindow.activeTab,
url: tab.url || 'about:blank',
@ -154,22 +156,6 @@ class BrowserApi {
// TODO
}
}
private static getTabOrWindowId(tabOrWindow: any) {
if (tabOrWindow.id) {
return tabOrWindow.id;
}
if (!tabOrWindow.BitwardenCachedId) {
tabOrWindow.BitwardenCachedId = BrowserApi.randomInt(1, Number.MAX_SAFE_INTEGER);
}
return tabOrWindow.BitwardenCachedId;
}
private static randomInt(min: number, max: number): number {
return Math.floor(Math.random() * (max - min + 1)) + min;
}
}
export { BrowserApi };