Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-01 23:01:28 +01:00
Code Issues Projects Releases Wiki Activity

[EC-598] chore: rearrange tests

Browse Source
This commit is contained in:
Andreas Coroiu 2023-03-22 11:10:51 +01:00
parent 376be67f28
commit cb9f102b7d
No known key found for this signature in database
GPG Key ID: E70B5FFC81DFEC1A
1 changed files with 52 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
libs/common/src/webauthn/services/fido2-authenticator.service.spec.ts
View File

@ -34,25 +34,26 @@ describe("FidoAuthenticatorService", () => {
}); });
describe("authenticatorMakeCredential", () => { describe("authenticatorMakeCredential", () => {
// Spec: If the pubKeyCredParams parameter does not contain a valid COSEAlgorithmIdentifier value that is supported by the authenticator, terminate this procedure and return error code let invalidParams!: InvalidParams;
it("should throw error when input does not contain any supported algorithms", async () => {
const params = await createCredentialParams({ beforeEach(async () => {
pubKeyCredParams: [{ alg: 9001, type: "public-key" }], invalidParams = await createInvalidParams();
}); });
const result = async () => await authenticator.makeCredential(params); describe("invalid input parameters", () => {
// Spec: If the pubKeyCredParams parameter does not contain a valid COSEAlgorithmIdentifier value that is supported by the authenticator, terminate this procedure and return error code
it("should throw error when input does not contain any supported algorithms", async () => {
const result = async () =>
await authenticator.makeCredential(invalidParams.unsupportedAlgorithm);
await expect(result).rejects.toThrowError( await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_UNSUPPORTED_ALGORITHM] Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_UNSUPPORTED_ALGORITHM]
); );
}); });
describe("when options parameter is present", () => {
/** Spec: If the option is known but not valid for this command, terminate this procedure */ /** Spec: If the option is known but not valid for this command, terminate this procedure */
it("should throw error when rk has invalid value", async () => { it("should throw error when rk has invalid value", async () => {
const params = await createCredentialParams({ options: { rk: "invalid-value" as any } }); const result = async () => await authenticator.makeCredential(invalidParams.invalidRk);
const result = async () => await authenticator.makeCredential(params);
await expect(result).rejects.toThrowError( await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_INVALID_OPTION] Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_INVALID_OPTION]
@ -61,14 +62,34 @@ describe("FidoAuthenticatorService", () => {
/** Spec: If the option is known but not valid for this command, terminate this procedure */ /** Spec: If the option is known but not valid for this command, terminate this procedure */
it("should throw error when uv has invalid value", async () => { it("should throw error when uv has invalid value", async () => {
const params = await createCredentialParams({ options: { uv: "invalid-value" as any } }); const result = async () => await authenticator.makeCredential(invalidParams.invalidUv);
const result = async () => await authenticator.makeCredential(params);
await expect(result).rejects.toThrowError( await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_INVALID_OPTION] Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_INVALID_OPTION]
); );
}); });
/** Spec: If pinAuth parameter is present and the pinProtocol is not supported */
it("should throw error when pinAuth parameter is present", async () => {
const result = async () => await authenticator.makeCredential(invalidParams.pinAuthPresent);
await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_PIN_AUTH_INVALID]
);
});
it("should not request confirmation from user", async () => {
userInterface.confirmDuplicateCredential.mockResolvedValue(true);
const invalidParams = await createInvalidParams();
for (const p of Object.values(invalidParams)) {
try {
await authenticator.makeCredential(p);
// eslint-disable-next-line no-empty
} catch {}
}
expect(userInterface.confirmNewCredential).not.toHaveBeenCalled();
});
}); });
/** /**
@ -77,19 +98,6 @@ describe("FidoAuthenticatorService", () => {
*/ */
describe.skip("when extensions parameter is present", () => undefined); describe.skip("when extensions parameter is present", () => undefined);
/** Spec: If pinAuth parameter is present and the pinProtocol is not supported */
describe("when pinAuth parameter is present", () => {
it("should throw error", async () => {
const params = await createCredentialParams({ pinAuth: { key: "value" } });
const result = async () => await authenticator.makeCredential(params);
await expect(result).rejects.toThrowError(
Fido2AutenticatorErrorCode[Fido2AutenticatorErrorCode.CTAP2_ERR_PIN_AUTH_INVALID]
);
});
});
describe("when vault contains excluded credential", () => { describe("when vault contains excluded credential", () => {
let excludedCipherView: CipherView; let excludedCipherView: CipherView;
let params: Fido2AuthenticatorMakeCredentialsParams; let params: Fido2AuthenticatorMakeCredentialsParams;
@ -129,14 +137,9 @@ describe("FidoAuthenticatorService", () => {
/** Departure from spec: Check duplication last instead of first */ /** Departure from spec: Check duplication last instead of first */
it("should not request confirmation from user when input data does not pass checks", async () => { it("should not request confirmation from user when input data does not pass checks", async () => {
userInterface.confirmDuplicateCredential.mockResolvedValue(true); userInterface.confirmDuplicateCredential.mockResolvedValue(true);
const paramsList: Fido2AuthenticatorMakeCredentialsParams[] = [ const invalidParams = await createInvalidParams();
{ ...params, options: { rk: "invalid-value" as any } },
{ ...params, options: { uv: "invalid-value" as any } },
{ ...params, pinAuth: { key: "value" } },
{ ...params, pubKeyCredParams: [{ alg: 9001, type: "public-key" }] },
];
for (const p of paramsList) { for (const p of Object.values(invalidParams)) {
try { try {
await authenticator.makeCredential(p); await authenticator.makeCredential(p);
// eslint-disable-next-line no-empty // eslint-disable-next-line no-empty
@ -172,25 +175,6 @@ describe("FidoAuthenticatorService", () => {
); );
}); });
}); });
it("should not request confirmation from user when input data does not pass checks", async () => {
userInterface.confirmDuplicateCredential.mockResolvedValue(true);
const params = await createCredentialParams();
const paramsList: Fido2AuthenticatorMakeCredentialsParams[] = [
{ ...params, options: { rk: "invalid-value" as any } },
{ ...params, options: { uv: "invalid-value" as any } },
{ ...params, pinAuth: { key: "value" } },
{ ...params, pubKeyCredParams: [{ alg: 9001, type: "public-key" }] },
];
for (const p of paramsList) {
try {
await authenticator.makeCredential(p);
// eslint-disable-next-line no-empty
} catch {}
}
expect(userInterface.confirmNewCredential).not.toHaveBeenCalled();
});
}); });
}); });
@ -236,6 +220,18 @@ async function createCredentialParams(
}; };
} }
type InvalidParams = Awaited<ReturnType<typeof createInvalidParams>>;
async function createInvalidParams() {
return {
unsupportedAlgorithm: await createCredentialParams({
pubKeyCredParams: [{ alg: 9001, type: "public-key" }],
}),
invalidRk: await createCredentialParams({ options: { rk: "invalid-value" as any } }),
invalidUv: await createCredentialParams({ options: { uv: "invalid-value" as any } }),
pinAuthPresent: await createCredentialParams({ pinAuth: { key: "value" } }),
};
}
function createCipher(id = Utils.newGuid()): Cipher { function createCipher(id = Utils.newGuid()): Cipher {
const cipher = new Cipher(); const cipher = new Cipher();
cipher.id = id; cipher.id = id;