[PM-18599] Forbid unknown property and element in tests (#13556)

Fail tests when relying on unknownProperties or unknownElements. Existing instances are whitelist and have tickets created and assigned to the relevant teams.
2025-02-28 03:21:40 +01:00 · 2025-02-25 23:02:19 +01:00 · 2025-02-25 23:02:19 +01:00 · cec117459b
commit cec117459b
parent e6e6058f9e
34 changed files with 65 additions and 17 deletions
--- a/apps/browser/test.setup.ts
+++ b/apps/browser/test.setup.ts
@ -1,4 +1,4 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";
 import { addCustomMatchers } from "@bitwarden/common/spec";

 addCustomMatchers();
--- a/apps/browser/tsconfig.json
+++ b/apps/browser/tsconfig.json
@ -32,6 +32,7 @@
      "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../../libs/tools/card/src"],
      "@bitwarden/ui-common": ["../../libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../../libs/ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": [
        "../../libs/tools/export/vault-export/vault-export-core/src"
      ],
--- a/apps/desktop/test.setup.ts
+++ b/apps/desktop/test.setup.ts
@ -1,4 +1,4 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/apps/desktop/tsconfig.json
+++ b/apps/desktop/tsconfig.json
@ -31,6 +31,7 @@
      "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../../libs/tools/card/src"],
      "@bitwarden/ui-common": ["../../libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../../libs/ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": [
        "../../libs/tools/export/vault-export/vault-export-core/src"
      ],
--- a/apps/web/src/app/auth/recover-two-factor.component.spec.ts
+++ b/apps/web/src/app/auth/recover-two-factor.component.spec.ts
@ -70,6 +70,8 @@ describe("RecoverTwoFactorComponent", () => {
        },
      ],
      imports: [I18nPipe],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
    });

    fixture = TestBed.createComponent(RecoverTwoFactorComponent);
--- a/apps/web/src/app/tools/reports/pages/breach-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/breach-report.component.spec.ts
@ -66,6 +66,9 @@ describe("BreachReportComponent", () => {
          useValue: mock<I18nService>(),
        },
      ],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
+      errorOnUnknownProperties: false,
    }).compileComponents();
  });

--- a/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/exposed-passwords-report.component.spec.ts
@ -84,6 +84,9 @@ describe("ExposedPasswordsReportComponent", () => {
        },
      ],
      schemas: [],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
+      errorOnUnknownProperties: false,
    }).compileComponents();
  });

--- a/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.spec.ts
@ -82,6 +82,8 @@ describe("InactiveTwoFactorReportComponent", () => {
        },
      ],
      schemas: [],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
    }).compileComponents();
  });

--- a/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/reused-passwords-report.component.spec.ts
@ -77,6 +77,8 @@ describe("ReusedPasswordsReportComponent", () => {
        },
      ],
      schemas: [],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
    }).compileComponents();
  });

--- a/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/unsecured-websites-report.component.spec.ts
@ -86,6 +86,8 @@ describe("UnsecuredWebsitesReportComponent", () => {
        },
      ],
      schemas: [],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
    }).compileComponents();
  });

--- a/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.spec.ts
+++ b/apps/web/src/app/tools/reports/pages/weak-passwords-report.component.spec.ts
@ -85,6 +85,8 @@ describe("WeakPasswordsReportComponent", () => {
        },
      ],
      schemas: [],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownElements: false,
    }).compileComponents();
  });

--- a/apps/web/test.setup.ts
+++ b/apps/web/test.setup.ts
@ -1,4 +1,4 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/apps/web/tsconfig.json
+++ b/apps/web/tsconfig.json
@ -26,6 +26,7 @@
      "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../../libs/tools/card/src"],
      "@bitwarden/ui-common": ["../../libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../../libs/ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": [
        "../../libs/tools/export/vault-export/vault-export-core/src"
      ],
--- a/bitwarden_license/bit-common/test.setup.ts
+++ b/bitwarden_license/bit-common/test.setup.ts
@ -1 +1 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";
--- a/bitwarden_license/bit-common/tsconfig.json
+++ b/bitwarden_license/bit-common/tsconfig.json
@ -22,6 +22,7 @@
      "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../../libs/tools/card/src"],
      "@bitwarden/ui-common": ["../../libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../../libs/ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": [
        "../../libs/tools/export/vault-export/vault-export-core/src"
      ],
--- a/bitwarden_license/bit-web/tsconfig.json
+++ b/bitwarden_license/bit-web/tsconfig.json
@ -27,6 +27,7 @@
      "@bitwarden/key-management-ui": ["../../libs/key-management-ui/src"],
      "@bitwarden/platform": ["../../libs/platform/src"],
      "@bitwarden/ui-common": ["../../libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../../libs/ui/common/src/setup-jest"],
      "@bitwarden/send-ui": ["../../libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../../libs/tools/card/src"],
      "@bitwarden/vault": ["../../libs/vault/src"],
--- a/libs/admin-console/test.setup.ts
+++ b/libs/admin-console/test.setup.ts
@ -1,7 +1,7 @@
 import { webcrypto } from "crypto";

 import { addCustomMatchers } from "@bitwarden/common/spec";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 addCustomMatchers();

--- a/libs/angular/test.setup.ts
+++ b/libs/angular/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/auth/test.setup.ts
+++ b/libs/auth/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/billing/test.setup.ts
+++ b/libs/billing/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/components/test.setup.ts
+++ b/libs/components/test.setup.ts
@ -1 +1 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";
--- a/libs/components/tsconfig.json
+++ b/libs/components/tsconfig.json
@ -21,7 +21,8 @@
    "paths": {
      "@bitwarden/common/*": ["../common/src/*"],
      "@bitwarden/platform": ["../platform/src"],
-      "@bitwarden/ui-common": ["../ui/common/src"]
+      "@bitwarden/ui-common": ["../ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../ui/common/src/setup-jest"]
    },
    "plugins": [
      {
--- a/libs/key-management-ui/test.setup.ts
+++ b/libs/key-management-ui/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/key-management/test.setup.ts
+++ b/libs/key-management/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/platform/test.setup.ts
+++ b/libs/platform/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/libs/shared/tsconfig.spec.json
+++ b/libs/shared/tsconfig.spec.json
@ -24,6 +24,7 @@
      "@bitwarden/send-ui": ["../tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["../tools/card/src"],
      "@bitwarden/ui-common": ["../ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["../ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": ["../tools/export/vault-export/vault-export-core/src"],
      "@bitwarden/vault-export-ui": ["../tools/export/vault-export/vault-export-ui/src"],
      "@bitwarden/vault": ["../vault/src"]
--- a/libs/tools/card/test.setup.ts
+++ b/libs/tools/card/test.setup.ts
@ -1 +1 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";
--- a/libs/tools/send/send-ui/src/send-list-filters/send-list-filters.component.spec.ts
+++ b/libs/tools/send/send-ui/src/send-list-filters/send-list-filters.component.spec.ts
@ -51,6 +51,8 @@ describe("SendListFiltersComponent", () => {
        { provide: BillingAccountProfileStateService, useValue: billingAccountProfileStateService },
        { provide: AccountService, useValue: accountService },
      ],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownProperties: false,
    }).compileComponents();

    fixture = TestBed.createComponent(SendListFiltersComponent);
--- a/libs/tools/send/send-ui/test.setup.ts
+++ b/libs/tools/send/send-ui/test.setup.ts
@ -1 +1 @@
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";
--- a/libs/ui/common/package.json
+++ b/libs/ui/common/package.json
@ -11,5 +11,13 @@
    "type": "git",
    "url": "https://github.com/bitwarden/clients"
  },
-  "license": "GPL-3.0"
+  "license": "GPL-3.0",
+  "exports": {
+    ".": {
+      "import": "./src/index.ts"
+    },
+    "./setup-jest": {
+      "import": "./src/setup-jest.ts"
+    }
+  }
 }
--- a/libs/ui/common/src/setup-jest.ts
+++ b/libs/ui/common/src/setup-jest.ts
@ -0,0 +1,12 @@
+import "jest-preset-angular/setup-jest";
+import { getTestBed } from "@angular/core/testing";
+import {
+  BrowserDynamicTestingModule,
+  platformBrowserDynamicTesting,
+} from "@angular/platform-browser-dynamic/testing";
+
+getTestBed().resetTestEnvironment();
+getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
+  errorOnUnknownElements: true,
+  errorOnUnknownProperties: true,
+});
--- a/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.spec.ts
+++ b/libs/vault/src/cipher-form/components/cipher-generator/cipher-form-generator.component.spec.ts
@ -32,6 +32,8 @@ describe("CipherFormGeneratorComponent", () => {
    await TestBed.configureTestingModule({
      imports: [CipherFormGeneratorComponent],
      providers: [{ provide: I18nService, useValue: { t: (key: string) => key } }],
+      // FIXME(PM-18598): Replace unknownElements and unknownProperties with actual imports
+      errorOnUnknownProperties: false,
    })
      .overrideComponent(CipherFormGeneratorComponent, {
        remove: { imports: [GeneratorModule] },
--- a/libs/vault/test.setup.ts
+++ b/libs/vault/test.setup.ts
@ -1,5 +1,5 @@
 import { webcrypto } from "crypto";
-import "jest-preset-angular/setup-jest";
+import "@bitwarden/ui-common/setup-jest";

 Object.defineProperty(window, "CSS", { value: null });
 Object.defineProperty(window, "getComputedStyle", {
--- a/tsconfig.json
+++ b/tsconfig.json
@ -38,6 +38,7 @@
      "@bitwarden/send-ui": ["./libs/tools/send/send-ui/src"],
      "@bitwarden/tools-card": ["./libs/tools/card/src"],
      "@bitwarden/ui-common": ["./libs/ui/common/src"],
+      "@bitwarden/ui-common/setup-jest": ["./libs/ui/common/src/setup-jest"],
      "@bitwarden/vault-export-core": ["./libs/tools/export/vault-export/vault-export-core/src"],
      "@bitwarden/vault-export-ui": ["./libs/tools/export/vault-export/vault-export-ui/src"],
      "@bitwarden/vault": ["./libs/vault/src"],