Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-22 11:45:59 +01:00
Code Issues Projects Releases Wiki Activity

Reports remove unneeded dependency on stateService (#4426)

Browse Source
This commit is contained in:
Daniel James Smith 2023-01-11 17:33:00 +01:00 committed by GitHub
parent fa13cab220
commit d138cb90ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 8 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
apps/web/src/app/organizations/tools/exposed-passwords-report.component.ts
View File

@ -7,7 +7,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { Cipher } from "@bitwarden/common/models/domain/cipher";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -27,19 +26,11 @@ export class ExposedPasswordsReportComponent extends BaseExposedPasswordsReportC
auditService: AuditService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
private organizationService: OrganizationService,
private route: ActivatedRoute,
passwordRepromptService: PasswordRepromptService
) {
super(
cipherService,
auditService,
modalService,
messagingService,
stateService,
passwordRepromptService
);
super(cipherService, auditService, modalService, messagingService, passwordRepromptService);
}
ngOnInit() {

11
apps/web/src/app/organizations/tools/inactive-two-factor-report.component.ts
View File

@ -7,7 +7,6 @@ import { LogService } from "@bitwarden/common/abstractions/log.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
// eslint-disable-next-line no-restricted-imports
@ -23,20 +22,12 @@ export class InactiveTwoFactorReportComponent extends BaseInactiveTwoFactorRepor
cipherService: CipherService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute,
logService: LogService,
passwordRepromptService: PasswordRepromptService,
private organizationService: OrganizationService
) {
super(
cipherService,
modalService,
messagingService,
stateService,
logService,
passwordRepromptService
);
super(cipherService, modalService, messagingService, logService, passwordRepromptService);
}
async ngOnInit() {

4
apps/web/src/app/organizations/tools/unsecured-websites-report.component.ts
View File

@ -6,7 +6,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
// eslint-disable-next-line no-restricted-imports
@ -22,12 +21,11 @@ export class UnsecuredWebsitesReportComponent extends BaseUnsecuredWebsitesRepor
cipherService: CipherService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute,
private organizationService: OrganizationService,
passwordRepromptService: PasswordRepromptService
) {
super(cipherService, modalService, messagingService, stateService, passwordRepromptService);
super(cipherService, modalService, messagingService, passwordRepromptService);
}
async ngOnInit() {

3
apps/web/src/app/organizations/tools/weak-passwords-report.component.ts
View File

@ -7,7 +7,6 @@ import { MessagingService } from "@bitwarden/common/abstractions/messaging.servi
import { OrganizationService } from "@bitwarden/common/abstractions/organization/organization.service.abstraction";
import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { Cipher } from "@bitwarden/common/models/domain/cipher";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -27,7 +26,6 @@ export class WeakPasswordsReportComponent extends BaseWeakPasswordsReportCompone
passwordGenerationService: PasswordGenerationService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
private route: ActivatedRoute,
private organizationService: OrganizationService,
passwordRepromptService: PasswordRepromptService
@ -37,7 +35,6 @@ export class WeakPasswordsReportComponent extends BaseWeakPasswordsReportCompone
passwordGenerationService,
modalService,
messagingService,
stateService,
passwordRepromptService
);
}

2
apps/web/src/app/reports/pages/cipher-report.component.ts
View File

@ -3,7 +3,6 @@ import { Directive, ViewChild, ViewContainerRef } from "@angular/core";
import { ModalService } from "@bitwarden/angular/services/modal.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherRepromptType } from "@bitwarden/common/enums/cipherRepromptType";
import { Organization } from "@bitwarden/common/models/domain/organization";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -25,7 +24,6 @@ export class CipherReportComponent {
private modalService: ModalService,
protected messagingService: MessagingService,
public requiresPaid: boolean,
private stateService: StateService,
protected passwordRepromptService: PasswordRepromptService
) {}

4
apps/web/src/app/reports/pages/exposed-passwords-report.component.ts
View File

@ -5,7 +5,6 @@ import { AuditService } from "@bitwarden/common/abstractions/audit.service";
import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -23,10 +22,9 @@ export class ExposedPasswordsReportComponent extends CipherReportComponent imple
protected auditService: AuditService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService
) {
super(modalService, messagingService, true, stateService, passwordRepromptService);
super(modalService, messagingService, true, passwordRepromptService);
}
ngOnInit() {

4
apps/web/src/app/reports/pages/inactive-two-factor-report.component.ts
View File

@ -5,7 +5,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { LogService } from "@bitwarden/common/abstractions/log.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType";
import { Utils } from "@bitwarden/common/misc/utils";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -24,11 +23,10 @@ export class InactiveTwoFactorReportComponent extends CipherReportComponent impl
protected cipherService: CipherService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
private logService: LogService,
passwordRepromptService: PasswordRepromptService
) {
super(modalService, messagingService, true, stateService, passwordRepromptService);
super(modalService, messagingService, true, passwordRepromptService);
}
async ngOnInit() {

2
apps/web/src/app/reports/pages/reused-passwords-report.component.ts
View File

@ -24,7 +24,7 @@ export class ReusedPasswordsReportComponent extends CipherReportComponent implem
stateService: StateService,
passwordRepromptService: PasswordRepromptService
) {
super(modalService, messagingService, true, stateService, passwordRepromptService);
super(modalService, messagingService, true, passwordRepromptService);
}
async ngOnInit() {

4
apps/web/src/app/reports/pages/unsecured-websites-report.component.ts
View File

@ -4,7 +4,6 @@ import { ModalService } from "@bitwarden/angular/services/modal.service";
import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
@ -19,10 +18,9 @@ export class UnsecuredWebsitesReportComponent extends CipherReportComponent impl
protected cipherService: CipherService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService
) {
super(modalService, messagingService, true, stateService, passwordRepromptService);
super(modalService, messagingService, true, passwordRepromptService);
}
async ngOnInit() {

4
apps/web/src/app/reports/pages/weak-passwords-report.component.ts
View File

@ -5,7 +5,6 @@ import { CipherService } from "@bitwarden/common/abstractions/cipher.service";
import { MessagingService } from "@bitwarden/common/abstractions/messaging.service";
import { PasswordGenerationService } from "@bitwarden/common/abstractions/passwordGeneration.service";
import { PasswordRepromptService } from "@bitwarden/common/abstractions/passwordReprompt.service";
import { StateService } from "@bitwarden/common/abstractions/state.service";
import { CipherType } from "@bitwarden/common/enums/cipherType";
import { CipherView } from "@bitwarden/common/models/view/cipher.view";
import { BadgeTypes } from "@bitwarden/components";
@ -26,10 +25,9 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
protected passwordGenerationService: PasswordGenerationService,
modalService: ModalService,
messagingService: MessagingService,
stateService: StateService,
passwordRepromptService: PasswordRepromptService
) {
super(modalService, messagingService, true, stateService, passwordRepromptService);
super(modalService, messagingService, true, passwordRepromptService);
}
async ngOnInit() {