Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-22 16:29:09 +01:00
Code Issues Projects Releases Wiki Activity

[PM-8013] CLI MAC failure logs - update secureStorageService deps (#10935)

Browse Source
This commit is contained in:
rr-bw 2024-09-09 07:05:04 -07:00 committed by GitHub
parent e954621761
commit d189b4e294
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/cli/src/service-container/service-container.ts
View File

@ -285,7 +285,13 @@ export class ServiceContainer {
this.secureStorageService = new NodeEnvSecureStorageService( this.secureStorageService = new NodeEnvSecureStorageService(
this.storageService, this.storageService,
this.logService, this.logService,
this.encryptService, // MAC failures for secure storage are being logged for customers today and
// they occur when users unlock / login and refresh a session key but don't
// export it into their environment (e.g. BW_SESSION_KEY). This leaves a stale
// BW_SESSION key in the env which is attempted to be used to decrypt the auto
// unlock user key which obviously fails. So, to resolve this, we will not log
// MAC failures for secure storage.
new EncryptServiceImplementation(this.cryptoFunctionService, this.logService, false),
); );
this.memoryStorageService = new MemoryStorageService(); this.memoryStorageService = new MemoryStorageService();