Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-24 12:06:15 +01:00
Code Issues Projects Releases Wiki Activity

null checks

Browse Source
This commit is contained in:
Kyle Spearrin 2019-04-15 21:15:35 -04:00
parent 05dde1051c
commit d3a2dfe2e8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/cipher.service.ts
View File

@ -112,8 +112,8 @@ export class CipherService implements CipherServiceAbstraction {
const hiddenFields = model.fields == null ? [] : const hiddenFields = model.fields == null ? [] :
model.fields.filter((f) => f.type === FieldType.Hidden && f.name != null && f.name !== ''); model.fields.filter((f) => f.type === FieldType.Hidden && f.name != null && f.name !== '');
existingHiddenFields.forEach((ef) => { existingHiddenFields.forEach((ef) => {
const matchedField = hiddenFields.filter((f) => f.name === ef.name); const matchedField = hiddenFields.find((f) => f.name === ef.name);
if (matchedField.length === 0 || matchedField[0].value !== ef.value) { if (matchedField == null || matchedField.value !== ef.value) {
const ph = new PasswordHistoryView(); const ph = new PasswordHistoryView();
ph.password = ef.name + ': ' + ef.value; ph.password = ef.name + ': ' + ef.value;
ph.lastUsedDate = new Date(); ph.lastUsedDate = new Date();
@ -320,7 +320,7 @@ export class CipherService implements CipherServiceAbstraction {
} }
async getAllDecryptedForUrl(url: string, includeOtherTypes?: CipherType[]): Promise<CipherView[]> { async getAllDecryptedForUrl(url: string, includeOtherTypes?: CipherType[]): Promise<CipherView[]> {
if (url == null && !includeOtherTypes) { if (url == null && includeOtherTypes == null) {
return Promise.resolve([]); return Promise.resolve([]);
} }
@ -351,7 +351,7 @@ export class CipherService implements CipherServiceAbstraction {
} }
return ciphers.filter((cipher) => { return ciphers.filter((cipher) => {
if (includeOtherTypes && includeOtherTypes.indexOf(cipher.type) > -1) { if (includeOtherTypes != null && includeOtherTypes.indexOf(cipher.type) > -1) {
return true; return true;
} }