1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-10-06 05:28:51 +02:00

fix callbacks for user service methods

This commit is contained in:
Kyle Spearrin 2017-11-03 15:40:19 -04:00
parent 2211c569d7
commit e3dea4084f
6 changed files with 32 additions and 31 deletions

View File

@ -436,19 +436,21 @@ var bg_isBackground = true,
return;
}
bg_userService.isAuthenticated(function (isAuthenticated) {
bg_cryptoService.getKey().then(function (key) {
var suffix = '';
if (!isAuthenticated) {
suffix = '_gray';
}
else if (!key) {
suffix = '_locked';
}
var isAuthenticated;
bg_userService.isAuthenticated().then(function (theIsAuthenticated) {
isAuthenticated = theIsAuthenticated;
return bg_cryptoService.getKey();
}).then(function (key) {
var suffix = '';
if (!isAuthenticated) {
suffix = '_gray';
}
else if (!key) {
suffix = '_locked';
}
actionSetIcon(chrome.browserAction, suffix);
actionSetIcon(bg_sidebarAction, suffix);
});
actionSetIcon(chrome.browserAction, suffix);
actionSetIcon(bg_sidebarAction, suffix);
});
function actionSetIcon(theAction, suffix) {

View File

@ -23,20 +23,22 @@ angular
var userService = $injector.get('userService');
var cryptoService = $injector.get('cryptoService');
cryptoService.getKey().then(function (key) {
userService.isAuthenticated(function (isAuthenticated) {
if (isAuthenticated) {
if (!key) {
$state.go('lock');
}
else {
$state.go('tabs.current');
}
var key;
cryptoService.getKey().then(function (theKey) {
key = theKey;
return userService.isAuthenticated();
}).then(function (isAuthenticated) {
if (isAuthenticated) {
if (!key) {
$state.go('lock');
}
else {
$state.go('home');
$state.go('tabs.current');
}
});
}
else {
$state.go('home');
}
});
});
@ -269,7 +271,7 @@ angular
stateService.init();
$transitions.onStart({}, function(trans) {
$transitions.onStart({}, function (trans) {
const $state = trans.router.stateService;
const toState = trans.to();
@ -284,7 +286,7 @@ angular
return;
}
userService.isAuthenticated((isAuthenticated) => {
userService.isAuthenticated().then((isAuthenticated) => {
if (isAuthenticated) {
var obj = {};
obj[constantsService.lastActiveKey] = (new Date()).getTime();

View File

@ -24,7 +24,7 @@ angular
};
$scope.submit = function () {
userService.getEmail(function (email) {
userService.getEmail().then(function (email) {
var key = cryptoService.makeKey($scope.masterPassword, email);
var keyHash;
cryptoService.hashPassword($scope.masterPassword, key).then(function (theKeyHash) {

View File

@ -22,7 +22,7 @@ angular
function checkPassword() {
var deferred = $q.defer();
userService.getEmail(function (email) {
userService.getEmail().then(function (email) {
var key = cryptoService.makeKey($scope.masterPassword, email);
var keyHash;
cryptoService.hashPassword($scope.masterPassword, key).then(function (theKeyHash) {

View File

@ -21,7 +21,7 @@ function initSyncService() {
var self = this;
self.syncStarted();
self.userService.isAuthenticated(function (isAuthenticated) {
self.userService.isAuthenticated().then(function (isAuthenticated) {
if (!isAuthenticated) {
self.syncCompleted(false);
callback(false);

View File

@ -31,7 +31,6 @@ export default class UserService {
return UtilsService.saveObjToStorage(Keys.stamp, stamp);
}
// TODO: callbacks
async getUserId(): Promise<string> {
if (this.userId != null) {
return this.userId;
@ -41,7 +40,6 @@ export default class UserService {
return this.userId;
}
// TODO: callbacks
async getEmail(): Promise<string> {
if (this.email != null) {
return this.email;
@ -70,7 +68,6 @@ export default class UserService {
this.userId = this.email = this.stamp = null;
}
// TODO: fix callbacks
async isAuthenticated(): Promise<boolean> {
const token = await this.tokenService.getToken();
if (token == null) {