Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-11 10:10:25 +01:00
Code Issues Projects Releases Wiki Activity

Handle detached table cells in autofill service (#10880)

Browse Source 
Fixes errors and high CPU usage / browser lockup on offending webpages.

HTMLTableCellElement.cellIndex will be -1 if the cell is not part of any row, which will cause getTextContentFromElement to fail since it will not receive a valid sibling cell.
This commit is contained in:
md-5 2024-09-07 07:22:43 +10:00 committed by GitHub
parent 4e1912e24e
commit e3fc4547ae
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@ -644,6 +644,10 @@ export class CollectAutofillContentService implements CollectAutofillContentServ
} }
const tableDataElementIndex = tableDataElement.cellIndex; const tableDataElementIndex = tableDataElement.cellIndex;
if (tableDataElementIndex < 0) {
return null;
}
const parentSiblingTableRowElement = tableDataElement.closest("tr") const parentSiblingTableRowElement = tableDataElement.closest("tr")
?.previousElementSibling as HTMLTableRowElement; ?.previousElementSibling as HTMLTableRowElement;