From f06c017e42f464f5f74242ce24118d50b7118810 Mon Sep 17 00:00:00 2001
From: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
Date: Thu, 4 May 2023 09:17:56 -0500
Subject: [PATCH] =?UTF-8?q?[PM-1176]=20Hovering=20over=20the=20`Learn=20Mo?=
 =?UTF-8?q?re=20about=20auto-fill`=20link=20in=20the=20=E2=80=A6=20(#5300)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* [PM-1176] Hovering over the `Learn More about auto-fill` link in the browser extension does not change the cursor

* [PM-1176] Modifying how the anchor element is formatted by prettier

* [PM-1176] Adding translation methodology to the aria-label "opens in a new window" value
---
 apps/browser/src/_locales/en/messages.json           |  3 +++
 .../src/popup/settings/autofill.component.html       | 12 +++++++++++-
 .../browser/src/popup/settings/autofill.component.ts |  4 ----
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json
index 9a97e79cbe..1b8c6315be 100644
--- a/apps/browser/src/_locales/en/messages.json
+++ b/apps/browser/src/_locales/en/messages.json
@@ -2202,5 +2202,8 @@
         "example": "CTRL+Shift+L"
       }
     }
+  },
+  "opensInANewWindow": {
+    "message": "Opens in a new window"
   }
 }
diff --git a/apps/browser/src/popup/settings/autofill.component.html b/apps/browser/src/popup/settings/autofill.component.html
index a3ff193671..21ad160d06 100644
--- a/apps/browser/src/popup/settings/autofill.component.html
+++ b/apps/browser/src/popup/settings/autofill.component.html
@@ -28,7 +28,17 @@
       {{ "enableAutoFillOnPageLoadDesc" | i18n }}
       <b>{{ "warning" | i18n }}</b
       >: {{ "experimentalFeature" | i18n }}
-      <a (click)="AboutAutofill()">{{ "learnMoreAboutAutofill" | i18n }}</a>
+      <a
+        href="https://bitwarden.com/help/auto-fill-browser/"
+        target="_blank"
+        rel="noopener noreferrer"
+      >
+        {{ "learnMoreAboutAutofill" | i18n }}.
+        <i
+          [attr.aria-label]="'opensInANewWindow' | i18n"
+          class="bwi bwi-external-link bwi-sm bwi-fw"
+        ></i>
+      </a>
     </div>
   </div>
   <div class="box">
diff --git a/apps/browser/src/popup/settings/autofill.component.ts b/apps/browser/src/popup/settings/autofill.component.ts
index 9e134c43a8..05975e6092 100644
--- a/apps/browser/src/popup/settings/autofill.component.ts
+++ b/apps/browser/src/popup/settings/autofill.component.ts
@@ -63,10 +63,6 @@ export class AutofillComponent implements OnInit {
     await this.stateService.setDefaultUriMatch(this.defaultUriMatch);
   }
 
-  AboutAutofill() {
-    BrowserApi.createNewTab("https://bitwarden.com/help/auto-fill-browser/");
-  }
-
   private async setAutofillKeyboardHelperText(command: string) {
     if (command) {
       this.autofillKeyboardHelperText = this.i18nService.t("autofillShortcutText", command);