From f07840339eef589106566ae0026b2f34f35b6c9a Mon Sep 17 00:00:00 2001 From: Robyn MacCallum Date: Mon, 20 May 2024 10:37:52 -0400 Subject: [PATCH] Add autofill as codeowners to ddg files (#9268) * Add autofill as codeowners to ddg files * Add comments --- .github/CODEOWNERS | 4 ++++ apps/desktop/src/services/native-message-handler.service.ts | 1 + apps/desktop/src/services/native-messaging.service.ts | 1 + 3 files changed, 6 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index aba7d4e0e0..2ec9d3b1b4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -87,6 +87,10 @@ apps/web/src/translation-constants.ts @bitwarden/team-platform-dev apps/browser/src/autofill @bitwarden/team-autofill-dev apps/desktop/src/autofill @bitwarden/team-autofill-dev libs/common/src/autofill @bitwarden/team-autofill-dev +# DuckDuckGo integration +apps/desktop/native-messaging-test-runner @bitwarden/team-autofill-dev +apps/desktop/src/services/native-message-handler.service.ts @bitwarden/team-autofill-dev +apps/desktop/src/services/native-messaging.service.ts @bitwarden/team-autofill-dev ## Component Library ## .storybook @bitwarden/team-component-library diff --git a/apps/desktop/src/services/native-message-handler.service.ts b/apps/desktop/src/services/native-message-handler.service.ts index ebe1ee6248..c50593768d 100644 --- a/apps/desktop/src/services/native-message-handler.service.ts +++ b/apps/desktop/src/services/native-message-handler.service.ts @@ -24,6 +24,7 @@ import { EncryptedMessageHandlerService } from "./encrypted-message-handler.serv const EncryptionAlgorithm = "sha1"; +// This service handles messages using the protocol created for the DuckDuckGo integration. @Injectable() export class NativeMessageHandlerService { private ddgSharedSecret: SymmetricCryptoKey; diff --git a/apps/desktop/src/services/native-messaging.service.ts b/apps/desktop/src/services/native-messaging.service.ts index 06881b7463..9abd3b635a 100644 --- a/apps/desktop/src/services/native-messaging.service.ts +++ b/apps/desktop/src/services/native-messaging.service.ts @@ -56,6 +56,7 @@ export class NativeMessagingService { private async messageHandler(msg: LegacyMessageWrapper | Message) { const outerMessage = msg as Message; if (outerMessage.version) { + // If there is a version, it is a using the protocol created for the DuckDuckGo integration await this.nativeMessageHandler.handleMessage(outerMessage); return; }