Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-27 12:36:14 +01:00
Code Issues Projects Releases Wiki Activity

Merge branch 'master' into use-lock-guard

Browse Source
This commit is contained in:
Thomas Rittson 2021-06-09 07:39:45 +10:00
commit f4d792aa9d
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/_locales/en/messages.json
View File

@ -803,7 +803,10 @@
"message": "Insert your security key into your computer's USB port. If it has a button, touch it." "message": "Insert your security key into your computer's USB port. If it has a button, touch it."
}, },
"webAuthnNewTab": { "webAuthnNewTab": {
"message": "Continue the WebAuthn 2FA verification in the new tab." "message": "To start the WebAuthn 2FA verification. Click the button below to open a new tab and follow the instructions provided in the new tab."
},
"webAuthnNewTabOpen": {
"message": "Open new tab"
}, },
"webAuthnAuthenticate": { "webAuthnAuthenticate": {
"message": "Authenticate WebAuthn" "message": "Authenticate WebAuthn"

1
src/popup/accounts/two-factor.component.html
View File

@ -73,6 +73,7 @@
<ng-container *ngIf="selectedProviderType === providerType.WebAuthn && webAuthnNewTab"> <ng-container *ngIf="selectedProviderType === providerType.WebAuthn && webAuthnNewTab">
<div class="content text-center" *ngIf="webAuthnNewTab"> <div class="content text-center" *ngIf="webAuthnNewTab">
<p class="text-center">{{'webAuthnNewTab' | i18n}}</p> <p class="text-center">{{'webAuthnNewTab' | i18n}}</p>
<button class="btn primary block" (click)="authWebAuthn()" appStopClick>{{'webAuthnNewTabOpen' | i18n}}</button>
</div> </div>
</ng-container> </ng-container>
<ng-container *ngIf="selectedProviderType === providerType.Duo || <ng-container *ngIf="selectedProviderType === providerType.Duo ||

8
src/popup/services/services.module.ts
View File

@ -67,12 +67,14 @@ function getBgService<T>(service: string) {
}; };
} }
const isPrivateMode = BrowserApi.getBackgroundPage() == null;
const stateService = new StateService(); const stateService = new StateService();
const messagingService = new BrowserMessagingService(); const messagingService = new BrowserMessagingService();
const searchService = new PopupSearchService(getBgService<SearchService>('searchService')(), const searchService = isPrivateMode ? null : new PopupSearchService(getBgService<SearchService>('searchService')(),
getBgService<CipherService>('cipherService')(), getBgService<ConsoleLogService>('consoleLogService')(), getBgService<CipherService>('cipherService')(), getBgService<ConsoleLogService>('consoleLogService')(),
getBgService<I18nService>('i18nService')()); getBgService<I18nService>('i18nService')());
const passwordRepromptService = new PasswordRepromptService(getBgService<I18nService>('i18nService')(), const passwordRepromptService = isPrivateMode ? null : new PasswordRepromptService(getBgService<I18nService>('i18nService')(),
getBgService<CryptoService>('cryptoService')(), getBgService<PlatformUtilsService>('platformUtilsService')()); getBgService<CryptoService>('cryptoService')(), getBgService<PlatformUtilsService>('platformUtilsService')());
export function initFactory(platformUtilsService: PlatformUtilsService, i18nService: I18nService, storageService: StorageService, export function initFactory(platformUtilsService: PlatformUtilsService, i18nService: I18nService, storageService: StorageService,
@ -86,7 +88,7 @@ export function initFactory(platformUtilsService: PlatformUtilsService, i18nServ
window.document.body.classList.add('body-sm'); window.document.body.classList.add('body-sm');
} }
if (BrowserApi.getBackgroundPage() != null) { if (!isPrivateMode) {
await stateService.save(ConstantsService.disableFaviconKey, await stateService.save(ConstantsService.disableFaviconKey,
await storageService.get<boolean>(ConstantsService.disableFaviconKey)); await storageService.get<boolean>(ConstantsService.disableFaviconKey));