mirror of
https://github.com/bitwarden/browser.git
synced 2024-10-02 04:48:57 +02:00
[PM-6983] Disable hardware acceleration for bad GPUs (#8427)
* Disable hardware acceleration on mac app store when amd switchable is true * Only apply fix on iMacs
This commit is contained in:
parent
ad588f15bf
commit
f70639d792
@ -45,6 +45,7 @@ import { ElectronStateService } from "./platform/services/electron-state.service
|
|||||||
import { ElectronStorageService } from "./platform/services/electron-storage.service";
|
import { ElectronStorageService } from "./platform/services/electron-storage.service";
|
||||||
import { I18nMainService } from "./platform/services/i18n.main.service";
|
import { I18nMainService } from "./platform/services/i18n.main.service";
|
||||||
import { ElectronMainMessagingService } from "./services/electron-main-messaging.service";
|
import { ElectronMainMessagingService } from "./services/electron-main-messaging.service";
|
||||||
|
import { isMacAppStore } from "./utils";
|
||||||
|
|
||||||
export class Main {
|
export class Main {
|
||||||
logService: ElectronLogMainService;
|
logService: ElectronLogMainService;
|
||||||
@ -322,6 +323,19 @@ export class Main {
|
|||||||
if (!hardwareAcceleration) {
|
if (!hardwareAcceleration) {
|
||||||
this.logService.warning("Hardware acceleration is disabled");
|
this.logService.warning("Hardware acceleration is disabled");
|
||||||
app.disableHardwareAcceleration();
|
app.disableHardwareAcceleration();
|
||||||
|
} else if (isMacAppStore()) {
|
||||||
|
// We disable hardware acceleration on Mac App Store builds for iMacs with amd switchable GPUs due to:
|
||||||
|
// https://github.com/electron/electron/issues/41346
|
||||||
|
const gpuInfo: any = await app.getGPUInfo("basic");
|
||||||
|
const badGpu = gpuInfo?.auxAttributes?.amdSwitchable ?? false;
|
||||||
|
const isImac = gpuInfo?.machineModelName == "iMac";
|
||||||
|
|
||||||
|
if (isImac && badGpu) {
|
||||||
|
this.logService.warning(
|
||||||
|
"Bad GPU detected, hardware acceleration is disabled for compatibility",
|
||||||
|
);
|
||||||
|
app.disableHardwareAcceleration();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user