From fb1a294c9781c641e25fa20799f2007e40ff4b65 Mon Sep 17 00:00:00 2001
From: Nick Krantz <125900171+nick-livefront@users.noreply.github.com>
Date: Fri, 6 Sep 2024 08:49:46 -0500
Subject: [PATCH] update aria label of the character count toggle (#10915)

---
 apps/browser/src/_locales/en/messages.json               | 7 +++++--
 apps/web/src/locales/en/messages.json                    | 9 ++++++---
 .../login-credentials-view.component.html                | 4 ++--
 3 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/apps/browser/src/_locales/en/messages.json b/apps/browser/src/_locales/en/messages.json
index 3aa1ac097c..32215013ac 100644
--- a/apps/browser/src/_locales/en/messages.json
+++ b/apps/browser/src/_locales/en/messages.json
@@ -4300,8 +4300,11 @@
   "enterprisePolicyRequirementsApplied": {
     "message": "Enterprise policy requirements have been applied to this setting"
   },
-  "additionalContentAvailable": {
-    "message": "Additional content is available"
+  "showCharacterCount": {
+    "message": "Show character count"
+  },
+  "hideCharacterCount": {
+    "message": "Hide character count"
   },
   "itemsInTrash": {
     "message": "Items in trash"
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 61ea5d7bd8..7a7785469b 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -71,7 +71,7 @@
   },
   "itemHistory": {
     "message": "Item history"
-  },  
+  },
   "authenticatorKey": {
     "message": "Authenticator key"
   },
@@ -9050,8 +9050,11 @@
     "message": "Public API",
     "description": "The text, 'API', is an acronymn and should not be translated."
   },
-  "additionalContentAvailable": {
-    "message": "Additional content is available"
+  "showCharacterCount": {
+    "message": "Show character count"
+  },
+  "hideCharacterCount": {
+    "message": "Hide character count"
   },
   "editAccess": {
     "message": "Edit access"
diff --git a/libs/vault/src/cipher-view/login-credentials/login-credentials-view.component.html b/libs/vault/src/cipher-view/login-credentials/login-credentials-view.component.html
index 17d02658c4..f2fbb6a042 100644
--- a/libs/vault/src/cipher-view/login-credentials/login-credentials-view.component.html
+++ b/libs/vault/src/cipher-view/login-credentials/login-credentials-view.component.html
@@ -51,10 +51,10 @@
         bitSuffix
         type="button"
         data-testid="toggle-password-count"
-        [appA11yTitle]="'toggleCharacterCount' | i18n"
+        [appA11yTitle]="(showPasswordCount ? 'hideCharacterCount' : 'showCharacterCount') | i18n"
+        [attr.aria-expanded]="showPasswordCount"
         appStopClick
         (click)="togglePasswordCount()"
-        [attr.aria-label]="'additionalContentAvailable' | i18n"
       ></button>
       <button
         *ngIf="cipher.viewPassword"