1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-29 17:38:04 +01:00
Commit Graph

110 Commits

Author SHA1 Message Date
SmithThe4th
0db179e974
[PM-739] Using a space at the beginning of otpauth:// generate a wrong OTP ()
* Trimmed tariling whitespace from totp field

* Trimmed tariling whitespace from totp field

* Fix failing test
2024-09-23 16:45:53 -04:00
Shane Melton
36a9228523
[PM-11391] Replace button tag with div for TOTP timer () 2024-09-20 06:56:21 -07:00
Nick Krantz
c13131acd1
remove border styles, allow for component library to style the icon button () 2024-09-20 08:45:44 -05:00
Shane Melton
4327fa21f6
[PM-11343] Browser Refresh - View dialog permissions in AC ()
* [PM-11343] Add param to conditionally disable the edit button

* [PM-11343] Cleanup router navigation and move query param handling to callers of the View dialog

* [PM-11343] Fix failing test

* [PM-11343] Fix missing router after merge

* [PM-11343] Add null checks in case the dialog result is undefined (due to closing via the ESC key)

* [PM-11343] Add support to provide a list of collections to the cipher view component

* [PM-11343] Add collections as an optional view cipher dialog parameter

* [PM-11343] Update the org vault to provide collections when opening the View cipher dialog

* [PM-11343] Fix import

* [PM-11343] Use [replaceUrl] for cipher items to avoid needing double back button
2024-09-19 10:43:28 -07:00
Alec Rippberger
6c1d74a4ce
[PM-11395] [Defect] View Login - TOTP premium badge does nothing when clicked ()
* Add MessagingService to LoginCredentialView component.

* Add comments.

* Add WIP PremiumUpgradeService

* Simplify web PremiumUpgradeServices into one service.

* Relocate service files.

* Add browser version of PremiumUpgradePromptService.

* Cleanup debug comments.

* Run prettier.

* rework promptForPremium to take organization id and add test.

* Add test for browser

* Rework imports to fix linter errors.

* Add Shane's reworked WebVaultPremiumUpgradePromptService.
2024-09-18 16:00:54 -05:00
Alec Rippberger
931f86c948
[PM- 9666] Implement edit item view individual vault ()
* Add initial vault cipher form for cipher edit.

* Add ability to add new cipher by type

* Add ability to save and clone cipher,

* Update canEditAllCiphers to take 1 argument.

* Add attachments button to add/edit dialog.

* Add semi-working attachment dialog.

* Add working attachment functionality.

* Remove debugging code.

* Add tests for new attachments dialog component.

* Add AddEditComponentV2 tests.

* Remove AddEditComponentV2 delete functionality.

* Remove unnecessary else statement.

* Launch password generation in new dialog when extension refresh enabled.

* Add tests for PasswordGeneratorComponent.

* Adjust password and attachments dialog sizes.

* run lint:fix

* Remove unnecessary form from button.

* Add missing provider in test.

* Remove password generation events.

* Add WebVaultGeneratorDialogComponent and WebCipherFormGenerationService

* Move and rename CipherFormQueryParams

* Use WebCipherFormGenerationService to launch password / user generation modals.

* Add WebVaultGeneratorDialogComponent tests.

* Remove unnecessary functionality and corresponding tests.

* Fix failing tests.

* Remove unused properties from AddEditComponentV2

* Pass CipherFormConfig to dialog.

* Clean up unused attachment dialog functionality.

* Update AddEdit cancel functionality to prevent navigating user.

* Make attachment dialog open a static method.

* Add addCipherV2 method and clean up tests.

* Remove changes to QueryParams.

* Add tests for WebCipherFormGenerationService

* Remove unused onCipherSaved method.

* Remove cipherSaved event.

* Remove unused password generator component

* Refactor to simplify editCipherId for extensionRefresh flag.

* Add additional comments to AddEditComponentV2.

* Simplify open vault generator dialog comment.

* Remove unused organizationService

* Remove unnecessary typecasting.

* Remove extensionRefreshEnabled and related.

* Remove slideIn animation

* Remove unused AddEditComponentV2 properties.

* Add back generic typing.

* Condesnse properties into single form config.

* Remove onDestroy and related code.

* Run prettier

* fix injection warning

* Handle cipher save.

* Redirect to vault on delete and make actions consistent.

* Update comment.
2024-09-18 12:48:47 -05:00
Shane Melton
99ba56785d
[PM-11393] Remove the need for TotpCaptureService in Autofill Options View component () 2024-09-17 13:15:11 -07:00
Nick Krantz
d68853a4a2
[PM-11131] Screen Reader Announcements for Copy ()
* add copy specific aria-labels for login ciphers

* add copy specific aria-labels for card ciphers

* add copy translations for identity to web translations
2024-09-17 13:23:15 -05:00
Alec Rippberger
651f1e586a
PM-11468: Add data-testids for View Item pages ()
* Add data test IDs for identity information.

* Add data test IDs for custom fields.
2024-09-16 17:01:38 -05:00
Nick Krantz
26f3dcfc66
add back events for browser refresh extension ()
- something went sideways in a merge
2024-09-16 14:02:20 -05:00
Nick Krantz
a31ecb18a1
[PM-11267] Extension Refresh Events ()
* add `Cipher_ClientViewed` event to browser refresh components

* add `Cipher_ClientToggledPasswordVisible` event to browser refresh components

* add `Cipher_ClientToggledHiddenFieldVisible` event to browser refresh components

* add `Cipher_ClientToggledCardCodeVisible` event to browser refresh components

* add `Cipher_ClientToggledCardNumberVisible` event to browser refresh components

* add `Cipher_ClientToggledTOTPSeedVisible` event to browser refresh components

* add `Cipher_ClientCopiedPassword` event to browser refresh components

* add events for copying cipher fields from the vault menu

* add `Cipher_ClientCopiedHiddenField` event to browser refresh components

* add mock for tests

* add missing `Cipher_ClientCopiedCardCode` event

* remove the need for separate fields input

* add organization id to event collection so events are collected

* update test

* add event collection service to cipher form stories
2024-09-12 14:47:23 -05:00
Victoria League
a0a0a7ae13
[CL-395] Add and use art colors in svgs () 2024-09-11 14:54:07 -04:00
Shane Melton
8e4dab5eba
[PM-10996] Remove restrict-provider-access feature flag () 2024-09-11 10:45:23 -07:00
Alec Rippberger
ee738ac36a
Update "linked" to use "cfTypeLinked" message. ()
Co-authored-by: Shane Melton <smelton@bitwarden.com>
2024-09-07 21:20:39 -05:00
Nick Krantz
fb1a294c97
update aria label of the character count toggle () 2024-09-06 08:49:46 -05:00
Nick Krantz
7dcfaf8271
add title for attachment name ()
- adds the ability for a user to see the attachment name while hovering over it
2024-09-05 14:41:39 -05:00
Alec Rippberger
fdd2c774c6
[PM-11339] [Defect] Owner information in Item details section needs spacing and alignment ()
* Add vault files to config.content array.

* Adjust unordered list spacing.
2024-09-04 15:45:23 -07:00
Jonathan Prusik
44f1fc156c
[PM-11458] Bugfix - If two digit year was entered for card, the expired card message shows if card is not expired ()
* normalize card expiry year before determining if it is expired

* add tests
2024-09-04 13:39:48 -04:00
Nick Krantz
72dab94216
remove brand from logic that determines if the card section should show () 2024-09-04 11:44:52 -05:00
Nick Krantz
3e9fb2009e
[PM-10934] Remove last form-field bottom border ()
* match API of new CL FormField component

* remove readonly border for additional options component

* remove readonly border for last autofill option

* remove readonly border for last custom-field form field

* remove readonly border for when collection,org or folder is available

* add `ReadOnlyCipherCardComponent` to handle readonly border

* remove readonly border for the last identity form field

* remove readonly border for the last card form field

* remove readonly border for the last login form field

* remove unneeded true value
2024-09-04 10:50:34 -05:00
Jonathan Prusik
5f2eecd7be
[PM-11350] Use shared expiration year normalization util function ()
* use shared expiration year normalization util function

* use shared exp year normalization in web and desktop client

* handle cases where input has leading zeroes

* add utils tests

* handle cases where input is all zeroes
2024-09-03 15:12:36 -04:00
Nick Krantz
1951b70fd1
implement bitLink for password history () 2024-09-03 10:25:10 -05:00
Jason Ng
d5cbc19187
PM-11428 Ensure TOTP background color is in sync with other view inputs () 2024-08-30 15:59:51 -04:00
SmithThe4th
5a73639946
[PM-8125] Move Trash to the Vault settings page ()
* created trash and trash container component

* added trash to vault settings

created observable to get deleted ciphers

* export icon

added locales

* remove edit and delete footver from trash view cipher

* Added helper text when viewing deleted ciphers

* prevent premature access of isDeleted from the cipher object

* simplified the condition to show the edit button

* return cipherView for deletedCiphers$ since that is what is used in the component

* changed section header to h6

* added routing animation

* Added restore to footer
2024-08-30 15:46:26 -04:00
Jason Ng
963e339e4f
PM-11429 Users with Except PW permissions will not get Copy Password Option Vault V2 () 2024-08-30 15:38:37 -04:00
Jason Ng
d9ff8b0944
PM-11427 Copy Totp Code without space () 2024-08-30 12:27:56 -04:00
Jason Ng
c1870a37c7
PM-10374 remove margin from collection in item details if no folder () 2024-08-29 17:45:17 -04:00
Jason Ng
2d753f2778
PM-11130 add aria labels to pw count and website launch in view v2 () 2024-08-29 17:44:53 -04:00
Jason Ng
e242d7d2d5
PM-11126 limit pw toggle and copy to viewPassword true () 2024-08-26 15:28:37 -04:00
Shane Melton
fbf9c5abfa
[PM-10993] Browser Refresh - Fix duplicate password generation emissions in Firefox ()
* [PM-10993] Avoid saving the generation options to state when toggling the password type

* [PM-10993] Fix tests
2024-08-26 12:05:22 -07:00
Shane Melton
9e093f88af
[PM-10247] Browser Refresh - Fix save credential banner ()
* [PM-10247] Prioritize initialValues when initiating the CipherForm child forms

* [PM-10247] Fetch the addEditCipherInfo when opening the cipher form in Browser and override any initialValues if present

* [PM-10247] Fix item details section tests

* [PM-10247] Add login details section test

* [PM-10247] Add autofill options tests

* [PM-10247] Undo webpack config change

* [PM-10247] Fix failing tests

* [PM-10247] Add additional tests for addEditCipherInfo
2024-08-26 12:03:47 -07:00
Jason Ng
2005d99056
PM-11118 adjust hover cursor styles for TOTP buttons () 2024-08-26 14:11:31 -04:00
Jason Ng
887d1924a3
PM-10982 add passkey field in login view. add testid for qa () 2024-08-22 16:38:41 -04:00
Jason Ng
83ed0442de
[PM-10980] Style defect updates to Login Credentials ()
* update login credentials to styling username, password, and pw count
2024-08-22 14:49:27 -04:00
Jason Ng
d2d49b254d
PM-10982 update autofill options to show different uri () 2024-08-22 12:59:53 -04:00
Jonathan Prusik
1fe6631c82
[BEEEP][PM-3876] - Warn users if a stored card has an expiry date in the past ()
* add enableExpiredPaymentCipherWarning setting

* add card expiry warning to the v2 Card Details component

* remove enableExpiredPaymentCipherWarning setting

* update expired card callout design and copy

* move card expired callout to cipher view

* add card expiry warning to the web vault add-edit cipher component
2024-08-21 10:59:03 -04:00
SmithThe4th
dedd7f1b5c
[PM-10607] Require userId for getKeyForCipherKeyDecryption ()
* updated cipher service to stop using the deprecated getUserKeyWithLegacySupport and use the version that requires a user id

* Added account service mock

* fixed cipher test

* Fixed test

* removed async from encryptCipher

* updated encryptSharedCipher to pass userId to the encrypt function

* Pass userId to getUserKeyWithLegacySupport on encryptSharedCipher

* pass in userid when setting masterKeyEncryptedUserKey

* Added activer usedId to new web refresh function
2024-08-20 11:00:48 -05:00
Victoria League
ed719f835a
[CL-389] Add end slot to non-text bit label content () 2024-08-20 11:55:11 -04:00
Jason Ng
72767dec74
[PM-10514] New TOTP Counter Component ()
* new vault totp countdown component
2024-08-15 10:03:14 -04:00
Will Martin
7571c766e0
[PM-10813] add eslint rule to restrict imports from apps in libs ()
* restrict app imports in libs

* add eslint ignore comments
2024-08-14 11:24:29 -07:00
Shane Melton
a1d94233e3
[PM-10761] Fix broken text for screen readers () 2024-08-13 15:51:34 -07:00
Shane Melton
fe9d44af6d
[PM-10721] Autofill section styles fixes ()
* [PM-10721] Remove autofill section title hyphen

* [PM-10721] Use h6 styling for header

* [PM-10721] Fix spacing for match detection select
2024-08-13 10:16:53 -07:00
Shane Melton
f017edb088
[PM-10651] Use bitLink instead of icon button and add a11y title () 2024-08-13 10:15:14 -07:00
Shane Melton
b3474fe101
[PM-9595] Fix owner / folder selects expanding out of container () 2024-08-13 09:26:13 -07:00
Shane Melton
7ad42ae18b
[PM-9190] Browser Refresh - Autofill section fixes ()
* [PM-10751] Add count to website URI label

* [PM-10752] Hide autofill on page load field when the setting is disabled

* [PM-10790] Fix bottom margin
2024-08-13 08:58:16 -07:00
Vincent Salucci
471dd3bd7b
[PM-10294] Remove FC v1 from Clients ()
* chore: remove fc v1 from org.canEditAnyCollection and update callers, refs PM-10294

* chore: remove fc v1 from collectionView.canEdit and update callers, refs PM-10294

* chore: remove fc v1 from organization.canEditAllCiphers and update callers, refs PM-10294

* chore: remove fc v1 from canDeleteAnyCollection, collection views, update callers, refs PM-10294

* chore: remove fc v1 from canEditUser/GroupAccess, refs PM-10294

* chore: remove fc v1 from canViewCollectionInfo, refs PM-10294

* chore: remove fc v1 from account component, refs PM-10294

* fix: remove fc v1 from collections component, refs PM-10294

* fix: update vault-items component, refs PM-10294

* fix: remove fc v1 from collection-dialog and collections components, refs PM-10294

* chore: remove ConfigService from group-add-edit and account components, refs PM-10294

* chore: change canEditAnyCollection to getter and update callers, refs PM-10294

* chore: change canEditUnmanagedCollections to getter and update callers, refs PM-10294

* chore: change canDeleteAnyCollection to getter and update callers, refs PM-10294

* chore: remove deprecated observable and update comments with v1, refs PM-10294

* chore: remove ununsed ConfigService from collection-dialog component, refs PM-10294

* chore: remove final fc v1 ref for vault-collection-row, refs PM-10294
2024-08-13 10:45:41 -05:00
Will Martin
295fb8f7a4
[PM-3530][PM-8588] persist extension route history ()
Save the extension popup route history and restore it after closing and re-opening the popup.

---------

Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
2024-08-12 17:26:47 -04:00
Nick Krantz
0b5afa6252
[PM-10731] Move vault icons ()
* move NoFolders icon to vault library

* move DeactivatedOrg icon to vault library

* move Vault icon to vault library

* move NoResults icon to vault library

* clean up barrel file

* Revert "move NoResults icon to vault library"

This reverts commit 43abd45db7.

* re-export no results
2024-08-12 08:38:11 -05:00
Jason Ng
bca619d0a4
[PM-7900] Login Credentials and Autofill Browser V2 View sections ()
* Added sections for Login Credentials and Autofill Options.
2024-08-08 13:52:45 -04:00
Jason Ng
1243cbd411
PM-10486 hide empty cardholder field () 2024-08-07 17:09:53 -04:00