1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-05 09:10:53 +01:00
Commit Graph

6323 Commits

Author SHA1 Message Date
Vince Grassia
186c16b577
Update Browser Build Workflow (#2544) 2022-05-04 10:59:05 -04:00
Daniel James Smith
eb4b9bc7b0
Fix Crowdin pull action (#2542)
* Rename crowdin-pull.yml to crowdin-pull-browser.yml

* Fix path to crowdin config for pull action
2022-05-04 14:37:45 +02:00
Daniel James Smith
63c606d463
Fix directory for browser's Crowdin pull config (#2541) 2022-05-04 14:37:24 +02:00
Patrick H. Lauke
5434d7cbbd
Minor: correct markdown for image/alt (#2539) 2022-05-04 13:45:09 +02:00
Vince Grassia
7d25bf6904
Remove lint job from build workflows (#2538) 2022-05-03 16:35:35 -04:00
Oscar Hinton
c1cc5a0814
[EC-183] Move eslint and prettier to project root (#2536) 2022-05-03 21:45:37 +02:00
Oscar Hinton
06f72b90d7
[EC-183] Fix the readme badge (#2535) 2022-05-03 20:46:25 +02:00
Oscar Hinton
04ab35f69b
[EC-183] Bump jslib to match the expected version (#2534) 2022-05-03 20:25:18 +02:00
Oscar Hinton
e639f3c40c
[EC-183] Mono Repository - Browser pipelines (#2533)
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
2022-05-03 20:01:37 +02:00
Oscar Hinton
3aa7570020
[EC-183] Mono Repository - Readme (#2532)
* Update GH issue templates, contributing and readme
2022-05-03 19:47:56 +02:00
Oscar Hinton
7fe51f83da
[EC-183] Mono Repository - Browser (#2531) 2022-05-03 19:38:55 +02:00
Patrick H. Lauke
11ef07fbce
[PS-517] Normalise/fix button focus outlines (#2529) 2022-05-03 11:31:04 +02:00
Oscar Hinton
9a954710d9
Add keytar to externals (#1520) 2022-05-03 11:03:21 +02:00
Oscar Hinton
a81c3c95a4
[CP-30] Add credit card pipe (#1517) 2022-05-02 19:45:24 +02:00
Kyle Spearrin
289ef6a13f
Forwarded email providers to username generator (#2528)
* Forwarded email providers to username generator

* update jslib
2022-05-02 13:23:19 -04:00
Oscar Hinton
99f6afbf5f
[CP-30] Use the CreditCardNumberPipe (#2527) 2022-05-02 17:02:09 +02:00
Kyle Spearrin
75470dc169
Forwarded email providers to username generator (#1511)
* forward email username generation

* update jslib
2022-05-02 10:57:01 -04:00
Oscar Hinton
18b5e4adfd
[EC-163] Undo move to rust implementation (#1509) 2022-05-02 12:39:38 +02:00
Thomas Rittson
6bd5d579af
[PS-74] Fix user authentication state checks (#2481)
* Replace vaultTimeoutService.isLocked
2022-05-02 07:57:40 +10:00
Patrick H. Lauke
0396d682b1
Change links to buttons, expose aria-pressed for toggles, add aria-expanded to send view's "Options" (#1437)
* Change links to buttons, expose `aria-pressed` for toggles

- also make existing `<a routerLink...>` type controls keyboard focusable with the addition of `tabindex="0"`

* Correctly set aria-pressed

now that I have a working build environment, could verify correct way to set this with my limited Angular knowledge

* Change more links to buttons, initial style changes

* Fix layout of <button> elements with .box-content-row

* Update jslib submodule

* Add `aria-expanded` to the send view's "Show options" expand/collapse control

* Fix position of "Edit" pencil when hovering over folders

* Update jslib

* Change sends list links to buttons

* Add `aria-pressed` to vault and send list buttons

Programmatically denote which of the buttons is currently active/shown in the right-most panel

* Fix incorrect "Options" expand/collapse button in add-edit view

Currently, that buttons lacks an accName because the "Options" text is outside of it.

* Add `aria-pressed` to the send left-hand column filters

* Simplify base, list, and vault styles

Since links are now buttons, no need to double up selectors for both types of elements. No need to double-up theming in base, as this also causes incorrect "x" in toasts.

* Remove unnecessary `position:relative`

Fixes issue with cut-off focus outlines, has no other adverse effect

* Fix styling for last child of action buttons

Old approach of making right padding smaller results in unsightly, off-center icon (noticeable when focus outline is visible). This visually remains the same, but reduces right-hand margin instead.
2022-04-30 16:09:41 +02:00
Thomas Rittson
ef60112855
[PS-74] Fix user authentication state checks (#1464)
* Use new authStatus method, clean up account switcher

* Update naming

* update jslib
2022-04-30 09:16:46 +10:00
Thomas Rittson
b467206448
[EC-156] [BEEEP] Remove factory providers in Angular DI (#1496)
* Use tokens

* Use initService

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-04-29 17:48:44 +10:00
Patrick H. Lauke
7b12868c70
[PS-497] Change <content> to <main>, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Patrick H. Lauke
9df22d3601
[PS-329] A11y: make view, copy, etc controls for ciphers/items keyboard focusable/operable, add screen reader improvements (#2507) 2022-04-28 18:24:13 +02:00
Nils Fahldieck
55b301c267
Widen the sidebar to 600px max (#1503)
This implements the suggestion by MrBlack of the community forums in: https://community.bitwarden.com/t/manually-resizable-sidebar-columns-in-bitwarden-desktop-app/31909/3
2022-04-27 22:10:11 +02:00
Thomas Rittson
17c3fdd68b
[EC-157] [BEEEP] Remove factory providers in Angular DI (#2516)
* Use initService

* Use InjectionTokens

* Update to use new locked and logout callbacks
2022-04-27 09:11:39 +10:00
github-actions[bot]
a5ebb9fb52
Bumped version to 1.33.1 (#1502)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 11:40:39 -07:00
Joseph Flinn
510c841359
Merge pull request #2520 from bitwarden/version_bump_1.58.0
Bump version to 1.58.0
2022-04-25 08:02:36 -07:00
github-actions[bot]
2764c9610b
Bumped version to 1.33.0 (#1501)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 08:02:04 -07:00
github-actions[bot]
cc6c51dfb1 Bumped version to 1.58.0 2022-04-25 15:00:35 +00:00
Oscar Hinton
241e08b7ff
[EC-166] Move electron metadata to separate file (#1498)
* Move electron metadata to separate file

* Replace yml with json

* Update build script
2022-04-25 15:54:08 +02:00
Oscar Hinton
865e92c94c
Improve reorganization note (#1497) 2022-04-22 17:13:06 +02:00
Patrick H. Lauke
c3d0a529fb
[CP-92] Add new more understandable labels to password generator checkboxes (#1461) 2022-04-22 15:26:38 +02:00
Oscar Hinton
6ad7f5a30a
Add reorganization notice (#2517) 2022-04-22 14:25:11 +02:00
Oscar Hinton
1315b3c6cd
Add reorganization notice (#1494) 2022-04-22 09:51:13 +02:00
Kyle Spearrin
b475f911b6
fix disabling of generate type (#2515) 2022-04-21 17:20:47 -04:00
Dave Nicolson
9f77dd9d09
[CP-96] Capitalize menu items consistently (#1489) 2022-04-21 19:44:53 +02:00
Thomas Rittson
5082c7708a
[PS-211] [PS-212] Make Generator page accessible (#1493)
* Fix radiobutton names

* Add role=radiogroup

* Add aria-labelledby
2022-04-21 09:51:37 -04:00
Thomas Rittson
4ed74416f4
[PS-211] [PS-212] Make Generator page accessible (#2513)
* Fix name attributes for radiobuttons in the same group

* Add role=radiogroup

* Add aria-labelledby

* Fix name
2022-04-21 09:49:13 -04:00
Patrick H. Lauke
58b39c613e
Remove unnecessary role="button" on <button> elements (#2514) 2022-04-21 14:33:20 +02:00
dwbit
10d35d863b
Contribution Documentation edits (#1486)
Making corrections to the mobile contributions doc:

Update Crowdin contact from Kyle to dwbit.
Update 'User-to-User Support' forum category to 'Ask the Bitwarden Community category'
2022-04-21 08:02:41 -04:00
dwbit
796cc88b46
Merge pull request #2503 from bitwarden/dwbit-patch-1
Contribution Documentation edits
2022-04-21 08:02:05 -04:00
Kyle Spearrin
caafbc2b73
fix disabling of generate type (#1491) 2022-04-20 11:46:12 -04:00
Patrick H. Lauke
2cafed758f
[PS-266] A11y: change tabbed interface to toggle buttons, correctly announce currently active tab as pressed (#2505)
* Change routerLink links to button elements

* Set aria-pressed attribute on button depending on routerLinkActive

* Change base styles to apply to tabs that use `<button>` instead of `<a>`
2022-04-20 14:25:44 +10:00
Thomas Rittson
a02e966da4
Update jslib (#2511)
* Update jslib

* Update name of UserVerificationComponent

* Update service deps
2022-04-19 10:30:46 -05:00
Thomas Rittson
a4ca9bf64c
Update jslib (#1490)
* Update jslib

* Update name of UserVerificationComponent
2022-04-19 10:29:43 -05:00
Joseph Flinn
a07c6869c2
Merge pull request #2504 from bitwarden/patch/download-artifacts-action
Bump pinned commit of download-artifacts
2022-04-18 14:28:55 -07:00
Joseph Flinn
3862a19571
Bumping pinned commit of the download-artifact action to bypass the broken GitHub api (#1488) 2022-04-18 14:28:49 -07:00
Joseph Flinn
b26f9e64bb Bumping pinned commit of the download-artifact action to bypass the broken GitHub api 2022-04-15 07:41:46 -07:00
dwbit
13744e6a29
Contribution Documentation edits
Making corrections to the mobile contributions doc:

    Update Crowdin contact from Kyle to dwbit.
    Update 'User-to-User Support' forum category to 'Ask the Bitwarden Community'
2022-04-15 06:20:05 -04:00