* create sso service
* rename sso service to sso-login service
* rename service
* add references to sso login service and update state calls
* fix browser
* fix desktop
* return promises
* remove sso state from account and global objects
* more descriptive org sso identifier method names
* fix sso tests
* fix tests
* refactor login strategies into own service
* create login service factory
* replaces instances of authService with loginStrategyService
* replace more instances of authService
* move logout back to auth service
* add browser dependencies
* fix desktop dependencies
* fix cli dependencies
* fix lint and test files
* fix anonymous hub deps
* fix webauthn-login service deps
* add loginstrategyservice to bg
* move login strategy service and models to auth folder
* revert changes to tsconfig
* use alias for imports
* fix path
---------
Co-authored-by: rr-bw <102181210+rr-bw@users.noreply.github.com>
* [PM-5368] Open Duo auth url. Add BroadcastChannel listener for duo result.
* [PM-5368] Remove debug line. Use PlatformUtilService to launch Uri.
* PM-5368 - Some progress on getting new frameless duo implementation in place
* PM-5368 - Base2FAComp - Save off duoFramelessUrl for use later on as user must be given the option to remember the device before launching the duo frameless flow in the new tab.
* PM-5368 - Web - 2FA Comp - (1) Only show larger width when showing backwards compatible duo (2) Stack buttons per new design (3) selectedProviderType === providerType.OrganizationDuo is correct check for when org requires DUO
* PM-5368 - Web - 2FA Comp - translate duo stuff
* PM-4613 - Browser 2FA - Get most of DUO frameless in place. WIP. Must figure out how to transfer state from popup to popout + add popout logic to auth-popout-windows.ts. Converted existing useAnotherTwoStepMethod button to use new comp lib bitButton per design.
* PM-4613 - Browser 2FA Comp - (1) HTML - add margin around duo frameless text to match figma (2) Get popout extension logic working properly - now closes existing popup
* PM-4613 - TODO figure out communication between web and browser as broadcast channel will not work.
* PM-5368 - Base comp + web changes - (1) Base component now has a setupDuoResultListener method for child classes to override (2) Web overrides setupDuoResultListener and cleans up broadcast channel once a duo result comes through.
* PM-4613 - Browser - (1) Add window message handling to content-message-handler content script to pass along the duo result message to the browser extension (2) 2FA comp - override setupDuoResultListener and use browserMessagingApi to listen to duoResult and submit when it comes through.
* PM-5368 - Web - 2FA comp - only clean up duo result channel on ngDestroy so that user can re-submit if an error occurs.
* PM-5368 and PM-4613 - (1) Update base 2FA comp to only initialize duo result listener once as init is called any time the user changes 2FA option if multiple are present (duo org and duo personal) (2) Each client now will only create a listener once even if it is called more than once (3) On web, only try to clean up the duoResultChannel if it was created to avoid erroring on other 2FA methods.
* PM-5368 - Base 2FA comp - add TODO to remove duo SDK handling once we remove the duo-redirect flag
* PM-5368 - Per PR feedback, avoid repetition of duo provider check by using a new public property for isDuoProvider
* PM-4613 - Per PR feedback: (1) Deconstruct code out of data (2) Add test for duoResult.
---------
Co-authored-by: André Bispo <abispo@bitwarden.com>
* Got trial page working without the form set up
* Set up the form to create SM subscription
* Add free SM trial page and sign up
* Conner's changes
* fixed imports
* Set isFromSecretsManagerTrial
* Fixed OrgKey location
* Add isFromSecretsManager prop to free org create
* Add LTO callout
* Switch LTO to background box
* Defect: AC-2081
* Fixed typo "Secrets Manger" to "Secrets Manager"
* Removed discount price logic for storage and secrets manager prices since they don't apply
---------
Co-authored-by: Conner Turnbull <133619638+cturnbull-bitwarden@users.noreply.github.com>
Co-authored-by: Conner Turnbull <cturnbull@bitwarden.com>
* PM-5242 - First working draft of copying out web CL implementation of user verification form and dialog components into standalone libs/auth components which could be used in any client.
* PM-5242 - Rename UserVerificationFormComponent to UserVerificationFormInputComponent b/c it doesn't actually have a form and is meant to slot into a form as an input.
* PM-5242 - Update libs/auth angular index to take renamed component into account
* PM-5242 - Clean up UserVerificationDialogComponent as have much cleaner design approach now (maintain existing func while simply adding new requirements for client side validation for passkeys)
* PM-5242 - UserVerificationFormInput component - WIP draft of new client and server split of user verification logic
* PM-5242 - UserVerificationFormInput - WIP - Lots of progress on client side verification layout - more to do
* PM-5242 - UserVerificationFormInputComponent - Add hasMultipleVerificationMethods property so we can only show alternate methods if user has them.
* PM-5242 - UserVerificationFormInputComponent - rename hasMultipleVerificationMethods to hasMultipleClientVerificationOptions
* PM-5242 - Add new user verification biometrics fingerprint icon with proper secondary fill so it displays properly on all themes.
* PM-5242 - Create enum for tracking client user verification states
* PM-5242 - UserVerificationFormInputComponent - WIP - (1) Got biometrics layout working except for error state (2) Emitting active client verification option and biometrics result to dialog (3) Properly identifying if biometrics is enabled in a platform agnostic way (4) Translations TODO
* PM-5242 - UserVerificationDialogComponent - (1) Wire up new inputs and outputs for UserVerificationFormInput (2) Don't show submit button when clientside biometrics verification active
* PM-5242 - UserVerificationFormInputComponent - wired up biometrics failure and retry handling + re-arranged comp properties to put inputs & outputs at the top
* PM-5242 - UserVerificationFormInput component - Add logic to prevent currently active client verification method from being shown an option
* PM-5242 - UserVerificationFormInput - adjust margins
* PM-5242 - User verification dialog and form input comps - replace Verification with VerificationWithSecret type where applicable
* PM-5242 - UserVerificationFormComp - Default to server for backwards compatibility and to avoid requiring the input at all
* PM-5242 - UserVerificationFormInputComp - (1) Rename processChanges to processSecretChanges (2) Short circuit processSecretChanges when biometrics is active (3) Add new function for determining type of verification that has a secret.
* PM-5242 - UserVerificationDialog - Support custom, optional callout in dialog body.
* PM-5242 - UserVerificationDialogComp - support custom confirm button text and type.
* PM-5242 - UserVerificationDialog - Add user verification dialog result type to allow for handling all possible verification scenarios
* PM-5242 - UserVerificationFormInputComp - tweak comment
* PM-5242 - UserVerificationFormInput comp html - add placeholder text for no client verifications found scenario
* PM-5242 - UserVerificationDialogComponent - (1) Add confirm & cancel to dialog result (2) Add cancel method vs using bitDialogClose for specificity (3) Adjust naming of output property to properly specify that it is scoped to client verification (4) Adjust layout of dialog html to handle when no client side verification methods are found.
* PM-5242 - UserVerificationFormInput - Clean up test code
* PM-5242 - UserVerificationFormInput - For server verification, we don't need to check if the user has a local master key hash as we will generate a hash to send to the server for comparison.
* PM-5242 - UserVerificationFormInput html - Remove now unnecessary dev warning as I've provided a default
* PM-5242 - UserVerification Dialog & Form Input - add translations on all clients for all visible text.
* PM-5242 - UserVerificationFormInput html - remove no active client verification handling from form input comp as it is instead emitted upwards to parent dialog component to be handled there.
* PM-5242 - UserVerificationDialogComp - (1) Make UserVerificationDialogResult.noAvailableClientVerificationMethods optional because it isn't needed in cancel flows (thanks Will) (2) Modify static open to intercept closed observable event in order to always return a UserVerificationDialogResult as BitDialog returns empty string when the user clicks the x
* PM-5242 - UserVerificationDialogComp - Simplify dialog param names to remove redundant dialog
* PM-5242 - UserVerificationDialogParams - update comments to match new names
* PM-5242 - UserVerificationDialog Storybook - WIP first draft
* PM-5242 - UserVerificationDialogStoryComponent - WIP - try out having imports the same as the standalone component
* PM-5242 - UserVerificationDialogStoryComponent - more WIP - building now - some stuff displaying
* PM-5242 - UserVerificationDialogStoryComponent - some progress on providers setup
* PM-5242 - Not going to use storybook for user verification dialog
* PM-5242 - UserVerificationDialogComp - move types into own file + add docs
* PM-5242 - Update auth index to export user-verification-dialog.types
* PM-5242 - UserVerificationFormInput & UserVerificationService - Extract out getAvailableVerificationOptions logic into service
* PM-5242 -UserVerificationDialogComponent - Update close logic to handle escape key undefined scenario
* PM-5242 - UserVerificationFormInput - add getInvalidSecretErrorMessage for properly determining invalid secret translation
* PM-5242 - UserVerificationDialogComp - Refactor submit logic to handle different return methodologies in existing MP and OTP user verification service code vs new PIN flow (e.g., throwing an error instead of returning false)
* PM-5242 - PinCryptoService - change error logs to warnings per discussion with Justin
* PM-5242 - UserVerificationFormInput - Biometrics flow on desktop - remove accidentally added period in couldNotCompleteBiometrics translation key.
* PM-5242 - UserVerificationFormInput HTML - Re-arrange order of other client verification options to match design
* PM-5242 - UserVerificationFormInputComponent - Reset inputs as untouched on change of client verification method.
* PM-5242 - UserVerificationDialogComponent - Remove TODO as existing secret change logic turns invalidSecret false when biometrics is swapped to.
* PM-5242 - UserVerificationFormInputComponent - getInvalidSecretErrorMessage - fix PIN error message not being returned.
* PM-5242 - UserVerificationDialogComponent - Add documentation and examples to open method.
* PM-5242 - UserVerificationDialogComponent - tweak open docs
* PM-5242 - Remove accidental period from translation keys on browser & web
* PM-5242 - UserVerificationFormInputComponent - OTP flow needed button module to work
* PM-5242 - UserVerificationDialogParams - Add docs explaining that noAvailableClientVerificationMethods is only for desktop & browser.
* PM-5242 - User-verification-form-input - Adjust layout to meet new design requirements - (1) On load, send OTP without user clicking a button (2) Allow resending of the codes (3) show a code sent message for 3 seconds
* PM-5242 - Browser User Verification - Instantiate PinCryptoService and UserVerification service AFTER instantiating vaultTimeoutSettingsService so that it isn't undefined at run time.
* PM-5242 - JslibServices Module - UserVerificationService - add missing PlatformUtilsServiceAbstraction dependency.
* PM-5242 - Desktop Native Messaging Service - Wrap biometric getUserKeyFromStorage call in try catch because it throws an error if the user cancels the biometrics prompt and doesn't send a response to the browser extension when using the biometrics unlock bridge to the desktop app and OS.
* PM-5242 - Browser Extension - NativeMessagingBackground - if the desktop biometricUnlock command is executed with a canceled (not adjusting misspelling to keep side effects at a min) response, don't bother continuing.
* PM-5242 - BrowserCryptoService - When retrieving the user key via desktop biometrics, return null for user key if the user fails or cancels the biometrics prompt. Otherwise, if there is a user key in memory after unlock, biometrics user verification will always just return the user key from state regardless of if the user has successfully passed the biometrics prompt or not.
* PM-5242 - BrowserCryptoService - extra comments
* PM-5242 - Clean up translations - (1) Remove unused defaultUserVerificationDialogConfirmBtnText (2) Refactor name of defaultUserVerificationDialogTitle to just be verificationRequired which matches existing naming conventions.
* PM-5242 - CLI - fix order of service instantiations to ensure that vaultTimeoutSettingsService isn't undefined for PinCryptoService and UserVerificationService
* PM-5242 - Rename UserVerificationDialogParams to UserVerificationDialogOptions to match existing naming conventions of other CL comps.
* PM-5242 - UserVerificationDialogComponent - dialogParams renamed to dialogOptions
* PM-5242 - UserVerificationService Abstraction - Per PR feedback, use keyof for verificationType
* PM-5242 - UserVerificationBiometricsIcon - Per PR feedback, use https://jakearchibald.github.io/svgomg/ to optimize SVG by 50%.
* PM-5242 - Per PR feedback, clarify UserVerificationDialogOptions.clientSideOnlyVerification comment.
* PM-5242 - UserVerificationTypes - Add comments clarifying all text passed to the UserVerificationDialog are translation keys
* PM-5242 - UserVerificationDialogComp - fix extra new line per PR feedback
* PM-5242 - UserVerificationDialogTypes - per PR feedback and discussion with Will M., export ButtonType from CL so we (and consumers of the dialog) can properly import it via standard CL import.
* PM-5242 - BrowserCryptoService - Adjust comments per PR feedback.
* PM-5242 - UserVerificationDialogComponent - make ActiveClientVerificationOption readonly as it only for component html
* PM-5242 - UserVerificationDialogComp html - finish comment
* PM-5242 - BrowserCryptoService - add returns js doc per PR feedback.
* PM-5242 - UserVerificationDialogComponent - per PR feedback, add unexpected error toast.
* PM-5242 - UserVerificationService - getAvailableVerificationOptions - update params to use keyof like abstraction
* PM-5242 - Mark all existing client specific implemetations of user verification as deprecated.
* PM-4596 - PinCryptoService first draft
* PM-4596 - PinCryptoService - Refactor pinKeyEncryptedKey retrievals out into own method getPinKeyEncryptedKeys
* PM-4596 - npm ci + npm run prettier to fix lint issues
* PM-4596 - PinCryptoService - Add kdf types
* PM-4596 - PinCryptoService - Refactor pin validation into own helper method.
* PM-4596 - Rename pin-crypto.service.ts to pin-crypto.service.implementation.ts
* PM-4596 - PinCryptoService - add additional logging for error states.
* PM-4596 - JslibServicesModule - register new PinCryptoService and PinCryptoServiceAbstraction
* PM-4596 - PinCryptoService - modify decryptUserKeyWithPin signature to not require email to match MP verification process in user verification service.
* PM-4596 - Lock components - use new PinCryptoService.decryptUserKeyWithPin(...) to get user key + refactor base comp unlock with pin method to improve
* PM-4596 - Lock component - if too many invalid attempts, added toast explaining that we were logging the user out due to excess PIN entry attempts
* PM-4596 - UserVerificationService - (1) Refactor verifyUser(...) to use switch + separate methods for a cleaner parent method + better extensibility for PIN & biometrics which are TBD (2) Add PIN support to validateInput(...)
* PM-4596 - UserVerificationService - add PIN and biometrics functions to verifyUser(...)
* PM-4596 - PinCryptoService Spec - start test file - instantiates properly
* PM-4596 - PinCryptoService tests - WIP
* PM-4596 - PinCryptoService tests - WIP - got success cases working
* PM-4596 - pin-crypto.service.implementation.spec.ts renamed to pin-crypto.service.spec.ts
* PM-4596 - PinCryptoService.getPinKeyEncryptedKeys(...) - add comment + var name change for clarity
* PM-4596 - PinCryptoService tests - test invalid, null return scenarios
* PM-4596 - CLI - bw.ts - update UserVerificationService instantiation to include new pinCryptoService
* PM-4596 - PinCryptoService - import VaultTimeoutSettingsServiceAbstraction instead of implementation for factory creation to get browser building
* PM-4596 - (1) Create pinCryptoServiceFactory for browser background (2) Add it to the existing userVerificationServiceFactory
* PM-4596 - Browser - Main.background.ts - Add pinCryptoService and add to userVerificationService dependencies
* PM-4596 - UserVerificationService - per PR feedback simplify returns of verifyUserByPIN(...) and verifyUserByBiometrics(...)
* PM-4596 - Messages.json on desktop & browser - per PR feedback, adjust tooManyInvalidPinEntryAttemptsLoggingOut translation text to remove "you"
* PM-4596 - VerificationType enum - fix line copy mistake and give BIOMETRICS own, unique value.
* PM-4596 - VerificationType - rename BIOMETRICS to Biometrics to match existing MasterPassword value case.
* PM-4596 - Update verification type to consider whether or not a secret exists as we have added a new verification which doesn't have a type. Add new server and client side verification types. Update all relevant code to pass compilation checks.
* PM-4596 - More verification type tweaking
* PM-4596 - Verification - verificationHasSecret - tweak logic to be more dynamic and flexible for future verification types
* PM-4596 - UpdateTempPasswordComp - use new MasterPasswordVerification
* PM-4596 - Desktop - DeleteAcctComp - use VerificationWithSecret to solve compile error w/ accessing secret
* PM-4596 - Per discussions with Andreas & Will, move new Pin Crypto services into libs/auth + added @bitwarden/auth path to CLI tsconfig + added new, required index.ts files for exporting service abstractions & implementations
* PM-4596 - Fixed missed import fixes for lock components across clients for pin crypto service after moving into @bitwarden/auth
* PM-4596 - More PinCryptoService import fixes to get browser & desktop building
* PM-4596 - Update desktop lock comp tests to pass by providing new pin crypto service.
* PM-4596 - User verification service -update todo
* PM-4596 - PinCryptoService - per PR feedback, fix auto import wrong paths.
* PM-4596 - PinCryptoService tests - fix imports per PR feedback
* PM-4596 - UserVerificationSvc - rename method to validateSecretInput per PR feedback
* Fix imports
* PM-4596 - PinCryptoService - Refactor naming for clarity and move test cases into describes per PR feedback
* reorg libs/auth; expose only libs/auth/core to cli app
* PM-4596 - UserVerification - Resolve import issue with importing from libs/auth. Can't use @bitwarden/auth for whatever reason.
* PM-4596 - Fix desktop build by fixing import
* PM-4596 - Provide PinCryptoService to UserVerificationService
* PM-4596 - PinCryptoServiceFactory - you cannot import services from @bitwarden/auth in the background b/c it brings along the libs/auth/components and introduces angular into the background context which doesn't have access to angular which causes random test failures. So, we must separate out the core services just like the CLI to only bring along the angular agnostic services from core.
* PM-4596 - Refactor libs/auth to have angular / common + update all imports per discussion with Matt & Will. Introduced circular dep between PinCryptoService + VaultTimeoutSettingsService + UserVerificationService
* PM-4596 - VaultTimeoutSettingsService - Refactor UserVerificationService out of the service and update all service instantiations and tests. The use of the UserVerificationService.hasMasterPassword method no longer needs to be used for backwards compatibility. This resolves the circular dependency between the PinCryptoService, the UserVerificationService, and the VaultTimeoutSettingsService. We will likely refactor the hasMasterPassword method out of the UserVerificationService in the future.
* PM-4596 - Update CL tsconfig.libs.json to add new auth/common and auth/angular paths for jslib-services.module imports of pin crypto service to work and for test code coverage to run successfully.
* PM-4596 - Address PR feedback
* PM-4596 - Update root tsconfig (only used by storybook) to add new libs/auth paths to fix chromatic build pipeline.
* PM-4596 - Actually update tsconfig with proper routes to fix storybook
* PM-4596 - UserVerificationService - verifyUserByBiometrics - add error handling logic to convert failed or cancelled biometrics verification to a usable boolean
* PM-4596 - Add missing await
* PM-4596 - (1) Add log service and log to user verification service biometric flow to ensure errors are at least revealed to the console (2) Fix factory missing PinCryptoServiceInitOptions
* PM-4596 - Use the correct log service abstraction
* PM-4596 - Remove unused types per PR review
---------
Co-authored-by: William Martin <contact@willmartian.com>
## Type of change
<!-- (mark with an `X`) -->
```
- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other
```
## Objective
<!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding-->
Final Client changes for Key Rotation Improvements.
- Introduces a new `KeyRotationService` that is responsible for owning rotation process.
- Moves `Send` re-encryption to the `SendService` (`KeyRotationService` shouldn't have knowledge about how domains are encrypted).
- Moves `EmergencyAccess` re-encryption to the `EmergencyAccessService`.
- Renames `AccountRecoveryService` to `OrganizationUserResetPasswordService` after feedback from Admin Console
## Code changes
<!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes-->
<!--Also refer to any related changes or PRs in other repositories-->
Auth
- **emergency-access-update.request.ts:** New request model for domain updates that includes Id
- **emergency-access.service.ts:** Moved `EmergencyAccess` re-encryption to the `EmergencyAccessService`. Add deprecated method for legacy key rotations if feature flag is off
- **key-rotation.service/api/spec/module:** New key rotation service for owning the rotation process. Added api service, module, and spec file.
- **update-key.request.ts:** Moved to Auth ownership. Also added new properties for including other domains.
- **migrate-legacy-encryption.component.ts:** Use new key rotation service instead of old component specific service. Delete old service.
- **change-password.component.ts:** Use new key rotation service.
- **settings.module.ts:** Import key rotation module.
Admin Console
- **organization-user-reset-password.service.ts/spec:** Responsible for re-encryption of reset password keys during key rotation. Added tests.
- **organization-user-reset-password-enrollment.request.ts:** New request model for key rotations
- **reset-password.component.ts:** Update `AccountRecoveryService` to `OrganizationUserResetPasswordService`
- **enroll-master-password-reset.component.ts:** Update `AccountRecoveryService` to `OrganizationUserResetPasswordService`
Tools
- **send.service/spec.ts:** Responsible only for re-encryption of sends during key rotation. Added tests.
Other
- **api.service.ts:** Move `postAccountKey` to `KeyRotationApiService`
- **feature-flag.enum.ts:** add new feature flag
## Screenshots
<!--Required for any UI changes. Delete if not applicable-->
## Before you submit
- Please add **unit tests** where it makes sense to do so (encouraged but not required)
- If this change requires a **documentation update** - notify the documentation team
- If this change has particular **deployment requirements** - notify the DevOps team
- Ensure that all UI additions follow [WCAG AA requirements](https://contributing.bitwarden.com/contributing/accessibility/)
* PM-1658 - Update Accept Organization component to take new org invite qParams into acct for accelerating the user through the org invite accept process.
* PM-1658 - Update trial initiation and register form comps to respect fromOrgInvite when email is populated to make the populated email read only so users in the org invite process dont change it.
* PM-1658 - Per PR feedback, we could simplify the logic by only sending the org sso identifier if it was required to be used.
* PM-1658 - Accept Comp - should send existing user email as qParam to get it to autofill properly. Previous "autofill" was due to using remember email when creating an account before testing the existing user inv flow.
Assign ownership to many of the remaining libs/common files.
Criteria for ownership:
* Files used by a single team, is now owned by that team.
* Files related to a domain owned by a team is now owned by that team.
* Where ownership is unclear the "lowest level" service takes ownership.
* PM-2041 - (1) Bring over WebauthnApiService + required models from existing #5493 PR (2) Per discussion with Andreas, remove unnecessary methods from WebauthnApiService
* PM-2041 - Rename responses folder to response to match rest of codebase
* PM-2041 - Recreate BaseLoginViaWebAuthnComponent and then web implementation of it.
* PM-2041 - Web routing module - add LoginViaWebAuthnComponent and associated route "login-with-passkey"
* PM-2041 - InjectionTokens - add new navigator credentials injection token which provides the CredentialsContainer interface of the Credential Management API and exposes methods to request credentials and notify the user agent when events such as successful sign in or sign out happen
* PM-2041 - Rename WebauthnApiService & abstraction to WebAuthnLoginApiService
* PM-2041 - Rename WebauthnLoginApiService to WebAuthnAdminApiService
* PM-2041 - Bring over first draft of webauthn-login.service + abstraction; register on jslib-services.module.
* PM-2041 - Bring over web & base login component changes to add login with passkey button if feature flag enabled.
* PM-2041 - WebAuthnAdminApi - update list of TODOs based on conversation with Andreas
* PM-2041 - Login.module - cleanup todo after conversation w/ Andreas
* PM-2041 - Move utils out of web and into common auth/utils and renamed to webauthn-utils
* PM-2041 - Update userDecryptionOptions to support new webauthn prf decryption option
* PM-2041 - (1) Recreate webauthn-login service with updated logic (2) Move files from webauthn to webauthn-login (3) Recreate webauthn-login.strategy with updated logic
* PM-2041 - Remove completed TODO
* PM-2041 - Fix login-via-webauthn component imports + fix name (missing n)
* PM-2041 - Missed this change when renaming LoginViaWebAuthComponent to LoginViaWebAuthnComponent
* PM-2041 - Add WebAuthnLoginApiService to jslib-services.module
* PM-2041 - Remove unused param from WebAuthnLoginApiServiceAbstraction as we aren't supporting non-discoverable passkeys for MVP
* PM-2041 - WebAuthnLoginApiService - remove email and target correct endpoint for getCredentialAssertionOptions(...) call
* PM-2041 - WebAuthnLoginStrategy - (1) Remove unused dep (2) Add safeguard checks to setUserKey(...) logic similar to SSO login strategy
* PM-2041 - BaseLoginViaWebAuthnComponent - Rewrite authenticate logic to use new methods on webAuthnLoginService
* PM-2041 - UserDecryptionOptionsResponse - update naming of webAuthn options object to match server response
* PM-2041 - WebAuthnLoginAssertionResponseRequest - (1) clean up TODO (2) Fix response property name to match server
* PM-2041 - WebAuthnTokenRequest - must stringify device response b/c sending as form data
* PM-2041 - AuthService - Add WebAuthnLoginCredentials and WebAuthnLoginStrategy support to auth service
* PM-2041 - WIP tests for WebAuthnLoginService
* PM-2041 - UserDecryptionOptions - Rename WebAuthnPrfOptions to singular WebAuthnPrfOption to match server
* PM-2041 - Add TODO in login comp
* PM-2041 - (1) Update WebAuthnLoginService.assertCredential(...) to add a check to ensure we cannot leak PRF credentials to the BW server by mistake (2) Add credential to view names for clarity (3) Add JS doc style comments to WebAuthnLoginServiceAbstraction
* PM-2041 - Login.component.html - (1) Center passkey login button (2) Use correct user passkey icon
* PM-2041 - Utils + tests - (1) Add new hexStringToArrayBuffer(...) method (2) Add tests for existing fromBufferToHex(...) (3) Add tests for new hexStringToArrayBuffer(...) method
* PM-2041 - Fix broken import
* PM-2041 - WebAuthnLoginResponseRequest - Adjust warning to be correct
* PM-2041 - Webauthn-utils - createSymmetricKeyFromPrf(...) - add return type
* PM-2041 - WebAuthnLoginService spec file - good progress on figuring out how to test passkey assertion process. Tests are passing, but need to add more setup logic around the MockAuthenticatorAssertionResponse in order to be able to confirm the output is correct.
* PM-2041 - Utils + Utils Spec file changes - (1) Add new fromB64ToArrayBuffer(...) method (2) Add tests for existing fromBufferToB64(...) (3) Add tests for new fromB64ToArrayBuffer(...) method (4) Add round trip conversion tests in both directions
* PM-2041 - Utils.spec - update round trip conversion tests between hex string and array buffer.
* PM-2041 - WebAuthnLoginService.spec - assertCredential(...) happy path test passing
* PM-2041 - WebAuthnLoginAssertionResponseRequest - Add interface
* PM-2041 - WebAuthnLoginAssertionResponseRequest data should be UrlB64 strings per discussion w/ Andreas
* PM-2041 - WebAuthnLoginService Spec file - Per feedback, reverse approaches to generating test data (go from array buffer to b64 strings vs the reverse) to avoid using math.random which can introduce test inconsistency
* PM-2041 - Finish testing assertCredential(...)
* PM-2041 - WebAuthnLoginService tests completed - tested logIn method
* PM-2041 - Login html - add "or" between standard email login and passkey login
* PM-2041 - WebAuthnLoginStrategy test start
* PM-2041 - After rebase - BaseLoginViaWebAuthnComponent - Must rename ForceResetPasswordReason to ForceSetPasswordReason + refactor post login routing logic to match other auth owned flows.
* PM-2401 - Desktop - login comp - fix desktop build
* PM-2041 - Browser - login comp - fix build issue
* PM-2401 - WIP on webauthn-login.strategy testing
* PM-2401 - Finish testing webauthn login strategy
* PM-2041 - WebAuthnAdminApiService renamed to WebAuthnLoginAdminApiService
* PM-2041 - Remove unnecessary comment
* PM-2041 - Per PR feedback, remove noMargin and just add mb-3
* PM-2041 - Per PR feedback, remove unused 2FA and remember email logic (2FA isn't supported right now and we aren't using non-discoverable credentials so we aren't using a user entered email)
* PM-2401 - BaseLoginViaWebAuthnComponent - improve error handling to allow users to retry w/ another passkey
* PM-2401 - Per PR feedback, provide translated message to cover all invalid passkey scenarios.
* PM-2401 - WebAuthnLoginService - per PR feedback, remove unnecessary from
* PM-2041 - WebAuthnLoginCredentialAssertionView - per PR feedback, use actual key type
* PM-2401 - Per PR feedback, remove WebAuthnLoginStrategy constructor as it is identical to its super class constructor
* PM-2041 - WebAuthnLoginService tests - use first value from to improve tests
* PM-2401 - Fix WebAuthnLoginService build issue after changing SymmetricCryptoKey to PrfKey
* PM-2041 - WebAuthnLoginServiceAbstraction remove incorrect undefined from getCredentialAssertionOptions() abstraction
* PM-2041 - Refacor WebAuthn login service tests based on PR feedback
* PM-2041 - Per PR feedback, remove NAVIGATOR_CREDENTIALS injection token and just use WINDOW directly for WebAuthnLoginService
* PM-2041 - WebAuthnLoginServiceAbstraction - per PR feedback, improve assertCredential jsdocs with return info
* PM-2041 - Per PR feedback, update WebAuthnLoginStrategy logInTwoFactor(...) to return an exception if attempted to be called.
* PM-2041 - WebAuthnLoginResponseRequest - per PR feedback, replace fromBufferToB64(...) with fromBufferToUrlB64(...)
* PM-2041 - AssertionOptionsResponse - use doc comment per PR feedback
* PM-2041 - Per PR feedback, adjust location of helpers and mocks in WebAuthnLoginStrategy test file
* PM-2041 - Adjust WebAuthnLoginService tests to take the WebAuthnLoginResponseRequest change to use fromBufferToUrlB64(...) into account to get tests to pass again
* PM-2041 - WebAuthnLoginStrategy - adjust test name to match convention per PR feedback
* PM-2041 - More test tweaks - (1) Rename method (2) Support strict
* PM-2041 - Per PR feedback, AssertionOptionsResponse constructor should null check allowCredentials b/c it is optional
* PM-2041 - Per PR Feedback, remove duplicated fromB64ToArrayBuffer(...) from utils and update tests.
* PM-2041 - Per PR feedback, rename WebAuthnTokenRequest to WebAuthnLoginTokenRequest
* PM-2041 - Per discussion with product and Andreas, add 2FA transition handling just in case we add server support in the future.
* feat: stretch PRF key (#6927)
* feat: stretch PRF key
includes necessary utils -> service refactors
* feat: add tests
* [PM-2041] feat: assertion-options `POST` -> `GET`
* [PM-2041] chore: remove unused properties
* [PM-2041] fix: set private key
* [PM-2041] feat: remove all 2FA related fields
* [PM-2041] chore: clean up 2FA comments
* [PM-2041] chore: document `webauthn-login-prf-crypto.service.abstraction.ts`
* [PM-2041] chore: document webauthn login services
---------
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
* added previous-url to global-state
* updated storage of previousUrl for SSO/MFA flows
* revert file changes
* added post login routing
* Clear PreviousUrl from storage on new Login
* Components do not call StateService anymore
* removed needed query params
* refactored components to use RouterService
* fixed build error
* fixed mfa component
* updated logic for previous Url
* removed unneeded base implementation
* Added state call for Redirect Guard
* Fixed test cases
* Remove routing service calls
* renamed global field, changed routing to guard
* reverting constructor changes and git lint issue
* fixing constructor ordering
* fixing diffs to be clearer on actual cahnges.
* addressing accepting emergency access case
* refactor and add locked state logic
* refactor name of guard to be more clear
* Added comments and tests
* comments + support lock page deep linking + code ownership
* readability updates
* Combined guards and specs updated routing
* Update oss-routing.module.ts
* fixed stroybook build
* PM-3659 - Passkey registration - if the require SSO policy applies to the user, disable user's ability to enable passkey registration and the ability to create new credentials if they already have some + display message indicating why the feature is off. We still must allow users to remove existing credentials.
* PM-3659 - Replace policyService.get$ with policyService.policyAppliesToActiveUser$
* PM-3659 - CreateCredentialDialogComp - remove error handling as async actions has better handling built in already.
* lazy load and move accept emergency component
* create emergency access services
- move api calls to specific api service and refactor
* remove any from emergency api service
* move emergency access logic to service
* create emergency access view
* move view ciphers logic to service
* move models to web folder
* move takeover logic to service
* remove emergency api service dependency from other files
* write tests for emergency access service
* import shared module into component
* fix imports
* Revert "fix imports"
This reverts commit d21cb02bd8.
* create emergency access module for service
* move emergency access out of core folder
- add more organization to components under settings
* change EA views to domain models
* move EA enums to folder
* resolve PR feedback
* [PM-2241] chore: refactor into new "pending" view type
* [PM-2241] feat: record PRF support
* [PM-2241] feat: add prf checkbox to dialog
* [PM-2241] chore: remove `disableMargin` instead
Will expressed his concern that these things aren't sustainable, and that we should try using `!important` statements instead, which is a good point!
* [PM-2241] feat: add prf registration
* [PM-2241] feat: add support for `prfStatus`
* [PM-2241] feat: add rotateable key set
* [PM-2241] feat: add PRF creation error handling
* [PM-2241] chore: improve rotateable key docs
* [PM-2241] feat: add basic test
* [PM-2241] chore: update `SaveCredentialRequest` docs
* [PM-2241] chore: rename to `WebauthnLoginAdminService`
* [PM-2241] fix: typo in `save-credential.request.ts`
* [PM-2241] fix: typo in more places
* [PM-4717] Fixed teams starter typo in trial initiation
* [PM-4716] Fixed duplicated information in enterprise plan details
* [AC-1799] Resolved unresponsive "invite members" button when adding users to org
* Added support for the teams starter plan
* Plans now respect display sort order. Updated teams starter to be in its own product
* Remove upgrade button and show new copy instead -- wip copy
* Added upgrade dialog for teams starter plan when adding an 11th user
* Updated the add user validator to check if plan is teams starter. Updated to not count duplicated emails in the overall count
* Renamed validator to be more descriptive and added additional unit tests
* Added validator for org types that require customer support to upgrade
* Updated small localization for teams plan to account for new starter plan
* Removed invalid tests
* Resolved issues around free trial flow for teams starter
* Added new layout for teams starter free trial flow
* Updated copy following demo. Resolved display issues discovered during demo
* Removed temporary copy for testing
* Updated the second step of free trial flow to use org display name
* Updated invite user modal to display 10 instead of 20 as the invite limit for Teams Starter
---------
Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com>
* PM-3275 - Policy.service - Refactor existing mapPoliciesFromToken internal logic to provide public mapPolicyFromResponse method
* PM-3275 - Add new PolicyApiService.getMasterPasswordPolicyOptsForOrgUser method for use in the set password comp
* PM-3275 - Update set-password.comp to use new policyApiService.getMasterPasswordPoliciesForInvitedUsers method
* PM-3275 - (1) Remove post TDE AuthN set password routing logic from SSO/2FA comps as we cannot set an initial user password until after decryption in order to avoid losing the ability to decrypt existing vault items (a new user key would be created if one didn't exist in memory) (2) Add set password routing logic post TDE decryption in LoginWithDevice/Lock components (3) Add new ForceResetPasswordReason to capture this case so that we can guard against users manually navigating away from the set password screen
* PM-3275 - SyncSvc - Add logic for setting forcePasswordReset reason if TDE user w/out MP went from not having MP reset permission to having it.
* PM-3275 - Rename ForceResetPasswordReason enum to ForceSetPasswordReason + update all references.
* PM-3275 - Removing client deprecated calls to getPoliciesByInvitedUser and helper call getMasterPasswordPoliciesForInvitedUsers
* PM-3275 - PolicyAPI service - remove no longer necessary getPoliciesByInvitedUser method
* PM-3275 - LockComp - TODO cleanup
* PM-3275 - SSO & 2FA comp - cleanup of incorrect routing path
* PM-3275 - (1) State service refactor - change getForcePasswordResetReason / setForcePasswordResetReason to be getForceSetPasswordReason / setForceSetPasswordReason (2) Sync Service - encapsulate setForceSetPasswordReasonIfNeeded logic into own method
* PM-3275 - SetPassword Comp - Rename "identifier" to be "orgSsoIdentifier" for clarity
* PM-3275 - SetPasswordComp - Moving routing from SSO / 2FA comps to Lock / LoginWithDevice comps results in a loss of the the OrgSsoId. However, as part of the TDE work, we added the OrgSsoId to state so use that as a fallback so we can accurately evaluate if the user needs to be auto enrolled in admin account recovery.
* PM-3275 - SetPasswordComp - add a bit more context to why/when we are reading the user org sso id out of state
* PM-3275 - SetPassword Comp - (1) Add forceSetPasswordReason and ForceSetPasswordReason enum as public props on the class so we can change copy text based on which is set + set forceSetPasswordReason on ngOnInit (2) Refactor ngOnInit to use a single RxJs observable chain for primary logic as the auto enroll check was occurring before the async getUserSsoOrganizationIdentifier could finish.
* PM-3275 - Desktop - App comp - missed replacing getForcePasswordResetReason with getForceSetPasswordReason
* PM-3275 - TDE Decryption Option Comps - must set ForceSetPasswordReason so that we can properly enforce keeping the user on the component + display the correct copy explaining the scenario to the user.
* PM-3275 - All Clients - SetPasswordComp html - Update page description per product + remove no longer used ssoCompleteRegistration translation.
* PM-3275 - SetPasswordComp - hopefully the final puzzle piece - must clear ForceSetPasswordReason in order to let user navigate back to vault.
* PM-3275 - SyncService - Remove check for previous value of account decryption options hasManageResetPasswordPermission as when a user logged in on a trusted device after having their permissions updated, the initial setting would be true and it would cause the flag to NOT be set when it should have.
* PM-3275 - TDE User Context - (1) Remove explicit navigation to set password screen from post decryption success scenarios on lock & login w/ device comps (2) Move TdeUserWithoutPasswordHasPasswordResetPermission flag setting to SSO / 2FA components to support both trusted and untrusted device scenarios (both of which are now caught by the auth guard).
* PM-3275 - (1) SetPassword comp - adjust set password logic for TDE users to avoid creating a new user asymmetric key pair and setting a new private key in memory. (2) Adjust SetPasswordRequest to allow null keys
* PM-3275 - Remove unused route from login with device comp
* PM-3275 - Sso & 2FA comp tests - Update tests to reflect new routing logic when TDE user needs to set a password
* PM-3275 - Lock comp - per PR feedback, remove unused setPasswordRoute property.
* PM-3275 - SetPasswordComp - Per PR feedback, use explicit null check
* PM-3275 - Per PR Feedback, rename missed forcePasswordResetReason to be forceSetPasswordReason on account model
* PM-3275 - Auth guard - rename forcePasswordResetReason to forceSetPasswordReason
* PM-3275 - SSO / 2FA comps - Per PR feedback, refactor Admin Force Password reset handling to be in one place above the TDE user flows and standard user flows as it applies to both.
* PM-3275 - Per PR feedback, clarify 2FA routing comment
* PM-3275 - Per PR feedback, update set-password comp ngOnInit switchMaps to just return promises as switchMap converts promises to observables internally.
* PM-3275 - Per PR feedback, refactor set password ngOnInit observable chain to avoid using async subscribe and instead simply sequence the calls via switchMap and tap for side effects.
* PM-3275 - Per PR feedback, move tap after filter so we can remove if check
* PM-3275 - Per PR feedback, update policy service mapping methods to use shorthand null checking.
* PM-3275 - SetPassword comp - (1) Move force set password reason logic into onSetPasswordSuccess(...) (2) On onSetPasswordSuccess, must set hasMasterPassword to true for user verification scenarios.
* PM-3275 - Per PR feedback, remove new hasManageResetPasswordPermission flag from profile response and instead simply read the information off the existing profile.organizations data as the information I needed was already present.
* PM-4633 - PolicyService - mapPolicyFromResponse(...) - remove incorrect null check for data. Policies with internal null data property should still be evaluated and turned into Policy objects or the policy array ends up having null values in it and it causes errors down the line on login after acct creation.
* [PM-3722] fix: wrong translation bug
* [PM-3722] feat: use user verification component during creation
* [PM-3722] feat: use user verification component during deletion
* [PM-3722] feat: improve error handling
* [EC-598] feat: scaffold content scripting
* [EC-598] feat: load page script from content script
* [EC-598] feat: succesfully intercept methods
* [EC-598] feat: add better support for messaging
* [EC-598] feat: implement calls to new service
* [EC-598] feat: add ability to return responses
* [EC-598] feat: half-implemented params mapping
* [EC-598] feat: add b64 conversion
* [EC-598] feat: half-implemented user interfacing
* [EC-598] feat: initial working user verification
* [EC-598] feat: center popup
* [EC-598] feat: add basic cancel button
* [EC-598] feat: confirm new credentials
* [EC-598] feat: add cbor-redux npm package
* [EC-598] feat: initial version of credential creation
* [EC-598] feat: fully working credential creation
* [EC-598] feat: fully working register and assert flow
* [EC-598] feat: properly check for presence
* [EC-598] feat: rudimentar error handling
* [EC-598] feat: transparent passthrough of platform authenticators
* [EC-598] feat: improve error handling
* [EC-598] feat: use browser as fallback when vault does not contain requested credential
* [EC-598] feat: add fido2Key to cipher
* [EC-598] feat: successfully store passkeys in vault
* [EC-598] feat: implement passwordless vault auth
* [EC-598] feat: add basic support for managing passkeys
* [EC-598] feat: show new cipher being added
* [EC-598] feat: allow user to pick which credential to use
* [EC-598] feat: differntiate between resident auth and 2fa
* [EC-598] feat: add some padding to popout
* [EC-598] feat: allow storage of more information
* [EC-598] feat: show user name as sub title
* [EC-598] feat: show all available data
* [EC-598] chore: clean up console logs
* [EC-598] feat: fix google issues
Google does not like self-signed packed format. I've removed the attestation statement all-together untill further notice. We're don't really have any statements so
* [EC-598] fix: temporarily remove origin check
* [EC-598] fix: user interaction not being awaited sometimes
Only one handler can return a response. That handler needs to return true to indicated it's intention to eventually do so.
Our issue was that multiple handlers were returning truthy values, causing a race condition.
* [EC-598] fix: messenger crashing
The messenger is listening to all DOM communcation, most of which is formatted differently. We were not handling these cases properly which resulted in attempts to access undefined fields.
* [EC-598] feat: add basic test-case for messenger
* [EC-598] feat: add test for request/response
* [EC-598] feat: add initial one-way support for aborting
* [EC-598] feat: add ability to throw errors across messenger
* [EC-598] feat: transition to using exceptions
* [EC-598] feat: add abort controller all the way to service
* [EC-598] feat: ability to abort from page script
* [EC-598] feat: add automatic default timeouts
* [EC-598] chore: move component from generic popup fodler
* [EC-598] chore: collect all passkeys stuff under common folder
* [EC-598] fix: filter messages from other sources
* [EC-598] chore: add small todo comment
* [EC-598] feat: add timeout and UV to params
* [EC-598] feat: implement full support for timeouts
* [EC-598] feat: start creating separate authenticator service
* [EC-598] feat: first tested rule in new authentitcator
* [EC-598] feat: allow user to confirm duplication
* [EC-598] feat: add check for unsupported algorithms
* [EC-598] feat: add check for invalid option values
* [EC-598] feat: handle unsupported pinAuth
* [EC-598] feat: confirm new credentials
* [EC-598] feat: rearrange order of execution
* [EC-598] chore: rearrange tests
* [EC-598] feat: add support for saving discoverable credential
* [EC-598] feat: remove ability to duplicate excluded credentials
* [EC-598] chore: rearrange tests
* [EC-598] feat: add support for non-discoverable credentials
* [EC-598] chore: use webauthn authenticator model as base instead of CTAP
* [EC-598] feat: don't leak internal errors during creation
* [EC-598] feat: tweak key data to contain separate type and algorithm
* [EC-598] feat: add counter to fido2key
* [EC-598] feat: complete implementation of `makeCredential`
* [EC-598] feat: add ignored enterpriseAttestation param
* [EC-598] feat: start implementing `getAssertion`
* [EC-598] feat: add separate `nonDiscoverableId` to keys
* [EC-598] fix: properly convert credentials to guid raw format
* [EC-598] chore: add todo tests about deleted items
* [EC-598] feat: implement missing credential checks
* [EC-598] feat: add user confirmation test to assertion
also rewrite to use cipher views in tests
* [EC-598] feat: increment counter during assertion
* [EC-598] feat: implement assertion
* [EC-598] feat: add signatures to attestation
* [EC-598] feat: add general error handling for attestation
* [EC-598] feat: start working on new `Fido2ClientService`
* [EC-598] feat: check user id length
* [EC-598] feat: check origin and rp.id effective domains
* [EC-598] feat: check for supported key algorithms
* [EC-598] feat: hash client data and throw if aborted
* [EC-598] feat: extend return from authenticator
* [EC-598] feat: fully implement createCredential
* [EC-598] feat: implement assertCredential
* [EC-598] feat: make everything compile again
* [EC-598] feat: remove orgigin
* [EC-598] fix: rpId validation logic
* [EC-598] fix: some smaller bugs
* [EC-598] fix: flag saying authData doesnt contain attestation
* [EC-598] fix: wrong flags in tests
* [EC-598] fix: data not getting saved properly
* [EC-598] fix: invalid signature due to double hashing
* [EC-598] chore: clean up unusued function
* [EC-598] feat: fully wokring non-discoverable implementation
* [EC-598] feat: add initial implementation of UI sessions
* [EC-598] feat: fully refactored user interface
Now uses sessions instead of single request-response style communcation
* [EC-598] feat: make fallback working again
* [EC-598] feat: add rudimentary support for excluded credentials
* [EC-598] fix: send correct excluded cipher ids
* [EC-598] feat: wait for session close before closing window
* [EC-598] feat: test unique signatures
* [EC-598] chore: clean up old commented code
* [EC-598] feat: do not exclude organization credentials
* [EC-598] chore: remove unused clas
* [EC-598] fix: remove platform attachment check
* [EC-598] chore: rename webauthn folder to fido2
* [EC-598] chore: continue rename webauthn to fido2
* [EC-598] feat: interpret rk preferred as required
Fixes GoDaddy issues
* [EC-598] fix: bug preventing fallback on assertion
* [EC-598] feat: inform user when no credentials are found
* [EC-598] chore: add some more console logs for debugging
* [EC-598] feat: very basic scroll when picking credentials
* [EC-598] chore: tweak unique signature test
* [EC-598] chore: tweak how unassigned rpId gets calcuated
* [EC-598] fix: response prototype chains
* [EC-598] feat: allow discoverable credentials to be used for non-discoverable assertions
* [EC-598] fix: counter not being saved correctly
* [EC-598] fix: bug in result mapping
* [EC-598] feat: add support for user verifiction using MP during attestation
* [EC-598] feat: add support for user verifiction using MP during assertion
* [EC-598] feat: quick fix noop service
* [EC-598] chore: refactor observables a little bit
* [EC-598] feat: show unsupported user verification error
* [EC-598] feat: add logging to fido2 authenticator
* [EC-598] feat: add logging to fido2 client
* [EC-598] feat: close popout directly from bg script
* [EC-598] chore: clean up page-script
* [EC-598] feat: add webauthn polyfill
* [EC-598] feat: polyfill platform authenticator support
* [EC-598] feat: only show fallback options if supported
* [EC-598] fix: reponse not correctly polyfilled
* [EC-598] chore: add name to polyfill classes
* [EC-598] chore: update unsupported UV copy
* [EC-598] fix: race condition when opening new popout
* Fixed lint issues
* [PM-1500] Add feature flag to enable passkeys (#5406)
* Added launch darkly feature flag to passkeys implementation
* fixed linter
* Updated fido2 client service test to accomodate feature flag
* Updated fido2client service to include unit test for feature flag
* Renamed enable pass keys to fido2 vault credentials, added unit test when feature flag is not enabled
* fixed failing Login domain test case
* [EC-598] chore: remove unecessary return statement
* [EC-598] chore: remove unnecessary eslint disable
* [PM-1975] Move FIDO2 files into vault folder (#5496)
* Moved fido2 models to vault in libs
* Moved fido2 models to vault in libs
* Moved fido2 services and abstractions to vault folder in libs
* Moved fido2 popup to vault folder on the browser
* Updated import path after moving files to the vault folder
* Moved authenticator abstraction and service to the vault folder
* Updated content and page script path
* Added content script, page script and background messaging to vault
* fixed lint issue
* Updated reference paths
* Added missing fallbacksupported property in test files
* Added missing fallbacksupported to the newSession method
* [PM-2560] Fix Firefox default passkeys handling (#5690)
* Return callback response in addListener
* Add clarifying comment
* Isolate returning the callback to fido2 commands
* Update apps/browser/src/platform/browser/browser-api.ts
Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
* Fix formatting
---------
Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
* [PM-1976] Display passkeys properly on the browser (#5616)
* Removed passkeys from the vault types filter and added fucntion to get the count of Fido2keys and Login types
* Updated build filter to take Fido2key type as a Login type
* Updated icon font files
* Updated vault items and view to handle changes with fido2keys
* Updated add edit view for fido2keys
* Prevent moving passkeys to an organization where it exists
* Prevent moving passkeys to an organization where it exists
* Added view for non-discoverable passkeys
* Added diaglog to inform user that passkey won't be copied when cloning a non discoverable key
* Muted text that shows cipher item is available for 2fa
* Changed conditional to check if an organization already has the same passkey item
* Muted text to align with figma designs and used rpId for the application input value
* Modified checkFido2KeyExistsInOrg function to workk with discoverable and non discoverable keys
* Differentiate between non-discoverable and discoverable keys when moving to an organization
* Added suggested changes from PR review
* Updated font files css changes
* Fixed bug preventing launch bitton from working for Login types (#5639)
* [PM-1574] Display passkeys on web (#5651)
* Allowed discoverable Fido2key type to be displayed alongside Login type
* Added view during edit for discoverable and non-discoverable passkeys
* Fixed PR comments, added relvant tests to domain changes
* Fixed imports and updated the launch function to use the Launchable interface
* Added launch on vault filter for fido2key types
* Added missing passkey text field in edit view (#5800)
* [PM-1977] Display passkeys properly on the desktop (#5763)
* Allowed discoverable Fido2key type to be displayed alongside Login type
* Added view during edit for discoverable and non-discoverable passkeys
* Fixed PR comments, added relvant tests to domain changes
* Fixed imports and updated the launch function to use the Launchable interface
* Added fido2key to login filter and added view display for fido2key
* Added passkeys view for non discoverable passkeys and edit view for passkeys
* Fixed PR comments
* switched date format to short
* [PM-3046] [PM-3047] Defects for discoverable and non-discoverable passkeys on desktop and web (#5847)
* Added missing passkey text field in edit view (#5800)
* Added dialog to clone no discoverable passkeys on web and desktop.Also, removed clone on the desktop for discoverable passkeys and added passkey view to non- discoverable passkeys on desktop during edit
* Prevent cloning dialog on non fido2key ciphers
* Made fido2key use website favicon if avaialble instead of the passkey icon
* Do not display passkey view on clone edit for dekstop
* Do not display passkey view on clone edit for browser
* Prevented movement of passkeys ND or D to an organization once one exists and also made it possible for org memebers with user roles to move passkeys to an organization. (#5868)
* two step passkey view was outside the conditional (#5872)
* fixed merge conflict
* [PM-2907] Shopify Passkey Broken on Firefox When Extension is Installed (#6003)
* [PM-2907] Shopify Passkey Broken on Firefox When Extension is Installed
* [PM-2907] Shopify Passkey Broken on Firefox When Extension is Installed
* [PM-2907] Shopify Passkey Broken on Firefox When Extension is Installed
* Added passkey fallback imaged and added extension to image name on the icons component
* [PM-3155] CLI: Editing a cipher with a non-discoverable passkey causes the passkey to be removed (#6055)
* Added fido2keyexport for the CLI and added the fido2key field to the login response for the CLI
* Added fido2keyexport for the CLI and added the fido2key field to the login response for the CLI
* Removed unneccesary code
* Added non discoverable passkey to template
* [PM-2270] Renamed Fido2Key.userName to Fido2Key.userDisplayName (#6005)
* Renamed fido2key property username to userDisplayName
* Renamed username property on fido2key object to userdisplayname
* updated username to userDisplayName in fido2 export
* Update libs/angular/src/vault/vault-filter/models/vault-filter.model.ts
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
* [PM-3775] feat: import v0.4.0 (#6183)
* [PM-3660] Address PR feedback (#6157)
* [PM-3660] chore: simplify object assignment
* [PM-3660] fix: remove unused origin field
* [PM-3660] feat: add Fido2Key tests
* [PM-3660] chore: convert popOut to async func
* [PM-3660] chore: refactor if-statements
* [PM-3660] chore: simplify closePopOut
* [PM-3660] fix: remove confusing comment
* [PM-3660] chore: move guid utils away from platform utils
* [PM-3660] chore: use null instead of undefined
* [PM-3660] chore: use `switch` instead of `if`
* [EC-598] fix: popup not closing bug
* [PM-1859] Refactor to credentialId (#6034)
* PM-1859 Refactor to credentialId
* PM-1859 Minor changes
* PM-1859 Fix credentialId initialization logic
* PM-1859 Added missing logic
* PM-1859 Fixed logic to use credentialID instead of cipher.id
* [PM-1859] fix: missing renames
---------
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
* [PM-1722] gracefully fail if site prompts user for passkey on load (#6089)
* added error logic to look for options.mediation in page-script
* moved the options mediation logic into the try catch. changed error to FallbackRequestedError
* [PM-1224] Ensure Passkeys Not Requested From Iframes (#6057)
* added isNotIFrame method to page-script
* added NotAllowedError to assertCredential in fido2
* remove excess comments
* refactor fido2-client.service. created new errorhandling method for similar code between create and assert
* update types and naming convention for new method in fido2-client.service
* Did a reset to previous commit withiout the refactoring to reduce code duplication, Renamed isNotIframeCheck function and fixed other commits
* Revert "update types and naming convention for new method in fido2-client.service"
This reverts commit 1f5499b9bb.
* Revert "refactor fido2-client.service. created new errorhandling method for similar code between create and assert"
This reverts commit 3115c0d2a1.
* updated test cases
* removed forward slashes
---------
Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
* [EC-598] Window Messaging Fix; (#6223)
Co-authored-by: Cesar Gonzalez <cgonzalez@bitwarden.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
* updated test cases and services using the config service
* [PM-3807] All passkeys as login ciphers - Minimal implementation to minimize blockers (#6233)
* [PM-3807] feat: remove non-discoverable from fido2 user interface class
* [PM-3807] feat: merge fido2 component ui
* [PM-3807] feat: return `cipherId` from user interface
* [PM-3807] feat: merge credential creation logic in authenticator
* [PM-3807] feat: merge credential assertion logic in authenticator
---------
Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
* [PM-3807] Store all passkeys as login cipher type (#6255)
* [PM-3807] feat: add `discoverable` property to fido2keys
* [PM-3807] feat: assign discoverable property during creation
* [PM-3807] feat: save discoverable field to server
* [PM-3807] feat: filter credentials by rpId AND discoverable
* [PM-3807] chore: remove discoverable tests which are no longer needed
* [PM-3807] chore: remove all logic for handling standalone Fido2Key
View and components will be cleaned up as part of UI tickets
* [PM-3807] fix: add missing discoverable property handling to tests
* [PM-3862] chore: move browser fido2 user interface to vault folder (#6265)
* [PM-2207], [PM-1245], [PM-3302] Make browser login, lock, and 2fa components handle configurable redirect routes (#5989)
* Initial work
* Added lock and login redirect and added functionality to abort when in login or locked state
* uncommented cipher row
* added query params to logi component
* Proof of concept for change detection fix
* Remove leftover comment
* Refactored message listener observable to handle angular change detection
* cleanup and removed unused references
* Refactored the connect method be seperating to the pop out logic to a seperate method
* Added comment to explain code change on the message listener
* Removed unused types
* Initial work
* Added lock and login redirect and added functionality to abort when in login or locked state
* uncommented cipher row
* added query params to logi component
* Proof of concept for change detection fix
* Remove leftover comment
* Refactored message listener observable to handle angular change detection
* cleanup and removed unused references
* Refactored the connect method be seperating to the pop out logic to a seperate method
* Added comment to explain code change on the message listener
* Removed unused types
* Added full synce service to the fido2 authenticator to ensure the full sync is completed before getting all decrypted ciphers
* Added full synce service to the fido2 authenticator to ensure the full sync is completed before getting all decrypted ciphers
* Code cleanup to remove sessionId from login component
* Refactored components to make the redirectUrl more generic, fixed code review comments
* Commented out ensureUnlockedVault for this PR
* Fixed destroy subject inheritance issue on the login componenet
* Fixed lock component error
* Added function to run inside angular zone
* Merged branch with master and fixed conflicts
* Changed redirect logic on login and 2fa to use callbacks
* fixed pr comments
* Updated the messageListener observable version to use same logic from the callback version and added comment on the callback version
* Refactored fido2 popup to use auth guard when routing to component, added BrowserRouterService to track previous page and route using that
* Updated components to use browserRouterService for routing to previous page
* Removed auth status reference from browser-fido2-user-interface service
* Removed activated route from lock component
* Removed route in base class constructor
* removed unused comments and method
* refactored router service to not store on the disk
* [PM-3783] feat: patch `chrome.runtime.onMessage` event listeners
(cherry picked from commit 2ca241a0d4)
* Fixed PR comments
* Fixed PR comments
* Revert "[PM-3783] feat: patch `chrome.runtime.onMessage` event listeners"
This reverts commit ed6a713688.
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
* [PM-3807] Store passkeys as array (#6288)
* [PM-3807] feat: store passkeys as array
* [PM-3807] fix: issues in views
* [PM-3807] fix: additional view bugs
* [PM-3807] fix: check array length
* [PM-3807] fix: I secretly like build errors
* [PM-3970] Empty list of ciphers when logging in via fido 2 popout (#6321)
* fix: sync not being properly called
* fix: don't call sync everywhere
* [PM-3905] Address PR feedback v2 (#6322)
* [PM-3905] chore: move webauthn utils to vault
* [PM-3905] chore: make static function private
* [PM-3905] chore: add documentation to user interface classes
* [PM-3905] chore: clean up unused abort controllers
* [PM-3905] chore: add documentation to fido2 client and authenticatio
* [PM-3905] chore: extract create credential params mapping to separate function
* [PM-3905] chore: extract get assertion params mapping to separate function
* [PM-3905] chore: assign requireResidentKey as separate variable
* [PM-3905] feat: started rewrite of messenger
Basic message sending implemented, now using message channels instead of rxjs
* [PM-3905] feat: complete rewrite of messenger
* [PM-3905] chore: clarify why we're assigning to window
* [PM-3905] feat: clean up tests
* [PM-3905] docs: document messenger class
* [PM-3905] feat: remove `requestId` which is no longer needed
* [PM-3905] feat: simplify message structure
* [PM-3905] chore: typo
* [PM-3905] chore: clean up old file
* [PM-3905] chore: tweak doc comment
* [PM-3905] feat: create separate class for managing aborts
* [PM-3905] chore: move abort manager to vault
* [PM-3980] Add a creationDate field to the Fido2Key object (#6334)
* Added creationDate field to be used on the passkeys view instead of the cipher.creationDate
* Fixed comments from PR
* added to the constructor and sorted out other comments
* Exported Fido2KeyExport through index.ts
* Fixed iso string issue where the date wasn't converted back to Date (#6364)
* [PM-4045] Get error returned when editing an item with a passkey in the CLI (#6379)
* Creationdate doesn't get converted to a date
* Creationdate doesn't get converted to a date
* removed null assignment
* [PM-3810] Unify Passkeys view (#6335)
* Removed standalone fido2key view, update login view to show created date when a fido2key is present, reverted icon component to previous state without fido2key type, removed filters to handle standalone fido2key as login type
* Allow duplication
* Removed launchable behaviours from fido2 key view
* Reworked desktop views from standalone fido2keys to unified fido2keys in the login
* Reworked web views from standalone fido2keys to unified fido2keys in the login
* Fixed test case to not create standalone fido2keys
* Updated views to use fido2key creation date
* removed unused locale
* moved logic from template to class
* Removed fido2key ciphertype
* Removed fido2key ciphertype references
* PM-2559 Messaging Rework for Passkey Bug (#6282)
* [PM-2559] Messaging Rework - Update browser-api messageListener removing promises to fix Firefox bug
Co-authored-by: Cesar Gonzalez <cgonzalez@bitwarden.com>
* Resolved merge conflicts from vault item encryption.
* moved passkeys ontop totp code to align with the add edit view (#6466)
* Bug during reafactoring where the hostname is not used if the rpId is undefined (#6484)
* [PM-4054] Rename Fido2Key to Fido2Credential (#6442)
* Rename Fido2Key to Fido2Credential
* Fix export
* Remove unnecessary alis in export
* Make test less wordly
---------
Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
* [PM-3812][PM-3809] Unify Create and Login Passkeys UI (#6403)
* PM-1235 Added component to display passkey on auth flow
* PM-1235 Implement basic structure and behaviour of UI
* PM-1235 Added localised strings
* PM-1235 Improved button UI
* Implemented view passkey button
* Implemented multiple matching passkeys
* Refactored fido2 popup to use browser popout windows service
* [PM-3807] feat: remove non-discoverable from fido2 user interface class
* [PM-3807] feat: merge fido2 component ui
* [PM-3807] feat: return `cipherId` from user interface
* [PM-3807] feat: merge credential creation logic in authenticator
* [PM-3807] feat: merge credential assertion logic in authenticator
* updated test cases and services using the config service
* [PM-3807] feat: add `discoverable` property to fido2keys
* [PM-3807] feat: assign discoverable property during creation
* [PM-3807] feat: save discoverable field to server
* [PM-3807] feat: filter credentials by rpId AND discoverable
* [PM-3807] chore: remove discoverable tests which are no longer needed
* [PM-3807] chore: remove all logic for handling standalone Fido2Key
View and components will be cleaned up as part of UI tickets
* [PM-3807] fix: add missing discoverable property handling to tests
* updated locales with new text
* Updated popout windows service to use defined type for custom width and height
* Update on unifying auth flow ui to align with architecture changes
* Moved click event
* Throw dom exception error if tab is null
* updated fido2key object to array
* removed discoverable key in client inerface service for now
* Get senderTabId from the query params and send to the view cipher component to allow the pop out close when the close button is clicked on the view cipher component
* Refactored view item if passkeys exists and the cipher row views by having an extra ng-conatiner for each case
* Allow fido2 pop out close wehn cancle is clicked on add edit component
* Removed makshift run in angular zone
* created focus directive to target first element in ngFor for displayed ciphers in fido2
* Refactored to use switch statement and added condtional on search and add div
* Adjusted footer link and added more features to the login flow
* Added host listener to abort when window is closed
* remove custom focus directive. instead stuck focus logic into fido2-cipher-row component
* Fixed bug where close and cancel on view and add component does not abort the fido2 request
* show info dialog when user account does not have master password
* Removed PopupUtilsService
* show info dialog when user account does not have master password
* Added comments
* Added comments
* made row height consistent
* update logo to be dynamic with theme selection
* added new translation key
* Dis some styling to align cipher items
* Changed passkey icon fill color
* updated flow of focus and selected items in the passkey popup
* Fixed bug when picking a credential
* Added text to lock popout screen
* Added passkeys test to home view
* changed class name
* Added uilocation as a query paramter to know if the user is in the popout window
* update fido2 component for dynamic subtitleText as well as additional appA11yTitle attrs
* moved another method out of html
* Added window id return to single action popout and used the window id to close and abort the popout
* removed duplicate activatedroute
* added a doNotSaveUrl true to 2fa options, so the previousUrl can remain as the fido2 url
* Added a div to restrict the use browser link ot the buttom left
* reverted view change which is handled by the view pr
* Updated locales text and removed unused variable
* Fixed issue where new cipher is not created for non discoverable keys
* switched from using svg for the logo to CL
* removed svg files
* default to browser implmentation if user is logged out of the browser exetension
* removed passkeys knowledge from login, 2fa
* Added fido2 use browser link component and a state service to reduce passkeys knowledge on the lock component
* removed function and removed unnecessary comment
* reverted to former
* [PM-4148] Added descriptive error messages (#6475)
* Added descriptive error messages
* Added descriptive error messages
* replaced fido2 state service with higher order inject functions
* removed null check for tab
* refactor fido2 cipher row component
* added a static abort function to the browser interface service
* removed width from content
* uncommented code
* removed sessionId from query params and redudant styles
* Put back removed sessionId
* Added fallbackRequested parameter to abortPopout and added comments to the standalone function
* minor styling update to fix padding and color on selected ciphers
* update padding again to address vertical pushdown of cipher selection
---------
Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com>
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com>
Co-authored-by: jng <jng@bitwarden.com>
* padding update for focused cipher row in popup
* Updated fido2Credentials to initialize as null instead of empty array (#6548)
* Updated fido2Credentials to be null instead of empty string
* Updated cipher tests.
* Fixed tests.
* Updated view and clone logic.
* Updated templates to handle null value.
* Further null checks.
* [PM-4226] Create login item on the fly and add passkey item to it (#6552)
* Use the + button to ad an item and then save a passkey on the added item
* switch if to tenary
* [PM-4284] Passkey popout is not pulling correct URI for website opened (#6549)
* Used url from sender window in getting matching logins
* Rough draft to combine user verification required and master password required prompts
* Revert "Rough draft to combine user verification required and master password required prompts"
This reverts commit f72d6f877f.
* Remove array initialization that is not necessary. (#6563)
* removed unused code from login, 2fa components (#6565)
* Moved clearing of passkey from submit to load when cloning. (#6567)
* [PM-4280] MP reprompt not respected on passkey creation and retrieval (#6550)
* Rough draft to combine user verification required and master password required prompts
* Updated the handle user verification logic
* allow same behaviour for master password reprompt and user verification
* added test cases and merged conditions
* [PM-4226] Add Cipher With Passkey Flow Change (#6569)
* changed the add login item with passkey to require master password repompt first before creating the cipher item
* removed userVerified variable
* combined conditionals
* added passkey not copied alert when cloning for organizations (#6579)
* [PM-4296] Cannot login to Bitwarden with FIDO2 WebAuthn if extension is installed and logged in (#6576)
* removed sameOriginWithAncestors check on fido2 assertions
* removed sameOriginWithAncestors check on fido2 assertions
* [PM-4333] fix: change transport to `internal` (#6594)
* Address PR feedback (#6572)
* remove listeners for safari
* removed unused i18n tokens
* changed link to button for accessibilty purposes
* Fix potential reference error by restoring the typeof check for chrome
* added fromNullable to reduces repetitive logic
* Revert "added fromNullable to reduces repetitive logic"
This reverts commit ce5fc9c278.
* Added js docs to fido2credential export
* refined jsdocs comments
* added documentation to fido2 auth guard
* Removed unused i18n tokens, uneccesary whitespaces and comments
---------
Co-authored-by: gbubemismith <gsmithwalter@gmail.com>
Co-authored-by: SmithThe4th <gsmith@bitwarden.com>
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
Co-authored-by: Cesar Gonzalez <cesar.a.gonzalezcs@gmail.com>
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Co-authored-by: Carlos Gonçalves <cgoncalves@bitwarden.com>
Co-authored-by: Jason Ng <jng@bitwarden.com>
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com>
Co-authored-by: Cesar Gonzalez <cgonzalez@bitwarden.com>
Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Co-authored-by: Todd Martin <tmartin@bitwarden.com>
* update password reprompt to use the dialog CL
* Override showPasswordPrompt and submit method on web child classes from base classes to allow dialog work on web and modal on other clients
* Override showPasswordPrompt and submit method on web child classes from base classes to allow dialog work on web and modal on other clients
* Fixed lint issues
* Corrected comments
* Refactored passwored reprompt to use dialog service after changes to make the dialog service work on the desktop and browser
* Changed access modifier from protected to protected
* Refactored passwprd reprompt component to a stand alone component and fixed all references
* fix merge changes
* fix import aliases in password-reprompt.component.ts
* fix alias typo in browser tsconfig
* import from root vault alias
* revert tsconfig changes
* remove service abstraction and update imports
* remove component from imports
* Removed unneccesary show password toggle
* renamed selector to use vault prefix
* removed unnecessary data dismiss
* merged and fixed conflicts
* remove reintroduced file
* Added appAutoFocus to reprompt dialog
* delayed validation until submit happens
---------
Co-authored-by: William Martin <contact@willmartian.com>
